Commit 0d5852a
authored
telemetry:vsc: add
## Problem:
The `source` value has become a common pattern in our telemetry which
answers "who" caused the metric event. For example if we had a
function() to open a menu, there could be many different entrypoints
that could call it.
Right now we have to add `source` to each metric that uses it, but this
usage has increased for a lot of metrics.
## Solution:
- `source` will be a part of all metrics as an optional field.
- This has only been implemented for VSC.
## TODO
The other IDEs should consider following this pattern if not already.
**If all IDEs implement this then we can remove the explicit
requirements of `source` in `commonDefinitions.json`**
<!---
REMINDER:
- Read CONTRIBUTING.md first.
- Add test coverage for your changes.
- Link to related issues/commits.
- Testing: how did you test your changes?
- Screenshots if applicable
-->
## License
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Signed-off-by: nkomonen-amazon <[email protected]>source to common fields (#977)1 parent ccb16ca commit 0d5852a
File tree
4 files changed
+6
-1
lines changed- telemetry
- definitions
- vscode
- src
- test/resources
4 files changed
+6
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1782 | 1782 | | |
1783 | 1783 | | |
1784 | 1784 | | |
1785 | | - | |
| 1785 | + | |
1786 | 1786 | | |
1787 | 1787 | | |
1788 | 1788 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| 139 | + | |
139 | 140 | | |
140 | 141 | | |
141 | 142 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
| |||
0 commit comments