Skip to content

Commit 745792c

Browse files
telemetry(lsp): standardize setup metric and types (#961)
## Problem Relevant PR: aws/aws-toolkit-vscode#6385 ## Solution - standardize the metrics across the toolkits. <!--- REMINDER: - Read CONTRIBUTING.md first. - Add test coverage for your changes. - Link to related issues/commits. - Testing: how did you test your changes? - Screenshots if applicable --> ## License By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Shruti Sinha <[email protected]>
1 parent 0896ded commit 745792c

File tree

1 file changed

+61
-0
lines changed

1 file changed

+61
-0
lines changed

telemetry/definitions/commonDefinitions.json

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1491,6 +1491,23 @@
14911491
"type": "string",
14921492
"description": "Language used for the project."
14931493
},
1494+
{
1495+
"name": "languageServerLocation",
1496+
"type": "string",
1497+
"allowedValues": ["cache", "remote", "fallback", "override"],
1498+
"description": "The location of the language server"
1499+
},
1500+
{
1501+
"name": "languageServerSetupStage",
1502+
"type": "string",
1503+
"allowedValues": ["getManifest", "getServer", "validate", "launch", "handshake", "all"],
1504+
"description": "The stage of the LSP setup process"
1505+
},
1506+
{
1507+
"name": "languageServerVersion",
1508+
"type": "string",
1509+
"description": "The version of the language server"
1510+
},
14941511
{
14951512
"name": "loadFileTime",
14961513
"type": "int",
@@ -1501,6 +1518,17 @@
15011518
"type": "string",
15021519
"description": "User locale. Examples: en-US, en-GB, etc."
15031520
},
1521+
{
1522+
"name": "manifestLocation",
1523+
"type": "string",
1524+
"allowedValues": ["cache", "remote", "override"],
1525+
"description": "The location of the manifest"
1526+
},
1527+
{
1528+
"name": "manifestSchemaVersion",
1529+
"type": "string",
1530+
"description": "The version of the manifest schema file"
1531+
},
15041532
{
15051533
"name": "metricId",
15061534
"type": "string",
@@ -6189,6 +6217,39 @@
61896217
}
61906218
]
61916219
},
6220+
{
6221+
"name": "languageServer_setup",
6222+
"description": "Sets up a language server",
6223+
"passive": true,
6224+
"unit": "Milliseconds",
6225+
"metadata": [
6226+
{
6227+
"type": "id"
6228+
},
6229+
{
6230+
"type": "languageServerLocation",
6231+
"required": false
6232+
},
6233+
{
6234+
"type": "languageServerSetupStage"
6235+
},
6236+
{
6237+
"type": "languageServerVersion",
6238+
"required": false
6239+
},
6240+
{
6241+
"type": "manifestLocation",
6242+
"required": false
6243+
},
6244+
{
6245+
"type": "manifestSchemaVersion",
6246+
"required": false
6247+
},
6248+
{
6249+
"type": "result"
6250+
}
6251+
]
6252+
},
61926253
{
61936254
"name": "rds_createConnectionConfiguration",
61946255
"description": "Called when creating a new database connection configuration to for a RDS database. In Datagrip we do not get this infromation if it is created directly, so this is only counts actions.",

0 commit comments

Comments
 (0)