Skip to content

Commit 988f4c0

Browse files
feat: Add viewId common definition type
This adds a new type called `viewId` which uniquely identifies a part of the UI in an IDE window. The `viewId` should be a comma delimited string where each item appended is a more specific part of the UI within the previous item. The top level (first item) part of the string should be an identifier for the specific IDE window, as it is possible to have multiple windows of the same IDE opened at the same time. Then if there is a specific view within that specific IDE window you would append its identifier. Example: - I have 2 VS Code windows with IDs: `abc-123` and `xyz-789` - My Amazon Q chat view has an ID `amazonq-chat` - Result `viewId`: `abc-123,amazonq-chat` and `xyz-789,amazonq-chat` Now in my metrics I will be able to differentiate metrics by their viewId since they both share the same clientId by design. Signed-off-by: Nikolas Komonen <[email protected]>
1 parent cfc676d commit 988f4c0

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

package-lock.json

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

telemetry/definitions/commonDefinitions.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1681,6 +1681,11 @@
16811681
"type": "string",
16821682
"description": "A generic version metadata"
16831683
},
1684+
{
1685+
"name": "viewId",
1686+
"type": "string",
1687+
"description": "Identifies a unique IDE window or sub-view within that unique IDE window. The value should be a comma delimited string where each item is a more specific view within the parent."
1688+
},
16841689
{
16851690
"name": "workflowToken",
16861691
"type": "string",

telemetry/vscode/src/generate.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ const commonMetadata = [
136136
'requestId',
137137
'requestServiceType',
138138
'result',
139+
'viewId'
139140
] as const
140141

141142
/**

0 commit comments

Comments
 (0)