Skip to content

Commit 9a44a11

Browse files
mkovelammkovelam
committed
FIX: updated metric definitions and fixed the sort order
1 parent e47d240 commit 9a44a11

File tree

1 file changed

+73
-70
lines changed

1 file changed

+73
-70
lines changed

‎telemetry/definitions/commonDefinitions.json‎

Lines changed: 73 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -210,33 +210,6 @@
210210
"type": "string",
211211
"description": "AWS Region associated with a metric\n- \"n/a\" if not associated with a region.\n- \"not-set\" if metric is associated with a region, but region is unknown."
212212
},
213-
{
214-
"name": "agenticReviewArtifactSize",
215-
"type": "double",
216-
"description": "Size of the artifact reviewed/scanned in bytes"
217-
},
218-
{
219-
"name": "agenticReviewArtifactType",
220-
"type": "string",
221-
"description": "Type of the artifact requested to review/scan",
222-
"allowedValues": ["FILE", "FOLDER"]
223-
},
224-
{
225-
"name": "agenticReviewCustomRulesCount",
226-
"type": "int",
227-
"description": "Number of custom guide line files present"
228-
},
229-
{
230-
"name": "agenticReviewFindingsCount",
231-
"type": "int",
232-
"description": "Number of findings discovered after running a review/scan on a source code artifact"
233-
},
234-
{
235-
"name": "agenticReviewType",
236-
"type": "string",
237-
"description": "Identifies the type of agentic review triggered",
238-
"allowedValues": ["FULL_REVIEW", "CODE_DIFF_REVIEW"]
239-
},
240213
{
241214
"name": "buildDuration",
242215
"type": "int",
@@ -342,15 +315,47 @@
342315
"applyFix"
343316
]
344317
},
318+
{
319+
"name": "codeReviewArtifactId",
320+
"type": "string",
321+
"description": "Unique identifier of the uploaded artifact for agentic review"
322+
},
323+
{
324+
"name": "codeReviewArtifactSize",
325+
"type": "double",
326+
"description": "Size of the artifact reviewed/scanned in bytes"
327+
},
328+
{
329+
"name": "codeReviewArtifactType",
330+
"type": "string",
331+
"description": "Type of the artifact requested for code review",
332+
"allowedValues": ["FILE", "FOLDER"]
333+
},
334+
{
335+
"name": "codeReviewCustomRulesCount",
336+
"type": "int",
337+
"description": "Number of custom guide line files present in the code review"
338+
},
339+
{
340+
"name": "codeReviewFindingsCount",
341+
"type": "int",
342+
"description": "Number of findings discovered after running a code review on a source code artifact"
343+
},
345344
{
346345
"name": "codeReviewId",
347346
"type": "string",
348-
"description": "Unique identifier of an agentic review/scan request, combination of projectId and runId"
347+
"description": "Unique identifier of an code review/scan request, combination of projectId and runId"
349348
},
350349
{
351-
"name": "codeScanName",
350+
"name": "codeReviewScanName",
352351
"type": "string",
353-
"description": "Unique identifier of project in the workspace in agentic review tool"
352+
"description": "Unique identifier of project in the workspace in code review tool"
353+
},
354+
{
355+
"name": "codeReviewType",
356+
"type": "string",
357+
"description": "Identifies the type of code review triggered",
358+
"allowedValues": ["FULL_REVIEW", "CODE_DIFF_REVIEW"]
354359
},
355360
{
356361
"name": "codeScanServiceInvocationsDuration",
@@ -2170,11 +2175,6 @@
21702175
"type": "string",
21712176
"description": "Resource subtype of connection start"
21722177
},
2173-
{
2174-
"name": "sourceCodeArtifactId",
2175-
"type": "string",
2176-
"description": "Unique identifier of the uploaded artifact for agentic review"
2177-
},
21782178
{
21792179
"name": "sourceResourceType",
21802180
"type": "string",
@@ -3236,31 +3236,36 @@
32363236
}
32373237
]
32383238
},
3239-
{
3240-
"name": "amazonq_qCodeReviewTool_codeScanSuccess",
3241-
"description": "Captures metrics for successful agentic reviews/scans",
3239+
{
3240+
"name": "amazonq_qCodeReviewTool_codeScanFailed",
3241+
"description": "Captures metrics for failed agentic reviews/scans",
32423242
"metadata": [
32433243
{
3244-
"type": "agenticReviewArtifactType"
3245-
3244+
"type": "codeReviewArtifactId",
3245+
"required": false
3246+
},
3247+
{
3248+
"type": "codeReviewArtifactSize"
32463249
},
32473250
{
3248-
"type": "agenticReviewArtifactSize"
3249-
3251+
"type": "codeReviewArtifactType"
32503252
},
32513253
{
3252-
"type": "agenticReviewCustomRulesCount"
3253-
3254+
"type": "codeReviewCustomRulesCount"
32543255
},
32553256
{
3256-
"type": "agenticReviewFindingsCount",
3257-
"required": true
3257+
"type": "codeReviewId",
3258+
"required": false
32583259
},
32593260
{
3260-
"type": "agenticReviewType"
3261+
"type": "codeReviewScanName",
3262+
"required": false
32613263
},
32623264
{
3263-
"type": "codeReviewId",
3265+
"type": "codeReviewType"
3266+
},
3267+
{
3268+
"type": "reason",
32643269
"required": true
32653270
},
32663271
{
@@ -3269,36 +3274,31 @@
32693274
]
32703275
},
32713276
{
3272-
"name": "amazonq_qCodeReviewTool_codeScanFailed",
3273-
"description": "Captures metrics for failed agentic reviews/scans",
3277+
"name": "amazonq_qCodeReviewTool_codeScanSuccess",
3278+
"description": "Captures metrics for successful agentic reviews/scans",
32743279
"metadata": [
32753280
{
3276-
"type": "agenticReviewArtifactType"
3277-
},
3278-
{
3279-
"type": "agenticReviewArtifactSize"
3281+
"type": "codeReviewArtifactSize"
32803282
},
32813283
{
3282-
"type": "agenticReviewType"
3284+
"type": "codeReviewArtifactType"
32833285
},
32843286
{
3285-
"type": "codeReviewId",
3286-
"required": false
3287+
"type": "codeReviewCustomRulesCount"
32873288
},
32883289
{
3289-
"type": "codeScanName",
3290-
"required": false
3290+
"type": "codeReviewFindingsCount",
3291+
"required": true
32913292
},
32923293
{
3293-
"type": "reason",
3294+
"type": "codeReviewId",
32943295
"required": true
32953296
},
32963297
{
3297-
"type": "result"
3298+
"type": "codeReviewType"
32983299
},
32993300
{
3300-
"type": "sourceCodeArtifactId",
3301-
"required": false
3301+
"type": "result"
33023302
}
33033303
]
33043304
},
@@ -3307,18 +3307,21 @@
33073307
"description": "Captures metrics for timed out agentic reviews/scans",
33083308
"metadata": [
33093309
{
3310-
"type": "agenticReviewArtifactType"
3310+
"type": "codeReviewArtifactSize"
33113311
},
33123312
{
3313-
"type": "agenticReviewArtifactSize"
3313+
"type": "codeReviewArtifactType"
33143314
},
33153315
{
3316-
"type": "agenticReviewType"
3316+
"type": "codeReviewCustomRulesCount"
33173317
},
33183318
{
33193319
"type": "codeReviewId",
33203320
"required": true
33213321
},
3322+
{
3323+
"type": "codeReviewType"
3324+
},
33223325
{
33233326
"type": "reason"
33243327
},
@@ -3332,14 +3335,14 @@
33323335
"description": "Captures metrics for artifact upload failures in agentic reviews/scans",
33333336
"metadata": [
33343337
{
3335-
"type": "codeScanName"
3338+
"type": "codeReviewArtifactSize",
3339+
"required": false
33363340
},
33373341
{
3338-
"type": "agenticReviewArtifactSize",
3339-
"required": false
3342+
"type": "codeReviewArtifactType"
33403343
},
33413344
{
3342-
"type": "agenticReviewArtifactType"
3345+
"type": "codeReviewScanName"
33433346
},
33443347
{
33453348
"type": "reason",

0 commit comments

Comments
 (0)