Add new code transform metric fields and metric type for ApplyChanges (#797)

Updates `commonDefinitions.json` with some new fields used in existing `codeTransform` metric types, as well as a new metric type called `codeTransform_applyChanges` that is emitted whenever a user chooses to apply suggested changes.

Author: sunwoo-ms

telemetry/definitions/commonDefinitions.json

@@ -248,11 +248,6 @@
             "type": "int",
             "description": "Time taken to invoke code scan service APIs in milliseconds"
         },
-        {
-            "name": "codeTransformApiErrorMessage",
-            "type": "string",
-            "description": "Any API-specific errors"
-        },
         {
             "name": "codeTransformApiNames",
             "type": "string",
@@ -371,6 +366,21 @@
             "type": "int",
             "description": "The number of projects selected for transformation"
         },
+        {
+            "name": "codeTransformNumberOfTransformedFiles",
+            "type": "int",
+            "description": "The number of files that were transformed during a transformation job"
+        },
+        {
+            "name": "codeTransformNumberOfTransformedFilesAccepted",
+            "type": "int",
+            "description": "The number of transformed files that have been accepted by the user"
+        },
+        {
+            "name": "codeTransformNumberOfTransformedUnitsAccepted",
+            "type": "int",
+            "description": "The number of transformed buildable units that have been accepted by the user"
+        },
         {
             "name": "codeTransformPatchViewerCancelSrcComponents",
             "type": "string",
@@ -1515,7 +1525,10 @@
         {
             "name": "saveType",
             "type": "string",
-            "allowedValues": ["MANUAL_SAVE", "AUTO_SAVE"],
+            "allowedValues": [
+                "MANUAL_SAVE",
+                "AUTO_SAVE"
+            ],
             "description": "Type of save executed"
         },
         {
@@ -3473,6 +3486,24 @@
             ],
             "passive": true
         },
+        {
+            "name": "codeTransform_applyChanges",
+            "description": "Apply suggested changes to buildable units.",
+            "metadata": [
+                {
+                    "type": "codeTransformNumberOfTransformedFilesAccepted",
+                    "required": true
+                },
+                {
+                    "type": "codeTransformNumberOfTransformedUnitsAccepted",
+                    "required": false
+                },
+                {
+                    "type": "codeTransformSessionId",
+                    "required": true
+                }
+            ]
+        },
         {
             "name": "codeTransform_dependenciesCopied",
             "description": "Deprecated - use codeTransform_uploadProject (The repo copies over at least one dependency successfully)",
@@ -3550,7 +3581,7 @@
         {
             "name": "codeTransform_initiateTransform",
             "description": "User initiates code transform from Q Chat Prompt.",
-            "metadata" : [
+            "metadata": [
                 {
                     "type": "codeTransformSessionId",
                     "required": true
@@ -3719,6 +3750,10 @@
                     "type": "codeTransformNumberOfProjects",
                     "required": false
                 },
+                {
+                    "type": "codeTransformNumberOfTransformedFiles",
+                    "required": false
+                },
                 {
                     "type": "codeTransformRunTimeLatency",
                     "required": false
@@ -3742,6 +3777,10 @@
                 {
                     "type": "result",
                     "required": false
+                },
+                {
+                    "type": "source",
+                    "required": false
                 }
             ]
         },
@@ -3794,7 +3833,7 @@
         {
             "name": "codeTransform_localBuildProject",
             "description": "Transform initiates local build.",
-            "metadata" : [
+            "metadata": [
                 {
                     "type": "codeTransformBuildCommand",
                     "required": true
@@ -3818,14 +3857,6 @@
             "passive": true,
             "description": "Deprecated - avoid logging every service call",
             "metadata": [
-                {
-                    "type": "codeTransformApiErrorMessage",
-                    "required": true
-                },
-                {
-                    "type": "codeTransformApiNames",
-                    "required": true
-                },
                 {
                     "type": "codeTransformJobId",
                     "required": false
@@ -3841,6 +3872,10 @@
                 {
                     "type": "codeTransformTotalByteSize",
                     "required": false
+                },
+                {
+                    "type": "reason",
+                    "required": true
                 }
             ]
         },
@@ -3882,19 +3917,19 @@
         {
             "name": "codeTransform_logGeneralError",
             "passive": true,
-            "description": "Deprecated - avoid logging every service call",
+            "description": "A general error has occurred.",
             "metadata": [
-                {
-                    "type": "codeTransformApiErrorMessage",
-                    "required": true
-                },
                 {
                     "type": "codeTransformJobId",
                     "required": false
                 },
                 {
                     "type": "codeTransformSessionId",
                     "required": true
+                },
+                {
+                    "type": "reason",
+                    "required": true
                 }
             ]
         },
@@ -3946,7 +3981,7 @@
         {
             "name": "codeTransform_submitSelection",
             "description": "User provides input to project module and language selection.",
-            "metadata" : [
+            "metadata": [
                 {
                     "type": "codeTransformJavaSourceVersionsAllowed",
                     "required": false
@@ -4016,11 +4051,10 @@
                 }
             ]
         },
-
         {
             "name": "codeTransform_uploadProject",
             "description": "Transform initiates project artifact upload.",
-            "metadata" : [
+            "metadata": [
                 {
                     "type": "codeTransformDependenciesCopied",
                     "required": true
@@ -4050,7 +4084,7 @@
         {
             "name": "codeTransform_validateProject",
             "description": "Transform initiates project language, build tool, and build file validation.",
-            "metadata" : [
+            "metadata": [
                 {
                     "type": "buildSystemVersion",
                     "required": false
@@ -6770,4 +6804,4 @@
             ]
         }
     ]
-}
+}