refactor: rename existing toolkit module metric names to new format (#985)

## Problem:

We have a new telemetry metric name format defined in our telemetry
readme. The current module metrics do not follow this spec.

## Solution:

- Rename the existing metrics to match #984 spec. Eg:
`toolkit_openModule` -> `toolkit_willOpenModule`
- Reorder the renamed metric alphabetically
- Note we are not doing this for everything, but for some select
metrics.

<!---
    REMINDER:
    - Read CONTRIBUTING.md first.
    - Add test coverage for your changes.
    - Link to related issues/commits.
    - Testing: how did you test your changes?
    - Screenshots if applicable
-->

## License

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Signed-off-by: nkomonen-amazon <[email protected]>

Author: nkomonen-amazon

telemetry/definitions/commonDefinitions.json

@@ -7124,8 +7124,8 @@
             ]
         },
         {
-            "name": "toolkit_closeModule",
-            "description": "The user closed 'something' (specified by 'module'). Examples: a view, feature, resource, ...",
+            "name": "toolkit_didCloseModule",
+            "description": "The module has closed/terminated. Use this when the module is done being used.",
             "metadata": [
                 {
                     "type": "module",
@@ -7134,6 +7134,33 @@
             ],
             "passive": true
         },
+        {
+            "name": "toolkit_didLoadModule",
+            "description": "The module has loaded, i.e it has rendered/resolved/finished. Use this after `toolkit_willOpenModule` to indicate success.",
+            "metadata": [
+                {
+                    "type": "attempts",
+                    "required": false
+                },
+                {
+                    "type": "duration",
+                    "required": false
+                },
+                {
+                    "type": "module",
+                    "required": true
+                },
+                {
+                    "type": "result",
+                    "required": true
+                },
+                {
+                    "type": "version",
+                    "required": false
+                }
+            ],
+            "passive": true
+        },
         {
             "name": "toolkit_featureState",
             "description": "Represents the current enabled state of a feature. Used to track user journey through a feature. Emitted after feature-specific operations of interest in the Toolkit.",
@@ -7199,33 +7226,6 @@
             ],
             "passive": true
         },
-        {
-            "name": "toolkit_initModule",
-            "description": "The Toolkit has completed initialization for the specified module.",
-            "metadata": [
-                {
-                    "type": "attempts",
-                    "required": false
-                },
-                {
-                    "type": "duration",
-                    "required": false
-                },
-                {
-                    "type": "module",
-                    "required": true
-                },
-                {
-                    "type": "result",
-                    "required": true
-                },
-                {
-                    "type": "version",
-                    "required": false
-                }
-            ],
-            "passive": true
-        },
         {
             "name": "toolkit_invokeAction",
             "description": "User invoked an action. `source` is the notification that produced the action",
@@ -7256,25 +7256,6 @@
                 }
             ]
         },
-        {
-            "name": "toolkit_openModule",
-            "description": "User opened 'something' (specified by 'module'). Examples: a view, feature, resource, ...",
-            "metadata": [
-                {
-                    "type": "module",
-                    "required": true
-                },
-                {
-                    "type": "result",
-                    "required": true
-                },
-                {
-                    "type": "source",
-                    "required": true
-                }
-            ],
-            "passive": true
-        },
         {
             "name": "toolkit_showAction",
             "description": "Toolkit presented an action. `source` is the notification that produced the action. See also `toolkit_showNotification`.",
@@ -7355,6 +7336,25 @@
             "name": "toolkit_viewLogs",
             "description": "View logs for the toolkit"
         },
+        {
+            "name": "toolkit_willOpenModule",
+            "description": "The opening of a module **started**. This does not imply it successfully finished, use `toolkit_didLoadModule` for that. The open/load separation exists because it may be difficult to capture then entire process in a single metric. A 'module' is a general term that represents things like: a view, feature, resource, ... ",
+            "metadata": [
+                {
+                    "type": "module",
+                    "required": true
+                },
+                {
+                    "type": "result",
+                    "required": true
+                },
+                {
+                    "type": "source",
+                    "required": true
+                }
+            ],
+            "passive": true
+        },
         {
             "name": "ui_click",
             "description": "User clicked/activated a UI element. This does not necessarily have to be an explicit mouse click. Any user action that has the same behavior as a mouse click can use this event.",