Skip to content

Commit bc1891c

Browse files
authored
telemetry: add "initialized" lsp stage #1001
## Problem LanguageServerSetupStage does not include initialized stage which is needed in VS and LSP protocol. VS had an issue where needed to diagnose and measure customer failures that occur after the lsp was successfully started but the IDE failed to make a successful "initialized" communication. For reference, LSP clients send an "[initialize](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize)" message back and forth, and then they send an "[initialized](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialized)" message back and forth. The related pr is [here](aws/aws-toolkit-visual-studio-staging#2339). ## Solution I add the initialized stage in common's definition. The initialize stage is defined as handshake in common's definition so we do not need to make any modification for initialize.
1 parent 6c8686f commit bc1891c

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

telemetry/definitions/commonDefinitions.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1708,6 +1708,7 @@
17081708
"validate",
17091709
"launch",
17101710
"handshake",
1711+
"initialized",
17111712
"all"
17121713
],
17131714
"description": "The stage of the LSP setup process"

0 commit comments

Comments
 (0)