Skip to content

Commit f514400

Browse files
laileni-awslaileni-aws
committed
Addressing comments
1 parent 6c71a1a commit f514400

File tree

1 file changed

+37
-57
lines changed

1 file changed

+37
-57
lines changed

‎telemetry/definitions/commonDefinitions.json‎

Lines changed: 37 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
{
22
"types": [
3+
{
4+
"name": "acceptedCount",
5+
"type": "int",
6+
"description": "The number of accepted cases"
7+
},
38
{
49
"name": "action",
510
"type": "string",
@@ -178,16 +183,6 @@
178183
"type": "int",
179184
"description": "The amount of time required for the build to complete (in seconds)."
180185
},
181-
{
182-
"name": "buildStatus",
183-
"type": "string",
184-
"allowedValues": [
185-
"SUCCESS",
186-
"FAILED",
187-
"CANCELLED"
188-
],
189-
"description": "The amount of time required for the build to complete (in seconds)."
190-
},
191186
{
192187
"name": "buildSystemVersion",
193188
"type": "string",
@@ -1227,6 +1222,11 @@
12271222
"type": "string",
12281223
"description": "The name of the EventBridge Schema used in the operation"
12291224
},
1225+
{
1226+
"name": "executedCount",
1227+
"type": "int",
1228+
"description": "The number of executed operations"
1229+
},
12301230
{
12311231
"name": "experimentId",
12321232
"type": "string",
@@ -1293,6 +1293,11 @@
12931293
"type": "string",
12941294
"description": "Application framework being used"
12951295
},
1296+
{
1297+
"name": "generatedCount",
1298+
"type": "int",
1299+
"description": "The number of generated cases"
1300+
},
12961301
{
12971302
"name": "generateFailure",
12981303
"type": "string",
@@ -1497,31 +1502,6 @@
14971502
"type": "int",
14981503
"description": "Number of generations before the user accepted or rejected"
14991504
},
1500-
{
1501-
"name": "numberOfBuildExecuted",
1502-
"type": "int",
1503-
"description": "Number of build executed in unit test generation build loop"
1504-
},
1505-
{
1506-
"name": "numberOfBuildFailed",
1507-
"type": "int",
1508-
"description": "Number of build failures in unit test generation build loop"
1509-
},
1510-
{
1511-
"name": "numberOfBuildPassed",
1512-
"type": "int",
1513-
"description": "Number of build succeeded in unit test generation build loop"
1514-
},
1515-
{
1516-
"name": "numberOfUnitTestCasesAccepted",
1517-
"type": "int",
1518-
"description": "Number of unit test cases accepted"
1519-
},
1520-
{
1521-
"name": "numberOfUnitTestCasesGenerated",
1522-
"type": "int",
1523-
"description": "Number of unit test cases generated"
1524-
},
15251505
{
15261506
"name": "oldVersion",
15271507
"type": "string",
@@ -2318,6 +2298,10 @@
23182298
"name": "amazonq_unitTestGeneration",
23192299
"description": "Client side metrics of AmazonQ Unit Test Generation",
23202300
"metadata": [
2301+
{
2302+
"type": "acceptedCount",
2303+
"required": false
2304+
},
23212305
{
23222306
"type": "charsOfCodeAccepted",
23232307
"required": false
@@ -2334,31 +2318,27 @@
23342318
"type": "cwsprChatProgrammingLanguage"
23352319
},
23362320
{
2337-
"type": "linesOfCodeAccepted",
2338-
"required": false
2339-
},
2340-
{
2341-
"type": "linesOfCodeGenerated",
2321+
"type": "executedCount",
23422322
"required": false
23432323
},
23442324
{
2345-
"type": "numberOfBuildExecuted",
2325+
"type": "failedCount",
23462326
"required": false
23472327
},
23482328
{
2349-
"type": "numberOfBuildFailed",
2329+
"type": "generatedCount",
23502330
"required": false
23512331
},
23522332
{
2353-
"type": "numberOfBuildPassed",
2333+
"type": "linesOfCodeAccepted",
23542334
"required": false
23552335
},
23562336
{
2357-
"type": "numberOfUnitTestCasesAccepted",
2337+
"type": "linesOfCodeGenerated",
23582338
"required": false
23592339
},
23602340
{
2361-
"type": "numberOfUnitTestCasesGenerated",
2341+
"type": "successCount",
23622342
"required": false
23632343
},
23642344
{
@@ -2377,10 +2357,6 @@
23772357
"name": "amazonq_utg_buildLoop",
23782358
"description": "Client side invocation of the AmazonQ Unit Test Generation build loop",
23792359
"metadata": [
2380-
{
2381-
"type": "buildStatus",
2382-
"required": false
2383-
},
23842360
{
23852361
"type": "credentialStartUrl",
23862362
"required": false
@@ -2392,6 +2368,10 @@
23922368
"type": "latencyOfClientSideBuild",
23932369
"required": false
23942370
},
2371+
{
2372+
"type": "result",
2373+
"required": false
2374+
},
23952375
{
23962376
"type": "source",
23972377
"required": false
@@ -2416,6 +2396,10 @@
24162396
"name": "amazonq_utg_generateTests",
24172397
"description": "Client side invocation of the AmazonQ Unit Test Generation",
24182398
"metadata": [
2399+
{
2400+
"type": "acceptedCount",
2401+
"required": false
2402+
},
24192403
{
24202404
"type": "artifactsUploadDuration",
24212405
"required": false
@@ -2436,23 +2420,19 @@
24362420
"type": "cwsprChatProgrammingLanguage"
24372421
},
24382422
{
2439-
"type": "latencyOfGeneratingTests",
2423+
"type": "generatedCount",
24402424
"required": false
24412425
},
24422426
{
2443-
"type": "linesOfCodeAccepted",
2444-
"required": false
2445-
},
2446-
{
2447-
"type": "linesOfCodeGenerated",
2427+
"type": "latencyOfGeneratingTests",
24482428
"required": false
24492429
},
24502430
{
2451-
"type": "numberOfUnitTestCasesAccepted",
2431+
"type": "linesOfCodeAccepted",
24522432
"required": false
24532433
},
24542434
{
2455-
"type": "numberOfUnitTestCasesGenerated",
2435+
"type": "linesOfCodeGenerated",
24562436
"required": false
24572437
},
24582438
{

0 commit comments

Comments
 (0)