Skip to content

Commit fde38dc

Browse files
authored
Add authType to loginWithBrowser metrics (#877)
## Problem Users can signin with the device code or PKCE flow ## Solution This metric adds the type of auth flow/token flow to the aws_loginWithBroswer metric <!--- REMINDER: - Read CONTRIBUTING.md first. - Add test coverage for your changes. - Link to related issues/commits. - Testing: how did you test your changes? - Screenshots if applicable --> ## License By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent bfb520f commit fde38dc

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

telemetry/definitions/commonDefinitions.json

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,17 @@
132132
],
133133
"description": "Status of the an auth connection."
134134
},
135+
{
136+
"name": "authType",
137+
"type": "string",
138+
"allowedValues": [
139+
"PKCE",
140+
"DeviceCode",
141+
"IAM",
142+
"Unknown"
143+
],
144+
"description": "The type of auth flow used for signing in"
145+
},
135146
{
136147
"name": "awsAccount",
137148
"type": "string",
@@ -2813,6 +2824,10 @@
28132824
"name": "aws_loginWithBrowser",
28142825
"description": "Extension navigated the user to a web browser to perform/complete the login process.",
28152826
"metadata": [
2827+
{
2828+
"type": "authType",
2829+
"required": false
2830+
},
28162831
{
28172832
"type": "credentialSourceId",
28182833
"required": false

0 commit comments

Comments
 (0)