Migrate C# telemetry generator to .NET AWSDK v4 #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awschristou
reviewed
Sep 12, 2025
TestServiceModels/.gitkeep
Outdated
Contributor
Author
There was a problem hiding this comment.
added it to the description. Its required by the updated sdk generator to be present in the directory structure
Contributor
Author
There was a problem hiding this comment.
Removed it and made it part of the script
Contributor
There was a problem hiding this comment.
Just calling out that this file naturally has a large diff because it isn't updated each time the telemetry definition json file is updated. This file isn't changed as a result of Shruti's change, nor am I concerned about it.
Contributor
Author
There was a problem hiding this comment.
Yes, the generator is auto generated
awschristou
approved these changes
Sep 12, 2025
ctlai95
approved these changes
Sep 16, 2025
shruti0085
added a commit
that referenced
this pull request
Sep 24, 2025
PR #1082 migrated the C# telemetry generator to AWS SDK V4. Due to changes in contracts with this version, a Custom PartialConfig file was added to meet the interface requirements for configuring endpoints with the ClientConfig. This caused issues during runtime since our client does not rely on endpoitns. As a workaround as per .NET SDK team's guidance, since our client always sets the ServiceUrl on out client, a fix along those lines has been made to short-circuit the underlying logic and return endpoint based on the service url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change migrates the C# telemetry generator to use .NET AWS SDK V4. The version of Core and subsequent SDK release tag matches the one used by the VS IDE extension at this time.
Callouts:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.