From f139ff68077520ff71184e9d19d974128297df4a Mon Sep 17 00:00:00 2001
From: Joshua Pinkney <jpink@amazon.com>
Date: Fri, 30 Aug 2024 06:52:37 -0400
Subject: [PATCH 1/2] Add definitions for a webview being loaded/erroring

---
 telemetry/definitions/commonDefinitions.json | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json
index b2ecc4247..c9ce2c500 100644
--- a/telemetry/definitions/commonDefinitions.json
+++ b/telemetry/definitions/commonDefinitions.json
@@ -7138,6 +7138,26 @@
                     "type": "result"
                 }
             ]
+        },
+        {
+            "name": "webview_error",
+            "description": "Called when an error occurs inside of a webview",
+            "metadata": [
+                {
+                    "type": "name",
+                    "required": true
+                }
+            ]
+        },
+        {
+            "name": "webview_load",
+            "description": "Called when a webview is opened",
+            "metadata": [
+                {
+                    "type": "name",
+                    "required": true
+                }
+            ]
         }
     ]
 }
\ No newline at end of file

From 9eaafccc164039eb1382e2c04db76947f6757ec4 Mon Sep 17 00:00:00 2001
From: Joshua Pinkney <jpink@amazon.com>
Date: Wed, 4 Sep 2024 07:41:18 -0400
Subject: [PATCH 2/2] fixup

---
 telemetry/definitions/commonDefinitions.json | 40 ++++++++++----------
 1 file changed, 19 insertions(+), 21 deletions(-)

diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json
index c9ce2c500..a3d216b93 100644
--- a/telemetry/definitions/commonDefinitions.json
+++ b/telemetry/definitions/commonDefinitions.json
@@ -6894,6 +6894,24 @@
             ],
             "passive": true
         },
+        {
+            "name": "toolkit_errorModule",
+            "description": "Called when an unexpected error occurs within a module outside of regular metrics tracking",
+            "metadata": [
+                {
+                    "type": "module",
+                    "required": true
+                },
+                {
+                    "type": "result",
+                    "required": true
+                },
+                {
+                    "type": "source",
+                    "required": true
+                }
+            ]
+        },
         {
             "name": "toolkit_featureState",
             "description": "Represents the current enabled state of a feature. Used to track user journey through a feature. Emitted after feature-specific operations of interest in the Toolkit.",
@@ -7138,26 +7156,6 @@
                     "type": "result"
                 }
             ]
-        },
-        {
-            "name": "webview_error",
-            "description": "Called when an error occurs inside of a webview",
-            "metadata": [
-                {
-                    "type": "name",
-                    "required": true
-                }
-            ]
-        },
-        {
-            "name": "webview_load",
-            "description": "Called when a webview is opened",
-            "metadata": [
-                {
-                    "type": "name",
-                    "required": true
-                }
-            ]
         }
     ]
-}
\ No newline at end of file
+}