From dadda6dfab7a97203d9291353d24981d8a4774d5 Mon Sep 17 00:00:00 2001 From: Josh Pinkney Date: Wed, 13 Nov 2024 11:35:26 -0500 Subject: [PATCH 1/3] feat: add general latency metrics Problem: - Soooooooooo many teams have specific latency metric fields and many are asking to add them for re-invent Solution: - De-dup a lot of them e.g. amazonqGenerateApproachLatency, amazonqGenerateCodeResponseLatency, amazonqEndOfTheConversationLatency, etc --- telemetry/definitions/commonDefinitions.json | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index 54fd9be40..d48418bef 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -997,6 +997,21 @@ "type": "string", "description": "Identifies the entity within the message that user interacts with." }, + { + "name": "clientLatency", + "type": "double", + "description": "The time duration in milliseconds to process an action on the client side" + }, + { + "name": "serverLatency", + "type": "double", + "description": "The time duration in milliseconds to finish a request to the server side" + }, + { + "name": "e2eLatency", + "type": "double", + "description": "The time duration in milliseconds to complete an end to end flow" + }, { "name": "cwsprChatInteractionType", "allowedValues": [ From 2c2905860406f385f00599ced0ddadc1f1e2a832 Mon Sep 17 00:00:00 2001 From: Josh Pinkney Date: Wed, 13 Nov 2024 11:40:36 -0500 Subject: [PATCH 2/3] fixup --- telemetry/definitions/commonDefinitions.json | 34 ++++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index d48418bef..4e8003264 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -209,6 +209,11 @@ ], "description": "User inputted check type to denote which custom check to run." }, + { + "name": "clientLatency", + "type": "double", + "description": "The time duration in milliseconds to process an action on the client side" + }, { "name": "cloudWatchLogsPresentation", "type": "string", @@ -997,21 +1002,6 @@ "type": "string", "description": "Identifies the entity within the message that user interacts with." }, - { - "name": "clientLatency", - "type": "double", - "description": "The time duration in milliseconds to process an action on the client side" - }, - { - "name": "serverLatency", - "type": "double", - "description": "The time duration in milliseconds to finish a request to the server side" - }, - { - "name": "e2eLatency", - "type": "double", - "description": "The time duration in milliseconds to complete an end to end flow" - }, { "name": "cwsprChatInteractionType", "allowedValues": [ @@ -1153,6 +1143,11 @@ ], "description": "The type of DynamoDB entity referenced by a metric or operation" }, + { + "name": "e2eLatency", + "type": "double", + "description": "The time duration in milliseconds to complete an end to end flow" + }, { "name": "ec2ConnectionType", "type": "string", @@ -1160,7 +1155,7 @@ "remoteDesktop", "ssh", "scp", - "ssm", + "ssm", "remoteWorkspace" ], "description": "Ways to connect to an EC2 Instance" @@ -1642,6 +1637,11 @@ ], "description": "Languages targeted by the schemas service" }, + { + "name": "serverLatency", + "type": "double", + "description": "The time duration in milliseconds to finish a request to the server side" + }, { "name": "serviceType", "type": "string", @@ -7080,4 +7080,4 @@ ] } ] -} +} \ No newline at end of file From 760dd9dba8fd0527de1ca2cf5e1fda58e2d53680 Mon Sep 17 00:00:00 2001 From: Josh Pinkney Date: Thu, 14 Nov 2024 12:19:20 -0500 Subject: [PATCH 3/3] change to perf prefix --- telemetry/definitions/commonDefinitions.json | 30 ++++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index 4e8003264..638d11c1e 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -209,11 +209,6 @@ ], "description": "User inputted check type to denote which custom check to run." }, - { - "name": "clientLatency", - "type": "double", - "description": "The time duration in milliseconds to process an action on the client side" - }, { "name": "cloudWatchLogsPresentation", "type": "string", @@ -1143,11 +1138,6 @@ ], "description": "The type of DynamoDB entity referenced by a metric or operation" }, - { - "name": "e2eLatency", - "type": "double", - "description": "The time duration in milliseconds to complete an end to end flow" - }, { "name": "ec2ConnectionType", "type": "string", @@ -1498,6 +1488,21 @@ "type": "int", "description": "Number of generation paths modified" }, + { + "name": "perfClientLatency", + "type": "double", + "description": "The time duration in milliseconds to process an action on the client side" + }, + { + "name": "perfE2ELatency", + "type": "double", + "description": "The time duration in milliseconds to complete an end to end flow" + }, + { + "name": "perfServerLatency", + "type": "double", + "description": "The time duration in milliseconds to finish a request to the server side" + }, { "name": "platform", "type": "string", @@ -1637,11 +1642,6 @@ ], "description": "Languages targeted by the schemas service" }, - { - "name": "serverLatency", - "type": "double", - "description": "The time duration in milliseconds to finish a request to the server side" - }, { "name": "serviceType", "type": "string",