fix(CodeTransform): block upload if zip size > 1GB (#4143)

* feat(CodeTransform): block upload if zip size > 1GB

* add changelog entry

* make sure payloadSize is emitted in telemetry

* re-order notification messages

* alphabetize messages

---------

Co-authored-by: David Hasani <[email protected]>

Author: dhasani23

.changes/next-release/feature-b52a1e50-c015-4dac-a1fb-aa14ea900972.json

@@ -0,0 +1,4 @@
+{
+  "type" : "feature",
+  "description" : "CodeTransformation: block upload if project > 1GB"
+}

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeModernizerManager.kt

@@ -405,6 +405,10 @@ class CodeModernizerManager(private val project: Project) : PersistentStateCompo
             is CodeModernizerStartJobResult.CancelledMissingDependencies -> {
                 CodeModernizerJobCompletedResult.JobAbortedMissingDependencies
             }
+
+            is CodeModernizerStartJobResult.CancelledZipTooLarge -> {
+                CodeModernizerJobCompletedResult.JobAbortedZipTooLarge
+            }
         }
     }
 
@@ -591,6 +595,12 @@ class CodeModernizerManager(private val project: Project) : PersistentStateCompo
                 project,
                 listOf(openTroubleshootingGuideNotificationAction()),
             )
+            is CodeModernizerJobCompletedResult.JobAbortedZipTooLarge -> notifyStickyInfo(
+                message("codemodernizer.notification.warn.zip_too_large.title"),
+                message("codemodernizer.notification.warn.zip_too_large.content"),
+                project,
+                listOf(openTroubleshootingGuideNotificationAction()),
+            )
         }
     }
 

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeModernizerSession.kt

@@ -46,6 +46,7 @@ import java.util.concurrent.atomic.AtomicBoolean
 const val ZIP_SOURCES_PATH = "sources"
 const val BUILD_LOG_PATH = "build-logs.txt"
 const val UPLOAD_ZIP_MANIFEST_VERSION = 1.0F
+const val MAX_ZIP_SIZE = 1000000000 // 1GB
 
 class CodeModernizerSession(
     val sessionContext: CodeModernizerSessionContext,
@@ -84,11 +85,18 @@ class CodeModernizerSession(
             }
 
             payload = result.payload
+
+            val payloadSize = payload.length().toInt()
+
             CodetransformTelemetry.jobCreateZipEndTime(
-                codeTransformTotalByteSize = payload.length().toInt(),
+                codeTransformTotalByteSize = payloadSize,
                 codeTransformSessionId = CodeTransformTelemetryState.instance.getSessionId(),
                 codeTransformRunTimeLatency = calculateTotalLatency(startTime, Instant.now())
             )
+
+            if (payloadSize > MAX_ZIP_SIZE) {
+                return CodeModernizerStartJobResult.CancelledZipTooLarge
+            }
         } catch (e: Exception) {
             val errorMessage = "Failed to create zip"
             LOG.error(e) { errorMessage }

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/model/CodeModernizerJobCompletedResult.kt

@@ -16,4 +16,5 @@ sealed class CodeModernizerJobCompletedResult {
     object ManagerDisposed : CodeModernizerJobCompletedResult()
     object JobAbortedBeforeStarting : CodeModernizerJobCompletedResult()
     object JobAbortedMissingDependencies : CodeModernizerJobCompletedResult()
+    object JobAbortedZipTooLarge : CodeModernizerJobCompletedResult()
 }

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/model/CodeModernizerStartJobResult.kt

@@ -9,5 +9,6 @@ sealed class CodeModernizerStartJobResult {
     data class UnableToStartJob(val exception: String) : CodeModernizerStartJobResult()
     object Cancelled : CodeModernizerStartJobResult()
     object CancelledMissingDependencies : CodeModernizerStartJobResult()
+    object CancelledZipTooLarge : CodeModernizerStartJobResult()
     object Disposed : CodeModernizerStartJobResult()
 }

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/panels/managers/CodeModernizerBottomWindowPanelManager.kt

@@ -180,6 +180,7 @@ class CodeModernizerBottomWindowPanelManager(private val project: Project) : JPa
         buildProgressSplitterPanelManager.apply {
             when (result) {
                 is CodeModernizerJobCompletedResult.UnableToCreateJob,
+                is CodeModernizerJobCompletedResult.JobAbortedZipTooLarge,
                 is CodeModernizerJobCompletedResult.JobAbortedMissingDependencies -> setJobFailedToStartUI()
 
                 is CodeModernizerJobCompletedResult.RetryableFailure,

resources/resources/software/aws/toolkits/resources/MessagesBundle.properties

@@ -544,7 +544,7 @@ codemodernizer.notification.warn.invalid_project.description.reason.not_logged_i
 codemodernizer.notification.warn.invalid_project.description.reason.remote_backend=We do not support transforming projects running on a remote backend.
 codemodernizer.notification.warn.invalid_project.description.reason.unknown=We could not find an upgrade eligible application. We currently support upgrade of Java applications of version 8 and 11.
 codemodernizer.notification.warn.maven_failed.content=We were unable to build and package your project and its dependencies. Please fix the issues shown in the opened build window and try again.
-codemodernizer.notification.warn.maven_failed.title=Q Code Transform unable to zip dependencies 
+codemodernizer.notification.warn.maven_failed.title=Amazon Q Code Transform unable to zip dependencies
 codemodernizer.notification.warn.on_resume.unknown_status_response.content=We received data from Amazon Q in a format that the plugin cannot handle. You may need to update the plugin and then try again.
 codemodernizer.notification.warn.on_resume.unknown_status_response.title=Unable to resume job.
 codemodernizer.notification.warn.unable_to_generate_plan=The job failed before a code transform plan could be generated.
@@ -560,7 +560,9 @@ codemodernizer.notification.warn.zip_creation_failed=we were unable to zip the s
 codemodernizer.notification.warn.zip_creation_failed.reasons.mvn.content=We were unable to zip dependencies for the selected module as we ran into an issue, we will attempt to transform your code without your local dependencies: {0}
 codemodernizer.notification.warn.zip_creation_failed.reasons.mvn.content_not_installed=We are unable to transform your code as we were unable to zip up your dependencies using `mvn` or `mvnw` commands.
 codemodernizer.notification.warn.zip_creation_failed.reasons.mvn.title=Unable to zip module dependencies
-codemodernizer.notification.warn.zip_creation_failed.reasons.unknown=an unexpected error occurred
+codemodernizer.notification.warn.zip_creation_failed.reasons.unknown=An unexpected error occurred
+codemodernizer.notification.warn.zip_too_large.content=Your project size exceeds the Amazon Q Code Transformation upload limit of 1GB.
+codemodernizer.notification.warn.zip_too_large.title=Project size exceeds 1GB limit
 codemodernizer.patch.name=Patch with code changes required to upgrade to Java 17
 codemodernizer.toolwindow.banner.action.diff=View diff
 codemodernizer.toolwindow.banner.action.feedback=Provide Feedback