feat(amazonq): fallback to bundled flare assets if cannot be downloaded

Author: rli

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ArtifactManager.kt

@@ -16,6 +16,9 @@ import org.jetbrains.annotations.VisibleForTesting
 import software.aws.toolkits.core.utils.error
 import software.aws.toolkits.core.utils.getLogger
 import software.aws.toolkits.core.utils.info
+import software.aws.toolkits.core.utils.warn
+import software.aws.toolkits.jetbrains.AwsPlugin
+import software.aws.toolkits.jetbrains.AwsToolkit
 import java.nio.file.Path
 
 @Service
@@ -54,36 +57,43 @@ class ArtifactManager @NonInjectable internal constructor(private val manifestFe
         return mutex.withLock {
             coroutineScope {
                 async {
-                    val manifest = manifestFetcher.fetch() ?: throw LspException(
-                        "Language Support is not available, as manifest is missing.",
-                        LspException.ErrorCode.MANIFEST_FETCH_FAILED
-                    )
-                    val lspVersions = getLSPVersionsFromManifestWithSpecifiedRange(manifest)
-
-                    artifactHelper.removeDelistedVersions(lspVersions.deListedVersions)
-
-                    if (lspVersions.inRangeVersions.isEmpty()) {
-                        // No versions are found which are in the given range. Fallback to local lsp artifacts.
-                        val localLspArtifacts = artifactHelper.getAllLocalLspArtifactsWithinManifestRange(DEFAULT_VERSION_RANGE)
-                        if (localLspArtifacts.isNotEmpty()) {
-                            return@async localLspArtifacts.first().first
+                    try {
+                        val manifest = manifestFetcher.fetch() ?: throw LspException(
+                            "Language Support is not available, as manifest is missing.",
+                            LspException.ErrorCode.MANIFEST_FETCH_FAILED
+                        )
+                        val lspVersions = getLSPVersionsFromManifestWithSpecifiedRange(manifest)
+
+                        artifactHelper.removeDelistedVersions(lspVersions.deListedVersions)
+
+                        if (lspVersions.inRangeVersions.isEmpty()) {
+                            // No versions are found which are in the given range. Fallback to local lsp artifacts.
+                            val localLspArtifacts = artifactHelper.getAllLocalLspArtifactsWithinManifestRange(DEFAULT_VERSION_RANGE)
+                            if (localLspArtifacts.isNotEmpty()) {
+                                return@async localLspArtifacts.first().first
+                            }
+                            throw LspException("Language server versions not found in manifest.", LspException.ErrorCode.NO_COMPATIBLE_LSP_VERSION)
                         }
-                        throw LspException("Language server versions not found in manifest.", LspException.ErrorCode.NO_COMPATIBLE_LSP_VERSION)
-                    }
 
-                    val targetVersion = lspVersions.inRangeVersions.first()
+                        val targetVersion = lspVersions.inRangeVersions.first()
 
-                    // If there is an LSP Manifest with the same version
-                    val target = getTargetFromLspManifest(targetVersion)
-                    // Get Local LSP files and check if we can re-use existing LSP Artifacts
-                    val artifactPath: Path = if (artifactHelper.getExistingLspArtifacts(targetVersion, target)) {
-                        artifactHelper.getAllLocalLspArtifactsWithinManifestRange(DEFAULT_VERSION_RANGE).first().first
-                    } else {
-                        artifactHelper.tryDownloadLspArtifacts(project, targetVersion, target)
-                            ?: throw LspException("Failed to download LSP artifacts", LspException.ErrorCode.DOWNLOAD_FAILED)
+                        // If there is an LSP Manifest with the same version
+                        val target = getTargetFromLspManifest(targetVersion)
+                        // Get Local LSP files and check if we can re-use existing LSP Artifacts
+                        val artifactPath: Path = if (artifactHelper.getExistingLspArtifacts(targetVersion, target)) {
+                            artifactHelper.getAllLocalLspArtifactsWithinManifestRange(DEFAULT_VERSION_RANGE).first().first
+                        } else {
+                            artifactHelper.tryDownloadLspArtifacts(project, targetVersion, target)
+                                ?: throw LspException("Failed to download LSP artifacts", LspException.ErrorCode.DOWNLOAD_FAILED)
+                        }
+                        artifactHelper.deleteOlderLspArtifacts(DEFAULT_VERSION_RANGE)
+                        return@async artifactPath
+                    } catch(e: Exception) {
+                        logger.warn(e) { "Failed to resolve assets from Flare CDN" }
+                        val path = AwsToolkit.PLUGINS_INFO[AwsPlugin.Q]?.path?.resolve("flare") ?: error("not even bundled")
+                        logger.info { "Falling back to bundled assets at $path" }
+                        return@async path
                     }
-                    artifactHelper.deleteOlderLspArtifacts(DEFAULT_VERSION_RANGE)
-                    return@async artifactPath
                 }
             }.also {
                 artifactDeferred = it