Skip to content

Commit 1170e9f

Browse files
committed
telemetry change
1 parent 208bc85 commit 1170e9f

File tree

4 files changed

+10
-20
lines changed

4 files changed

+10
-20
lines changed

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,13 +155,12 @@ class TelemetryHelper(private val project: Project, private val sessionStorage:
155155
numSuggestionAddLines: Int?,
156156
numSuggestionDelChars: Int?,
157157
numSuggestionDelLines: Int?,
158-
charactersAdded: Int?,
159-
charactersRemoved: Int?,
158+
programmingLanguage: String?,
160159
) {
161160
CodeWhispererClientAdaptor.getInstance(project).sendInlineChatTelemetry(
162161
requestId, inputLength, numSelectedLines, codeIntent, userDecision,
163162
responseStartLatency, responseEndLatency, numSuggestionAddChars, numSuggestionAddLines, numSuggestionDelChars, numSuggestionDelLines,
164-
charactersAdded, charactersRemoved
163+
programmingLanguage
165164
)
166165
}
167166

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/cwc/inline/InlineChatController.kt

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ class InlineChatController(
113113
var numSuggestionAddLines: Int? = null,
114114
var numSuggestionDelChars: Int? = null,
115115
var numSuggestionDelLines: Int? = null,
116-
var charactersAdded: Int? = null,
117-
var charactersRemoved: Int? = null,
116+
var programmingLanguage: String? = null,
118117
)
119118

120119
private val popupSubmitHandler: suspend (String, String, Int, Editor) -> String = {
@@ -141,10 +140,6 @@ class InlineChatController(
141140
private fun recordInlineChatTelemetry(decision: InlineChatUserDecision) {
142141
if (metrics == null) return
143142
metrics?.userDecision = decision
144-
if (decision == InlineChatUserDecision.ACCEPT) {
145-
metrics?.charactersAdded = metrics?.numSuggestionAddChars
146-
metrics?.charactersRemoved = metrics?.numSuggestionDelChars
147-
}
148143
if (metrics?.requestId?.isNotEmpty() == true) {
149144
telemetryHelper.recordInlineChatTelemetry(
150145
metrics?.requestId!!,
@@ -158,8 +153,7 @@ class InlineChatController(
158153
metrics?.numSuggestionAddLines,
159154
metrics?.numSuggestionDelChars,
160155
metrics?.numSuggestionDelLines,
161-
metrics?.charactersAdded,
162-
metrics?.charactersRemoved
156+
metrics?.programmingLanguage
163157
)
164158
}
165159
metrics = null
@@ -698,7 +692,8 @@ class InlineChatController(
698692
requestId?.let {
699693
metrics = InlineChatMetrics(
700694
requestId = it, inputLength = message.length, numSelectedLines = selectedCode.split("\n").size,
701-
codeIntent = true, responseStartLatency = firstResponseLatency, responseEndLatency = lastResponseLatency
695+
codeIntent = true, responseStartLatency = firstResponseLatency, responseEndLatency = lastResponseLatency,
696+
programmingLanguage = fileContext.fileContext?.fileLanguage
702697
)
703698
}
704699
if (finalMessage != null) {

plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/credentials/CodeWhispererClientAdaptor.kt

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,7 @@ interface CodeWhispererClientAdaptor : Disposable {
200200
numSuggestionAddLines: Int?,
201201
numSuggestionDelChars: Int?,
202202
numSuggestionDelLines: Int?,
203-
charactersAdded: Int?,
204-
charactersRemoved: Int?,
203+
programmingLanguage: String?,
205204
): SendTelemetryEventResponse
206205

207206
companion object {
@@ -617,8 +616,7 @@ open class CodeWhispererClientAdaptorImpl(override val project: Project) : CodeW
617616
numSuggestionAddLines: Int?,
618617
numSuggestionDelChars: Int?,
619618
numSuggestionDelLines: Int?,
620-
charactersAdded: Int?,
621-
charactersRemoved: Int?,
619+
programmingLanguage: String?,
622620
): SendTelemetryEventResponse = bearerClient().sendTelemetryEvent { requestBuilder ->
623621
requestBuilder.telemetryEvent { telemetryEventBuilder ->
624622
telemetryEventBuilder.inlineChatEvent {
@@ -633,8 +631,7 @@ open class CodeWhispererClientAdaptorImpl(override val project: Project) : CodeW
633631
it.numSuggestionAddLines(numSuggestionAddLines)
634632
it.numSuggestionDelChars(numSuggestionDelChars)
635633
it.numSuggestionDelLines(numSuggestionDelLines)
636-
it.charactersRemoved(charactersRemoved)
637-
it.charactersAdded(charactersAdded)
634+
if (programmingLanguage != null) it.programmingLanguage { langBuilder -> langBuilder.languageName(programmingLanguage) }
638635
it.timestamp(Instant.now())
639636
}
640637
}

plugins/core/sdk-codegen/codegen-resources/codewhispererruntime/service-2.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1113,8 +1113,7 @@
11131113
"userDecision": { "shape": "InlineChatUserDecision" },
11141114
"responseStartLatency": { "shape": "Double" },
11151115
"responseEndLatency": { "shape": "Double" },
1116-
"charactersRemoved": { "shape": "PrimitiveInteger" },
1117-
"charactersAdded": { "shape": "PrimitiveInteger"}
1116+
"programmingLanguage": { "shape": "ProgrammingLanguage" }
11181117
}
11191118
},
11201119
"InlineChatUserDecision": {

0 commit comments

Comments
 (0)