Fix for detektTest errors.

ashishrp-aws · ashishrp-aws · commit 1a6ca9125603 · 2025-02-03T16:04:33.000-08:00
diff --git a/plugins/amazonq/chat/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/amazonq/clients/AmazonQStreamingClientTest.kt b/plugins/amazonq/chat/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/amazonq/clients/AmazonQStreamingClientTest.kt
@@ -95,8 +95,8 @@ class AmazonQStreamingClientTest : AmazonQTestBase() {
             } doAnswer {
                 attemptCount++
                 if (attemptCount <= 2) {
-                    CompletableFuture<Void>().apply {
-                        completeExceptionally(VALIDATION_EXCEPTION)
+                    CompletableFuture.runAsync {
+                        throw VALIDATION_EXCEPTION
                     }
                 } else {
                     CompletableFuture.completedFuture(mock())
@@ -117,8 +117,8 @@ class AmazonQStreamingClientTest : AmazonQTestBase() {
                 exportResultArchive(any<ExportResultArchiveRequest>(), any<ExportResultArchiveResponseHandler>())
             } doAnswer {
                 attemptCount++
-                CompletableFuture<Void>().apply {
-                    completeExceptionally(VALIDATION_EXCEPTION)
+                CompletableFuture.runAsync {
+                    throw VALIDATION_EXCEPTION
                 }
             }
         }
@@ -142,8 +142,8 @@ class AmazonQStreamingClientTest : AmazonQTestBase() {
                 exportResultArchive(any<ExportResultArchiveRequest>(), any<ExportResultArchiveResponseHandler>())
             } doAnswer {
                 attemptCount++
-                CompletableFuture<Void>().apply {
-                    completeExceptionally(IllegalArgumentException("Non-retryable error"))
+                CompletableFuture.runAsync {
+                    throw IllegalArgumentException("Non-retryable error")
                 }
             }
         }
@@ -176,8 +176,8 @@ class AmazonQStreamingClientTest : AmazonQTestBase() {
                 }
                 lastAttemptTime = currentTime
 
-                CompletableFuture<Void>().apply {
-                    completeExceptionally(VALIDATION_EXCEPTION)
+                CompletableFuture.runAsync {
+                    throw VALIDATION_EXCEPTION
                 }
             }
         }
@@ -201,8 +201,8 @@ class AmazonQStreamingClientTest : AmazonQTestBase() {
             on {
                 exportResultArchive(any<ExportResultArchiveRequest>(), any<ExportResultArchiveResponseHandler>())
             } doAnswer {
-                CompletableFuture<Void>().apply {
-                    completeExceptionally(VALIDATION_EXCEPTION)
+                CompletableFuture.runAsync {
+                    throw VALIDATION_EXCEPTION
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -95,8 +95,8 @@ class AmazonQStreamingClientTest : AmazonQTestBase() {`
`95`	`95`	`} doAnswer {`
`96`	`96`	`attemptCount++`
`97`	`97`	`if (attemptCount <= 2) {`
`98`		`- CompletableFuture<Void>().apply {`
`99`		`- completeExceptionally(VALIDATION_EXCEPTION)`
	`98`	`+ CompletableFuture.runAsync {`
	`99`	`+ throw VALIDATION_EXCEPTION`
`100`	`100`	`}`
`101`	`101`	`} else {`
`102`	`102`	`CompletableFuture.completedFuture(mock())`
`@@ -117,8 +117,8 @@ class AmazonQStreamingClientTest : AmazonQTestBase() {`
`117`	`117`	`exportResultArchive(any<ExportResultArchiveRequest>(), any<ExportResultArchiveResponseHandler>())`
`118`	`118`	`} doAnswer {`
`119`	`119`	`attemptCount++`
`120`		`- CompletableFuture<Void>().apply {`
`121`		`- completeExceptionally(VALIDATION_EXCEPTION)`
	`120`	`+ CompletableFuture.runAsync {`
	`121`	`+ throw VALIDATION_EXCEPTION`
`122`	`122`	`}`
`123`	`123`	`}`
`124`	`124`	`}`
`@@ -142,8 +142,8 @@ class AmazonQStreamingClientTest : AmazonQTestBase() {`
`142`	`142`	`exportResultArchive(any<ExportResultArchiveRequest>(), any<ExportResultArchiveResponseHandler>())`
`143`	`143`	`} doAnswer {`
`144`	`144`	`attemptCount++`
`145`		`- CompletableFuture<Void>().apply {`
`146`		`- completeExceptionally(IllegalArgumentException("Non-retryable error"))`
	`145`	`+ CompletableFuture.runAsync {`
	`146`	`+ throw IllegalArgumentException("Non-retryable error")`
`147`	`147`	`}`
`148`	`148`	`}`
`149`	`149`	`}`
`@@ -176,8 +176,8 @@ class AmazonQStreamingClientTest : AmazonQTestBase() {`
`176`	`176`	`}`
`177`	`177`	`lastAttemptTime = currentTime`
`178`	`178`
`179`		`- CompletableFuture<Void>().apply {`
`180`		`- completeExceptionally(VALIDATION_EXCEPTION)`
	`179`	`+ CompletableFuture.runAsync {`
	`180`	`+ throw VALIDATION_EXCEPTION`
`181`	`181`	`}`
`182`	`182`	`}`
`183`	`183`	`}`
`@@ -201,8 +201,8 @@ class AmazonQStreamingClientTest : AmazonQTestBase() {`
`201`	`201`	`on {`
`202`	`202`	`exportResultArchive(any<ExportResultArchiveRequest>(), any<ExportResultArchiveResponseHandler>())`
`203`	`203`	`} doAnswer {`
`204`		`- CompletableFuture<Void>().apply {`
`205`		`- completeExceptionally(VALIDATION_EXCEPTION)`
	`204`	`+ CompletableFuture.runAsync {`
	`205`	`+ throw VALIDATION_EXCEPTION`
`206`	`206`	`}`
`207`	`207`	`}`
`208`	`208`	`}`