Skip to content

Commit 225938d

Browse files
manodnyabrli
andauthored
Revert open and close sign in webview telemetry (#4850)
* Revert open and close sign in webview telemetry * add changelog * added issue in changelog * Update bugfix-64bb0c4b-8d3b-45b0-b615-8722bb3e9e4a.json --------- Co-authored-by: Richard Li <[email protected]>
1 parent c1f9066 commit 225938d

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type" : "bugfix",
3+
"description" : "Fix Runtime Exception when opening a tool window (#4849)"
4+
}

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ import software.aws.toolkits.core.utils.debug
1212
import software.aws.toolkits.core.utils.getLogger
1313
import software.aws.toolkits.core.utils.info
1414
import software.aws.toolkits.core.utils.warn
15-
import software.aws.toolkits.jetbrains.core.credentials.ToolkitConnection
16-
import software.aws.toolkits.jetbrains.core.credentials.ToolkitConnectionManager
17-
import software.aws.toolkits.jetbrains.core.credentials.pinning.QConnection
1815
import software.aws.toolkits.jetbrains.services.amazonq.apps.AmazonQAppInitContext
1916
import software.aws.toolkits.jetbrains.services.codewhisperer.credentials.CodeWhispererClientAdaptor
2017
import software.aws.toolkits.jetbrains.services.codewhisperer.customization.CodeWhispererCustomization
@@ -32,7 +29,6 @@ import software.aws.toolkits.jetbrains.services.telemetry.TelemetryService
3229
import software.aws.toolkits.jetbrains.utils.notifyError
3330
import software.aws.toolkits.resources.message
3431
import software.aws.toolkits.telemetry.AmazonqTelemetry
35-
import software.aws.toolkits.telemetry.AuthTelemetry
3632
import software.aws.toolkits.telemetry.CwsprChatCommandType
3733
import software.aws.toolkits.telemetry.CwsprChatConversationType
3834
import software.aws.toolkits.telemetry.CwsprChatInteractionType
@@ -390,20 +386,12 @@ class TelemetryHelper(private val context: AmazonQAppInitContext, private val se
390386
companion object {
391387
private val logger = getLogger<TelemetryHelper>()
392388

393-
fun getQConnection(): ToolkitConnection? = ToolkitConnectionManager.getInstance(null).activeConnectionForFeature(QConnection.getInstance())
394-
395389
fun recordOpenChat() {
396390
AmazonqTelemetry.openChat(passive = true)
397-
if (getQConnection() == null) {
398-
AuthTelemetry.signInPageOpened()
399-
}
400391
}
401392

402393
fun recordCloseChat() {
403394
AmazonqTelemetry.closeChat(passive = true)
404-
if (getQConnection() == null) {
405-
AuthTelemetry.signInPageClosed()
406-
}
407395
}
408396

409397
fun recordTelemetryChatRunCommand(type: CwsprChatCommandType, name: String? = null, startUrl: String? = null) {

0 commit comments

Comments
 (0)