Skip to content

Commit 293423d

Browse files
Merge branch 'feature/q-lsp' into lodogga/overrideLSPArtifacts
2 parents aefe915 + 954096d commit 293423d

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ reported the issue. Please try to include as much information as you can. Detail
3131
brew install dotnet@6
3232
```
3333
* If Gradle cannot find `dotnet`, run `./gradlew --stop` and `./gradlew projects` to reload the daemon. Note that this should be done in your terminal as invoking Gradle through the IDE will use the IDE's cached PATH.
34+
* It is recommended to [launch your IDE from the terminal](https://www.jetbrains.com/help/idea/working-with-the-ide-features-from-command-line.html) due to a known issue with Gradle/Java 21 where the Gradle daemon does not respect your PATH variable when the IDE is started from the desktop/Toolbox.
3435
3536
### Instructions
3637

ui-tests-starter/tst-243+/software/aws/toolkits/jetbrains/uitests/chatTests/AmazonQChatTest.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ class AmazonQChatTest {
8686
assertTrue(result.contains("/clear"))
8787
assertTrue(result.contains("/review"))
8888
assertTrue(result.contains("/test"))
89+
println("Assertions done")
8990
}
9091
}
9192

ui-tests-starter/tst-prep/PreAmazonQUiTest.kt

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,13 @@ class PreAmazonQUiTest {
3939
@Test
4040
fun `can set up Connection`() {
4141
try {
42-
val startUrl = System.getenv("TEST_START_URL")
43-
val region = System.getenv("TEST_REGION")
44-
connection = LegacyManagedBearerSsoConnection(startUrl, region, Q_SCOPES)
45-
ConnectionPinningManager.getInstance().setPinnedConnection(QConnection.getInstance(), connection)
46-
(connection.getConnectionSettings().tokenProvider.delegate as BearerTokenProvider).reauthenticate()
42+
if (System.getenv("CI").toBoolean()) {
43+
val startUrl = System.getenv("TEST_START_URL")
44+
val region = System.getenv("TEST_REGION")
45+
connection = LegacyManagedBearerSsoConnection(startUrl, region, Q_SCOPES)
46+
ConnectionPinningManager.getInstance().setPinnedConnection(QConnection.getInstance(), connection)
47+
(connection.getConnectionSettings().tokenProvider.delegate as BearerTokenProvider).reauthenticate()
48+
}
4749
} catch (e: Exception) {
4850
error("Could not connect to Idc.")
4951
}

0 commit comments

Comments
 (0)