fix(amazonq): refactor qpanel to be less leaky to fix chat panel not available (#5660)

The Q panel leaks implementation everywhere so it is difficult to cleanup and recreate the panel

Author: rli

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QLoginWebview.kt

@@ -18,6 +18,10 @@ import com.intellij.ui.components.panels.Wrapper
 import com.intellij.ui.dsl.builder.Align
 import com.intellij.ui.dsl.builder.panel
 import com.intellij.ui.jcef.JBCefJSQuery
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.flow.distinctUntilChanged
+import kotlinx.coroutines.flow.launchIn
+import kotlinx.coroutines.flow.onEach
 import org.cef.CefApp
 import software.aws.toolkits.core.utils.debug
 import software.aws.toolkits.core.utils.error
@@ -40,6 +44,8 @@ import software.aws.toolkits.jetbrains.services.amazonq.profile.QProfileSwitchIn
 import software.aws.toolkits.jetbrains.services.amazonq.profile.QRegionProfile
 import software.aws.toolkits.jetbrains.services.amazonq.profile.QRegionProfileManager
 import software.aws.toolkits.jetbrains.services.amazonq.util.createBrowser
+import software.aws.toolkits.jetbrains.services.amazonq.webview.theme.EditorThemeAdapter
+import software.aws.toolkits.jetbrains.services.amazonq.webview.theme.ThemeBrowserAdapter
 import software.aws.toolkits.jetbrains.utils.isQConnected
 import software.aws.toolkits.jetbrains.utils.isQExpired
 import software.aws.toolkits.jetbrains.utils.isQWebviewsAvailable
@@ -54,7 +60,7 @@ import javax.swing.JButton
 import javax.swing.JComponent
 
 @Service(Service.Level.PROJECT)
-class QWebviewPanel private constructor(val project: Project) : Disposable {
+class QWebviewPanel private constructor(val project: Project, private val scope: CoroutineScope) : Disposable {
     private val webviewContainer = Wrapper()
     var browser: QWebviewBrowser? = null
         private set
@@ -102,6 +108,14 @@ class QWebviewPanel private constructor(val project: Project) : Disposable {
         } else {
             browser = QWebviewBrowser(project, this).also {
                 webviewContainer.add(it.component())
+
+                val themeBrowserAdapter = ThemeBrowserAdapter()
+                EditorThemeAdapter().onThemeChange()
+                    .distinctUntilChanged()
+                    .onEach { theme ->
+                        themeBrowserAdapter.updateLoginThemeInBrowser(it.jcefBrowser.cefBrowser, theme)
+                    }
+                    .launchIn(scope)
             }
         }
     }

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/toolwindow/AmazonQPanel.kt

@@ -10,24 +10,57 @@ import com.intellij.openapi.application.runInEdt
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.util.Disposer
 import com.intellij.ui.components.JBLoadingPanel
-import com.intellij.ui.components.JBPanelWithEmptyText
 import com.intellij.ui.components.JBTextArea
 import com.intellij.ui.components.panels.Wrapper
 import com.intellij.ui.dsl.builder.Align
 import com.intellij.ui.dsl.builder.AlignX
 import com.intellij.ui.dsl.builder.AlignY
 import com.intellij.ui.dsl.builder.panel
 import com.intellij.ui.jcef.JBCefApp
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.launch
 import software.aws.toolkits.jetbrains.isDeveloperMode
+import software.aws.toolkits.jetbrains.services.amazonq.apps.AmazonQAppInitContext
+import software.aws.toolkits.jetbrains.services.amazonq.apps.AppConnection
+import software.aws.toolkits.jetbrains.services.amazonq.commands.MessageTypeRegistry
 import software.aws.toolkits.jetbrains.services.amazonq.lsp.artifacts.ArtifactHelper
+import software.aws.toolkits.jetbrains.services.amazonq.lsp.flareChat.AsyncChatUiListener
+import software.aws.toolkits.jetbrains.services.amazonq.messages.AmazonQMessage
+import software.aws.toolkits.jetbrains.services.amazonq.messages.MessageConnector
+import software.aws.toolkits.jetbrains.services.amazonq.profile.QRegionProfileManager
+import software.aws.toolkits.jetbrains.services.amazonq.util.highlightCommand
 import software.aws.toolkits.jetbrains.services.amazonq.webview.Browser
-import java.awt.event.ActionListener
+import software.aws.toolkits.jetbrains.services.amazonq.webview.BrowserConnector
+import software.aws.toolkits.jetbrains.services.amazonq.webview.FqnWebviewAdapter
+import software.aws.toolkits.jetbrains.services.amazonq.webview.theme.EditorThemeAdapter
+import software.aws.toolkits.jetbrains.services.amazonqCodeScan.auth.isCodeScanAvailable
+import software.aws.toolkits.jetbrains.services.amazonqCodeTest.auth.isCodeTestAvailable
+import software.aws.toolkits.jetbrains.services.amazonqDoc.auth.isDocAvailable
+import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.auth.isFeatureDevAvailable
+import software.aws.toolkits.jetbrains.services.codemodernizer.utils.isCodeTransformAvailable
 import java.util.concurrent.CompletableFuture
 import javax.swing.JButton
 
-class AmazonQPanel(private val parent: Disposable, val project: Project) {
+class AmazonQPanel(val project: Project, private val scope: CoroutineScope) : Disposable {
+    private val browser = CompletableFuture<Browser>()
     private val webviewContainer = Wrapper()
-    val browser = CompletableFuture<Browser>()
+    private val appSource = AppSource()
+    private val browserConnector = BrowserConnector(project = project)
+    private val editorThemeAdapter = EditorThemeAdapter()
+    private val appConnections = mutableListOf<AppConnection>()
+
+    init {
+        project.messageBus.connect().subscribe(
+            AsyncChatUiListener.TOPIC,
+            object : AsyncChatUiListener {
+                override fun onChange(message: String) {
+                    runInEdt {
+                        browser.get()?.postChat(message)
+                    }
+                }
+            }
+        )
+    }
 
     val component = panel {
         row {
@@ -40,14 +73,12 @@ class AmazonQPanel(private val parent: Disposable, val project: Project) {
             row {
                 cell(
                     JButton("Show Web Debugger").apply {
-                        addActionListener(
-                            ActionListener {
-                                // Code to be executed when the button is clicked
-                                // Add your logic here
-
-                                browser.get().jcefBrowser.openDevtools()
-                            },
-                        )
+                        addActionListener {
+                            // Code to be executed when the button is clicked
+                            // Add your logic here
+
+                            browser.get().jcefBrowser.openDevtools()
+                        }
                     },
                 )
                     .align(AlignX.CENTER)
@@ -57,19 +88,6 @@ class AmazonQPanel(private val parent: Disposable, val project: Project) {
     }
 
     init {
-        init()
-    }
-
-    fun disposeAndRecreate() {
-        webviewContainer.removeAll()
-        val toDispose = browser.get()
-        init()
-        if (toDispose != null) {
-            Disposer.dispose(toDispose)
-        }
-    }
-
-    private fun init() {
         if (!JBCefApp.isSupported()) {
             // Fallback to an alternative browser-less solution
             if (AppMode.isRemoteDevHost()) {
@@ -79,11 +97,10 @@ class AmazonQPanel(private val parent: Disposable, val project: Project) {
             }
             browser.complete(null)
         } else {
-            val loadingPanel = JBLoadingPanel(null, parent, 0)
+            val loadingPanel = JBLoadingPanel(null, this)
             val wrapper = Wrapper()
             loadingPanel.startLoading()
 
-            loadingPanel.add(JBPanelWithEmptyText().withEmptyText("Wait for chat to be ready"))
             webviewContainer.add(wrapper)
             wrapper.setContent(loadingPanel)
 
@@ -92,12 +109,93 @@ class AmazonQPanel(private val parent: Disposable, val project: Project) {
                 loadingPanel.stopLoading()
                 runInEdt {
                     browser.complete(
-                        Browser(parent, webUri, project).also {
+                        Browser(this, webUri, project).also {
                             wrapper.setContent(it.component())
+
+                            initConnections()
+                            connectUi(it)
+                            connectApps(it)
                         }
                     )
                 }
             }
         }
     }
+
+    fun sendMessage(message: AmazonQMessage, tabType: String) {
+        appConnections.filter { it.app.tabTypes.contains(tabType) }.forEach {
+            scope.launch {
+                it.messagesFromUiToApp.publish(message)
+            }
+        }
+    }
+
+    fun sendMessageAppToUi(message: AmazonQMessage, tabType: String) {
+        appConnections.filter { it.app.tabTypes.contains(tabType) }.forEach {
+            scope.launch {
+                it.messagesFromAppToUi.publish(message)
+            }
+        }
+    }
+
+    private fun initConnections() {
+        val apps = appSource.getApps(project)
+        apps.forEach { app ->
+            appConnections += AppConnection(
+                app = app,
+                messagesFromAppToUi = MessageConnector(),
+                messagesFromUiToApp = MessageConnector(),
+                messageTypeRegistry = MessageTypeRegistry(),
+            )
+        }
+    }
+
+    private fun connectApps(browser: Browser) {
+        val fqnWebviewAdapter = FqnWebviewAdapter(browser.jcefBrowser, browserConnector)
+
+        appConnections.forEach { connection ->
+            val initContext = AmazonQAppInitContext(
+                project = project,
+                messagesFromAppToUi = connection.messagesFromAppToUi,
+                messagesFromUiToApp = connection.messagesFromUiToApp,
+                messageTypeRegistry = connection.messageTypeRegistry,
+                fqnWebviewAdapter = fqnWebviewAdapter,
+            )
+            // Connect the app to the UI
+            connection.app.init(initContext)
+            // Dispose of the app when the tool window is disposed.
+            Disposer.register(this, connection.app)
+        }
+    }
+
+    private fun connectUi(browser: Browser) {
+        browser.init(
+            isCodeTransformAvailable = isCodeTransformAvailable(project),
+            isFeatureDevAvailable = isFeatureDevAvailable(project),
+            isCodeScanAvailable = isCodeScanAvailable(project),
+            isCodeTestAvailable = isCodeTestAvailable(project),
+            isDocAvailable = isDocAvailable(project),
+            highlightCommand = highlightCommand(),
+            activeProfile = QRegionProfileManager.getInstance().takeIf { it.shouldDisplayProfileInfo(project) }?.activeProfile(project)
+        )
+
+        scope.launch {
+            // Pipe messages from the UI to the relevant apps and vice versa
+            browserConnector.connect(
+                browser = browser,
+                connections = appConnections,
+            )
+        }
+
+        scope.launch {
+            // Update the theme in the UI when the IDE theme changes
+            browserConnector.connectTheme(
+                chatBrowser = browser.jcefBrowser.cefBrowser,
+                themeSource = editorThemeAdapter.onThemeChange(),
+            )
+        }
+    }
+
+    override fun dispose() {
+    }
 }