Fix ActionUpdateThread.OLD_EDT errors (#4162)

Author: rli

.changes/next-release/bugfix-e68184f7-7b30-451d-8791-5d9a4628a59d.json

@@ -0,0 +1,4 @@
+{
+  "type" : "bugfix",
+  "description" : "Fix 'ActionUpdateThread.OLD_EDT' deprecation errors in 2024.1"
+}

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/credentials/ConnectionSettingsMenuBuilder.kt

@@ -5,6 +5,7 @@ package software.aws.toolkits.jetbrains.core.credentials
 
 import com.intellij.icons.AllIcons
 import com.intellij.openapi.actionSystem.ActionManager
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.DefaultActionGroup
@@ -202,6 +203,8 @@ class ConnectionSettingsMenuBuilder private constructor() {
         private val selected: Boolean,
         private val onSelect: (T) -> Unit
     ) : ToggleAction(title), DumbAware {
+        override fun getActionUpdateThread() = ActionUpdateThread.BGT
+
         override fun isSelected(e: AnActionEvent): Boolean = selected
 
         override fun setSelected(e: AnActionEvent, state: Boolean) {

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/credentials/ConnectionSettingsMenus.kt

@@ -5,6 +5,7 @@ package software.aws.toolkits.jetbrains.core.credentials
 
 import com.intellij.ide.DataManager
 import com.intellij.openapi.actionSystem.ActionManager
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.DataContext
@@ -169,6 +170,7 @@ open class ProjectLevelSettingSelector(private val project: Project, settingsMod
 }
 
 class ToolkitConnectionComboBoxAction(private val project: Project) : ComboBoxAction(), DumbAware {
+
     private val logic = object : ProjectLevelSettingSelector(project, CREDENTIALS) {
         override fun currentCredentials(): CredentialIdentifier? {
             val active = ToolkitConnectionManager.getInstance(project).activeConnection()
@@ -191,7 +193,9 @@ class ToolkitConnectionComboBoxAction(private val project: Project) : ComboBoxAc
         }
     }
 
-    override fun createPopupActionGroup(button: JComponent?) = logic.selectionMenuActions()
+    override fun createPopupActionGroup(button: JComponent, dataContext: DataContext) = logic.selectionMenuActions()
+
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
 
     override fun update(e: AnActionEvent) {
         val active = ToolkitConnectionManager.getInstance(project).activeConnection()
@@ -209,7 +213,9 @@ class ToolkitConnectionComboBoxAction(private val project: Project) : ComboBoxAc
 }
 
 class SettingsSelectorComboBoxAction(private val selectorLogic: SettingsSelectorLogicBase) : ComboBoxAction(), DumbAware {
-    override fun createPopupActionGroup(button: JComponent?) = selectorLogic.selectionMenuActions()
+    override fun createPopupActionGroup(button: JComponent, dataContext: DataContext) = selectorLogic.selectionMenuActions()
+
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
 
     override fun update(e: AnActionEvent) {
         updatePresentation(e.presentation)

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/credentials/RefreshConnectionAction.kt

@@ -4,6 +4,7 @@
 package software.aws.toolkits.jetbrains.core.credentials
 
 import com.intellij.icons.AllIcons
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.project.DumbAware
@@ -16,6 +17,9 @@ import software.aws.toolkits.telemetry.AwsTelemetry
 class RefreshConnectionAction(text: String = message("settings.refresh.description")) :
     AnAction(text, null, AllIcons.Actions.Refresh),
     DumbAware {
+
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
+
     override fun update(e: AnActionEvent) {
         val project = e.project ?: return
         e.presentation.isEnabled = when (val state = AwsConnectionManager.getInstance(project).connectionState) {

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/credentials/actions/MoreConnectionActionsAction.kt

@@ -6,6 +6,7 @@ package software.aws.toolkits.jetbrains.core.credentials.actions
 import com.intellij.icons.AllIcons
 import com.intellij.openapi.actionSystem.ActionGroup
 import com.intellij.openapi.actionSystem.ActionManager
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.DefaultActionGroup
 import com.intellij.openapi.project.DumbAwareAction
@@ -19,6 +20,8 @@ import software.aws.toolkits.jetbrains.core.utils.buildList
 import software.aws.toolkits.resources.message
 
 class MoreConnectionActionsAction : DumbAwareAction(AllIcons.Actions.MoreHorizontal) {
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
+
     override fun update(e: AnActionEvent) {
         e.presentation.icon = if (lazyGetUnauthedBearerConnections().isEmpty()) AllIcons.Actions.MoreHorizontal else AllIcons.General.Warning
     }

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/credentials/sono/SonoLogoutAction.kt

@@ -3,11 +3,14 @@
 
 package software.aws.toolkits.jetbrains.core.credentials.sono
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.project.DumbAwareAction
 import software.aws.toolkits.jetbrains.core.credentials.sso.bearer.BearerTokenProvider
 
 class SonoLogoutAction : DumbAwareAction() {
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
+
     override fun update(e: AnActionEvent) {
         e.presentation.isEnabledAndVisible = provider(e)?.supportsLogout() ?: false
     }

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/experiments/ExperimentsActionGroup.kt

@@ -3,6 +3,7 @@
 
 package software.aws.toolkits.jetbrains.core.experiments
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.DefaultActionGroup
@@ -11,6 +12,8 @@ import com.intellij.openapi.project.DumbAware
 import software.aws.toolkits.resources.message
 
 class ExperimentsActionGroup : DefaultActionGroup(message("aws.toolkit.experimental.title"), true), DumbAware {
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
+
     override fun getChildren(e: AnActionEvent?): Array<AnAction> =
         ToolkitExperimentManager.visibleExperiments().map { EnableExperimentAction(it) }.toTypedArray()
 
@@ -20,6 +23,8 @@ class ExperimentsActionGroup : DefaultActionGroup(message("aws.toolkit.experimen
 }
 
 class EnableExperimentAction(private val experiment: ToolkitExperiment) : ToggleAction(experiment.title, experiment.description, null), DumbAware {
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
+
     override fun isSelected(e: AnActionEvent): Boolean = experiment.isEnabled()
     override fun setSelected(e: AnActionEvent, state: Boolean) = experiment.setState(state)
 }

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/actions/AbstractActions.kt

@@ -4,6 +4,7 @@
 package software.aws.toolkits.jetbrains.core.explorer.actions
 
 import com.intellij.openapi.actionSystem.ActionGroup
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
 import software.aws.toolkits.jetbrains.core.explorer.ExplorerDataKeys
@@ -68,6 +69,8 @@ abstract class ExplorerNodeAction<in T : AwsExplorerNode<*>> : AnAction {
     constructor() : super()
     constructor(text: String, description: String? = null, icon: Icon? = null) : super(text, description, icon)
 
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
+
     /**
      * Invoked periodically with the selected items of type [T].
      *

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/devToolsTab/nodes/actions/UnpinConnectionAction.kt

@@ -3,17 +3,19 @@
 
 package software.aws.toolkits.jetbrains.core.explorer.devToolsTab.nodes.actions
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
-import com.intellij.openapi.actionSystem.UpdateInBackground
 import com.intellij.openapi.project.DumbAware
 import software.aws.toolkits.jetbrains.core.credentials.pinning.ConnectionPinningManager
 import software.aws.toolkits.jetbrains.core.credentials.pinning.FeatureWithPinnedConnection
 import software.aws.toolkits.jetbrains.core.explorer.ExplorerTreeToolWindowDataKeys
 import software.aws.toolkits.jetbrains.core.explorer.devToolsTab.nodes.PinnedConnectionNode
 import software.aws.toolkits.resources.message
 
-class UnpinConnectionAction : AnAction(), DumbAware, UpdateInBackground {
+class UnpinConnectionAction : AnAction(), DumbAware {
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
+
     override fun update(e: AnActionEvent) {
         val project = e.project
         val feature = feature(e)

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/terminal/OpenAwsLocalTerminal.kt

@@ -3,6 +3,7 @@
 
 package software.aws.toolkits.jetbrains.core.terminal
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.LangDataKeys
 import com.intellij.openapi.application.ApplicationManager
@@ -32,6 +33,7 @@ class OpenAwsLocalTerminal : DumbAwareAction(
     { message("aws.terminal.action.tooltip") },
     TerminalIcons.OpenTerminal_13x13
 ) {
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
 
     override fun update(e: AnActionEvent) {
         if (AwsLocalTerminalExperiment.isEnabled()) {