Notify when user doesn't have ListObjectVersions Permission (#3259)

* revert changes

* messaging fix

Author: manodnyab

jetbrains-core/src/software/aws/toolkits/jetbrains/services/s3/editor/S3TreeNode.kt

@@ -131,7 +131,7 @@ open class S3TreeDirectoryNode(bucket: S3VirtualBucket, parent: S3TreeDirectoryN
             bucket.handleDeletedBucket()
             return emptyList()
         } catch (e: S3Exception) {
-            e.notifyError("Access denied to bucket")
+            e.notifyError(message("s3.bucket.load.fail.title"))
             return buildList {
                 if (continuationMarker != null) {
                     add(S3TreeErrorContinuationNode(bucket, this@S3TreeDirectoryNode, this@S3TreeDirectoryNode.key, continuationMarker))
@@ -218,6 +218,22 @@ class S3TreeObjectNode(parent: S3TreeDirectoryNode, key: String, override val si
         } catch (e: NoSuchBucketException) {
             bucket.handleDeletedBucket()
             return emptyList()
+        } catch (e: S3Exception) {
+            e.notifyError(message("s3.object.load.fail.title"))
+            return buildList {
+                if (continuationMarker != null) {
+                    add(
+                        S3TreeErrorContinuationNode(
+                            bucket,
+                            this@S3TreeObjectNode,
+                            this@S3TreeObjectNode.key,
+                            continuationMarker
+                        )
+                    )
+                } else {
+                    add(S3TreeErrorNode(bucket, this@S3TreeObjectNode))
+                }
+            }
         } catch (e: Exception) {
             LOG.error(e) { "Loading objects failed!" }
             return buildList {

resources/resources/software/aws/toolkits/resources/MessagesBundle.properties

@@ -1050,6 +1050,7 @@ run_configuration_extension.feature.python.title=AWS connected Python Run Config
 run_configuration_extension.inject_aws_connection_exception=Exception occurred attempting to inject region/credentials
 run_configuration_extension.manual=Other credential profile/region
 s3.bucket.label=Bucket Name/URI
+s3.bucket.load.fail.title=Access denied to bucket
 s3.bucket.name.label=Bucket Name:
 s3.copy.bucket.action=Copy Name
 s3.copy.path=Copy Path
@@ -1082,6 +1083,7 @@ s3.load_more_failed=Failed to load more! load more...
 s3.name=Name
 s3.new.folder=New Folder...
 s3.new.folder.name=Folder name:
+s3.object.load.fail.title=Unable to load objects - Access denied
 s3.open.file_too_big=The editor cannot open files larger than {0}
 s3.open.viewer.bucket.failed=Failed to open bucket
 s3.open.viewer.bucket_does_not_exist=Bucket {0} does not exist.