Skip to content

Commit 3364725

Browse files
committed
update mocked data types to use proper override functions
1 parent 31f03e6 commit 3364725

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

plugins/toolkit/jetbrains-ultimate/tst/software/aws/toolkits/jetbrains/datagrip/auth/SecretsManagerAuthWidgetTest.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
package software.aws.toolkits.jetbrains.datagrip.auth
55

6+
import com.intellij.database.dataSource.DatabaseConnectionPoint
67
import com.intellij.database.dataSource.LocalDataSource
78
import com.intellij.database.dataSource.url.template.UrlEditorModel
89
import com.intellij.testFramework.ProjectRule
@@ -72,31 +73,31 @@ class SecretsManagerAuthWidgetTest {
7273

7374
@Test
7475
fun `Sets region from Redshift URL`() {
75-
widget.reset(mock(), false)
76+
widget.reset(mock<DatabaseConnectionPoint>(), false)
7677
val endpointUrl = "jdbc:redshift://redshift-cluster.host.$defaultRegion.redshift.amazonaws.com:5439/dev"
7778
widget.updateFromUrl(mock<UrlEditorModel> { on { url } doReturn endpointUrl })
7879
assertThat(widget.getSelectedRegion()?.id).isEqualTo(defaultRegion)
7980
}
8081

8182
@Test
8283
fun `Sets region from RDS URL`() {
83-
widget.reset(mock(), false)
84+
widget.reset(mock<DatabaseConnectionPoint>(), false)
8485
val endpointUrl = "jdbc:postgresql://abc.host.$defaultRegion.rds.amazonaws.com:5432/dev"
8586
widget.updateFromUrl(mock<UrlEditorModel> { on { url } doReturn endpointUrl })
8687
assertThat(widget.getSelectedRegion()?.id).isEqualTo(defaultRegion)
8788
}
8889

8990
@Test
9091
fun `Does not unset region on invalid url`() {
91-
widget.reset(mock(), false)
92+
widget.reset(mock<DatabaseConnectionPoint>(), false)
9293
val endpointUrl = "jdbc:postgresql://abc.host.$defaultRegion.rds.amazonaws.com:5432/dev"
9394
widget.updateFromUrl(mock<UrlEditorModel> { on { url } doReturn endpointUrl })
9495
val badUrl = "jdbc:postgresql://abc.host.1000000%invalidregion.rds.amazonaws.com:5432/dev"
9596
widget.updateFromUrl(mock<UrlEditorModel> { on { url } doReturn badUrl })
9697
assertThat(widget.getSelectedRegion()?.id).isEqualTo(defaultRegion)
9798
}
9899

99-
private fun buildDataSource(hasSecret: Boolean = true, getUrlFromSecret: Boolean = false): LocalDataSource = mock {
100+
private fun buildDataSource(hasSecret: Boolean = true, getUrlFromSecret: Boolean = false): DatabaseConnectionPoint = mock {
100101
on { additionalProperties } doAnswer {
101102
mutableMapOf<String, String>().also {
102103
it[CREDENTIAL_ID_PROPERTY] = credentialId

plugins/toolkit/jetbrains-ultimate/tst/software/aws/toolkits/jetbrains/services/rds/auth/IamAuthWidgetTest.kt

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33

44
package software.aws.toolkits.jetbrains.services.rds.auth
55

6+
import com.intellij.database.dataSource.DatabaseConnectionConfig
7+
import com.intellij.database.dataSource.DatabaseConnectionPoint
68
import com.intellij.database.dataSource.LocalDataSource
79
import com.intellij.database.dataSource.url.template.UrlEditorModel
810
import com.intellij.testFramework.ProjectRule
@@ -76,15 +78,15 @@ class IamAuthWidgetTest {
7678

7779
@Test
7880
fun `Sets region from URL`() {
79-
widget.reset(mock(), false)
81+
widget.reset(mock<DatabaseConnectionPoint>(), false)
8082
val endpointUrl = "jdbc:postgresql://abc.host.$defaultRegion.rds.amazonaws.com:5432/dev"
8183
widget.updateFromUrl(mock<UrlEditorModel> { on { url } doReturn endpointUrl })
8284
assertThat(widget.getSelectedRegion()?.id).isEqualTo(defaultRegion)
8385
}
8486

8587
@Test
8688
fun `Does not unset region on invalid url`() {
87-
widget.reset(mock(), false)
89+
widget.reset(mock<DatabaseConnectionPoint>(), false)
8890
val endpointUrl = "jdbc:postgresql://abc.host.$defaultRegion.rds.amazonaws.com:5432/dev"
8991
widget.updateFromUrl(mock<UrlEditorModel> { on { url } doReturn endpointUrl })
9092
val badUrl = "jdbc:postgresql://abc.host.1000000%invalidregion.rds.amazonaws.com:5432/dev"
@@ -94,25 +96,25 @@ class IamAuthWidgetTest {
9496

9597
@Test
9698
fun `Save saves set signing host and port if set`() {
97-
widget.reset(mock { on { additionalProperties } doReturn mapOf(RDS_SIGNING_HOST_PROPERTY to "host", RDS_SIGNING_PORT_PROPERTY to "port") }, false)
99+
widget.reset(mock<DatabaseConnectionPoint> { on { additionalProperties } doReturn mapOf(RDS_SIGNING_HOST_PROPERTY to "host", RDS_SIGNING_PORT_PROPERTY to "port") }, false)
98100
val m = mutableMapOf<String, String>()
99-
widget.save(mock { on { additionalProperties } doReturn m }, false)
101+
widget.save(mock<DatabaseConnectionConfig> { on { additionalProperties } doReturn m }, false)
100102
assertThat(m[RDS_SIGNING_HOST_PROPERTY]).isEqualTo("host")
101103
assertThat(m[RDS_SIGNING_PORT_PROPERTY]).isEqualTo("port")
102104
}
103105

104106
@Test
105107
fun `Save saves null signing host and port if not set`() {
106108
val m = mutableMapOf<String, String>()
107-
widget.save(mock { on { additionalProperties } doReturn m }, false)
109+
widget.save(mock<DatabaseConnectionConfig> { on { additionalProperties } doReturn m }, false)
108110
assertThat(m[RDS_SIGNING_HOST_PROPERTY]).isNull()
109111
assertThat(m[RDS_SIGNING_PORT_PROPERTY]).isNull()
110112
}
111113

112114
private fun buildDataSource(
113115
hasCredentials: Boolean = true,
114116
hasRegion: Boolean = true,
115-
): LocalDataSource = mock {
117+
): DatabaseConnectionPoint = mock {
116118
on { additionalProperties } doAnswer {
117119
val m = mutableMapOf<String, String>()
118120
if (hasCredentials) {

plugins/toolkit/jetbrains-ultimate/tst/software/aws/toolkits/jetbrains/services/redshift/auth/IamAuthWidgetTest.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
package software.aws.toolkits.jetbrains.services.redshift.auth
55

6+
import com.intellij.database.dataSource.DatabaseConnectionPoint
67
import com.intellij.database.dataSource.LocalDataSource
78
import com.intellij.database.dataSource.url.template.UrlEditorModel
89
import com.intellij.testFramework.ProjectRule
@@ -56,7 +57,7 @@ class IamAuthWidgetTest {
5657

5758
@Test
5859
fun `Does not unset region on invalid url`() {
59-
widget.reset(mock(), false)
60+
widget.reset(mock<DatabaseConnectionPoint>(), false)
6061
val endpointUrl = "jdbc:redshift://redshift-cluster.host.$defaultRegion.redshift.amazonaws.com:5439/dev"
6162
widget.updateFromUrl(mock<UrlEditorModel> { on { url } doReturn endpointUrl })
6263
val badUrl = "jdbc:redshift://redshift-cluster.host.100000%InvalidRegion.redshift.amazonaws.com:5439/dev"
@@ -66,13 +67,13 @@ class IamAuthWidgetTest {
6667

6768
@Test
6869
fun `Sets region from URL`() {
69-
widget.reset(mock(), false)
70+
widget.reset(mock<DatabaseConnectionPoint>(), false)
7071
val endpointUrl = "jdbc:redshift://redshift-cluster.host.$defaultRegion.redshift.amazonaws.com:5439/dev"
7172
widget.updateFromUrl(mock<UrlEditorModel> { on { url } doReturn endpointUrl })
7273
assertThat(widget.getSelectedRegion()?.id).isEqualTo(defaultRegion)
7374
}
7475

75-
private fun buildDataSource(hasCluster: Boolean = true): LocalDataSource = mock {
76+
private fun buildDataSource(hasCluster: Boolean = true): DatabaseConnectionPoint = mock {
7677
on { additionalProperties } doAnswer {
7778
mutableMapOf<String, String>().also {
7879
it[CREDENTIAL_ID_PROPERTY] = credentialId

0 commit comments

Comments
 (0)