Add an extra . before the file extensions recorded in metrics (#4980)

* Add an extra . before the file extensions

* addressed feedback

* detekt

* feedback

* Updated tests

Author: manodnyab

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/services/telemetry/OpenedFileTypesMetrics.kt

@@ -52,7 +52,8 @@ class OpenedFileTypesMetricsService : Disposable {
     @Synchronized
     fun addToExistingTelemetryBatch(fileExt: String) {
         if (fileExt in ALLOWED_CODE_EXTENSIONS) {
-            currentOpenedFileTypes.add(fileExt)
+            val extension = ".$fileExt"
+            currentOpenedFileTypes.add(extension)
         }
     }
 

plugins/core/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/telemetry/OpenedFileTypeMetricsTest.kt

@@ -3,34 +3,34 @@
 
 package software.aws.toolkits.jetbrains.services.telemetry
 
-import org.junit.After
-import org.junit.Before
-import org.junit.Test
-import org.mockito.kotlin.times
+import org.assertj.core.api.Assertions.assertThat
+import org.junit.jupiter.api.AfterEach
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Test
 
 class OpenedFileTypeMetricsTest {
 
     private lateinit var service: OpenedFileTypesMetricsService
 
-    @Before
+    @BeforeEach
     fun setup() {
         service = OpenedFileTypesMetricsService()
     }
 
-    @After
+    @AfterEach
     fun teardown() {
         service.dispose()
     }
 
     @Test
     fun `test addToExistingTelemetryBatch with allowed extension`() {
         service.addToExistingTelemetryBatch("kt")
-        assert(service.getOpenedFileTypes().contains("kt"))
+        assertThat(service.getOpenedFileTypes()).contains(".kt")
     }
 
     @Test
     fun `test addToExistingTelemetryBatch with disallowed extension`() {
         service.addToExistingTelemetryBatch("txt")
-        assert(service.getOpenedFileTypes().isEmpty())
+        assertThat(service.getOpenedFileTypes()).isEmpty()
     }
 }