Skip to content

Commit 3ab0029

Browse files
committed
feedback
1 parent d2d5412 commit 3ab0029

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

plugins/core/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/telemetry/OpenedFileTypeMetricsTest.kt

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,35 +3,34 @@
33

44
package software.aws.toolkits.jetbrains.services.telemetry
55

6-
import org.junit.After
7-
import org.junit.Before
8-
import org.junit.Test
9-
import org.junit.jupiter.api.Assertions.assertEquals
10-
import org.junit.jupiter.api.Assertions.assertTrue
6+
import org.assertj.core.api.Assertions.assertThat
7+
import org.junit.jupiter.api.AfterEach
8+
import org.junit.jupiter.api.BeforeEach
9+
import org.junit.jupiter.api.Test
1110

1211
class OpenedFileTypeMetricsTest {
1312

1413
private lateinit var service: OpenedFileTypesMetricsService
1514

16-
@Before
15+
@BeforeEach
1716
fun setup() {
1817
service = OpenedFileTypesMetricsService()
1918
}
2019

21-
@After
20+
@AfterEach
2221
fun teardown() {
2322
service.dispose()
2423
}
2524

2625
@Test
2726
fun `test addToExistingTelemetryBatch with allowed extension`() {
2827
service.addToExistingTelemetryBatch("kt")
29-
assertTrue(service.getOpenedFileTypes().contains(".kt"))
28+
assertThat(service.getOpenedFileTypes().contains(".kt"))
3029
}
3130

3231
@Test
3332
fun `test addToExistingTelemetryBatch with disallowed extension`() {
3433
service.addToExistingTelemetryBatch("txt")
35-
assertEquals(service.getOpenedFileTypes(), emptySet<String>())
34+
assertThat(service.getOpenedFileTypes().isEmpty())
3635
}
3736
}

0 commit comments

Comments
 (0)