detekt

Author: samgst-amazon

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/notifications/NotificationStateUtils.kt

@@ -21,16 +21,16 @@ class InstantConverter : Converter<Instant>() {
     override fun fromString(value: String): Instant = Instant.ofEpochMilli(value.toLong())
 }
 
-
 data class DismissedNotification(
+    @Attribute
     val id: String = "",
     @Attribute(converter = InstantConverter::class)
-    val dismissedAt: Instant = Instant.now()
+    val dismissedAt: Instant = Instant.now(),
 )
 
 data class NotificationDismissalConfiguration(
     @Property
-    var dismissedNotifications: MutableSet<DismissedNotification> = mutableSetOf()
+    var dismissedNotifications: MutableSet<DismissedNotification> = mutableSetOf(),
 )
 
 @Service
@@ -47,9 +47,8 @@ class NotificationDismissalState : PersistentStateComponent<NotificationDismissa
         cleanExpiredNotifications()
     }
 
-    fun isDismissed(notificationId: String): Boolean {
-        return state.dismissedNotifications.any { it.id == notificationId }
-    }
+    fun isDismissed(notificationId: String): Boolean =
+        state.dismissedNotifications.any { it.id == notificationId }
 
     fun dismissNotification(notificationId: String) {
         state.dismissedNotifications.add(
@@ -71,7 +70,6 @@ class NotificationDismissalState : PersistentStateComponent<NotificationDismissa
     }
 }
 
-
 @Service
 @State(name = "notificationEtag", storages = [Storage("aws.xml", roamingType = RoamingType.DISABLED)])
 class NotificationEtagState : PersistentStateComponent<NotificationEtagConfiguration> {

plugins/core/jetbrains-community/tst/software/aws/toolkits/jetbrains/core/notifications/NotificationDismissalStateTest.kt

@@ -3,7 +3,9 @@
 
 package software.aws.toolkits.jetbrains.core.notifications
 
-import org.junit.jupiter.api.Assertions.*
+import org.junit.jupiter.api.Assertions.assertEquals
+import org.junit.jupiter.api.Assertions.assertFalse
+import org.junit.jupiter.api.Assertions.assertTrue
 import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Test
 import java.time.Instant
@@ -34,7 +36,7 @@ class NotificationDismissalStateTest {
     }
 
     @Test
-fun `notifications older than 2 months are removed`() {
+    fun `notifications older than 2 months are removed`() {
         val oldNotification = DismissedNotification(
             id = "old-notification",
             dismissedAt = Instant.now().minus(61, ChronoUnit.DAYS)