Skip to content

Commit 4e5b072

Browse files
authored
surface error message to users if plugin can't read aws/config file (#4513)
1 parent 8e11060 commit 4e5b072

File tree

1 file changed

+6
-5
lines changed
  • plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/credentials

1 file changed

+6
-5
lines changed

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/LoginUtils.kt

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ package software.aws.toolkits.jetbrains.core.credentials
66
import com.intellij.openapi.progress.ProcessCanceledException
77
import com.intellij.openapi.project.Project
88
import com.intellij.openapi.vfs.VirtualFileManager
9+
import org.slf4j.LoggerFactory
10+
import org.slf4j.event.Level
911
import software.amazon.awssdk.auth.credentials.AwsBasicCredentials
1012
import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider
1113
import software.amazon.awssdk.profiles.Profile
@@ -30,6 +32,8 @@ import software.aws.toolkits.telemetry.CredentialSourceId
3032
import software.aws.toolkits.telemetry.Result
3133
import java.io.IOException
3234

35+
private val LOG = LoggerFactory.getLogger("LoginUtils")
36+
3337
sealed interface Login {
3438
val id: CredentialSourceId
3539

@@ -58,12 +62,9 @@ sealed interface Login {
5862

5963
fun loginIdc(project: Project): AwsBearerTokenConnection? {
6064
// we have this check here so we blow up early if user has an invalid config file
61-
try {
65+
LOG.tryOrNull("Failed to read sso sessions file", level = Level.ERROR) {
6266
configFilesFacade.readSsoSessions()
63-
} catch (e: Exception) {
64-
println("Failed to read sso sessions file")
65-
return null
66-
}
67+
} ?: return null
6768

6869
val profile = UserConfigSsoSessionProfile(
6970
configSessionName = validatedSsoIdentifierFromUrl(startUrl),

0 commit comments

Comments
 (0)