remove IDE persistent storage

Author: samgst-amazon

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt

@@ -435,10 +435,7 @@ private fun recordAddConnection(
     }
 }
 
-// Store network error state in IDE persistent storage to maintain across restarts
-private var hasSeenFirstNetworkError: Boolean
-    get() = PropertiesComponent.getInstance().getBoolean("aws.toolkit.hasSeenFirstNetworkError", false)
-    set(value) = PropertiesComponent.getInstance().setValue("aws.toolkit.hasSeenFirstNetworkError", value)
+private var hasSeenFirstNetworkError = false
 private val networkErrorLock = Object()
 
 data class ConnectionMetadata(

plugins/core/jetbrains-community/tst/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManagerTest.kt

@@ -42,7 +42,11 @@ class ToolkitAuthManagerTest {
         project = mock()
         tokenProvider = mock()
         reauthCallCount = 0
-        PropertiesComponent.getInstance().setValue("aws.toolkit.hasSeenFirstNetworkError", false)
+
+        val field = Class.forName("software.aws.toolkits.jetbrains.core.credentials.ToolkitAuthManagerKt")
+            .getDeclaredField("hasSeenFirstNetworkError")
+        field.isAccessible = true
+        field.set(null, false)
 
         mockkObject(BearerTokenProviderListener)
         mockkStatic("software.aws.toolkits.jetbrains.utils.NotificationUtilsKt")