Skip to content

Commit 512f66e

Browse files
author
C Tidd
committed
fix(amazonq): Update exception handling for feature dev to improve observability
1 parent 07640ec commit 512f66e

File tree

9 files changed

+149
-87
lines changed

9 files changed

+149
-87
lines changed

‎plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/FeatureDevConstants.kt‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,17 @@ enum class ModifySourceFolderErrorReason(
2525

2626
override fun toString(): String = reasonText
2727
}
28+
29+
enum class FeatureDevOperation(private val operationName: String) {
30+
StartTaskAssistCodeGeneration("StartTaskAssistCodeGenerator"),
31+
CreateConversation("CreateConversation"),
32+
CreateUploadUrl("CreateUploadUrl"),
33+
GenerateCode("GenerateCode"),
34+
GetTaskAssistCodeGeneration("GetTaskAssistCodeGenerator"),
35+
ExportTaskAssistArchiveResult("ExportTaskAssistArchiveResult"),
36+
UploadToS3("UploadToS3"),
37+
;
38+
39+
override fun toString(): String = operationName
40+
41+
}

‎plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/FeatureDevExceptions.kt‎

Lines changed: 49 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -6,40 +6,66 @@ package software.aws.toolkits.jetbrains.services.amazonqFeatureDev
66
import software.aws.toolkits.jetbrains.services.amazonq.RepoSizeError
77
import software.aws.toolkits.resources.message
88

9-
open class FeatureDevException(override val message: String?, override val cause: Throwable? = null) : RuntimeException()
9+
/**
10+
* FeatureDevException models failures from feature dev operations.
11+
*
12+
* - Each failure is annotated based on className, operation, and a short desc. Use the `reason()` and `reasonDesc()` members for instrumentation.
13+
* - To throw an exception without modeling, throw FeatureDevException directly.
14+
*/
15+
open class FeatureDevException(override val message: String?, open val operation: String, open val desc: String?, override val cause: Throwable? = null)
16+
: RuntimeException() {
17+
fun reason(): String {
18+
return this.javaClass.simpleName
19+
}
1020

11-
class ContentLengthError(override val message: String, override val cause: Throwable?) : RepoSizeError, RuntimeException()
21+
fun reasonDesc(): String {
22+
return when (desc) {
23+
desc -> String.format("%s: %s", this.operation, desc)
24+
else -> String.format("%s", this.operation)
25+
}
26+
}
27+
}
1228

13-
class ZipFileError(override val message: String, override val cause: Throwable?) : RuntimeException()
29+
class NoChangeRequiredException(operation: String, desc: String?, cause: Throwable? = null)
30+
: FeatureDevException(message("amazonqFeatureDev.exception.no_change_required_exception"), operation, desc, cause)
1431

15-
class CodeIterationLimitError(override val message: String, override val cause: Throwable?) : RuntimeException()
32+
class ContentLengthException(override val message: String = message("amazonqFeatureDev.content_length.error_text"),
33+
operation: String, desc: String?, cause: Throwable? = null)
34+
: RepoSizeError, FeatureDevException(message, operation, desc, cause)
1635

17-
class MonthlyConversationLimitError(override val message: String, override val cause: Throwable?) : RuntimeException()
36+
class ZipFileCorruptedException(operation: String, desc: String?, cause: Throwable? = null)
37+
: FeatureDevException("The zip file is corrupted", operation, desc, cause)
1838

19-
class UploadURLExpired(
20-
override val message: String = message(
21-
"amazonqFeatureDev.exception.upload_url_expiry"
22-
),
23-
override val cause: Throwable? = null,
24-
) : FeatureDevException(message, cause)
39+
class UploadURLExpired(operation: String, desc: String?, cause: Throwable? = null)
40+
: FeatureDevException(message("amazonqFeatureDev.exception.upload_url_expiry"), operation, desc, cause)
2541

26-
internal fun featureDevServiceError(message: String?): Nothing =
27-
throw FeatureDevException(message)
42+
class CodeIterationLimitException(operation: String, desc: String?, cause: Throwable? = null)
43+
: FeatureDevException(message("amazonqFeatureDev.code_generation.iteration_limit.error_text"), operation, desc, cause)
2844

29-
internal fun codeGenerationFailedError(): Nothing =
30-
throw FeatureDevException(message("amazonqFeatureDev.code_generation.failed_generation"))
45+
class MonthlyConversationLimitError(message: String, operation: String, desc: String?, cause: Throwable? = null)
46+
: FeatureDevException(message, operation, desc, cause)
3147

32-
internal fun uploadCodeError(): Nothing =
33-
throw FeatureDevException(message("amazonqFeatureDev.exception.upload_code"))
48+
class GuardrailsException(operation: String, desc: String?, cause: Throwable? = null)
49+
: FeatureDevException(message("amazonqFeatureDev.exception.guardrails"), operation, desc, cause)
3450

35-
internal fun conversationIdNotFound(): Nothing =
36-
throw FeatureDevException(message("amazonqFeatureDev.exception.conversation_not_found"))
51+
class PromptRefusalException(operation: String, desc: String?, cause: Throwable? = null)
52+
: FeatureDevException(message("amazonqFeatureDev.exception.prompt_refusal"), operation, desc, cause)
3753

38-
internal fun apiError(message: String?, cause: Throwable?): Nothing =
39-
throw FeatureDevException(message, cause)
54+
class ThrottlingException(operation: String, desc: String?, cause: Throwable? = null)
55+
: FeatureDevException(message("amazonqFeatureDev.exception.throttling"), operation, desc, cause)
56+
57+
class ExportParseException(operation: String, desc: String?, cause: Throwable? = null)
58+
: FeatureDevException(message("amazonqFeatureDev.exception.export_parsing_error"), operation, desc, cause)
59+
60+
class CodeGenerationException(operation: String, desc: String?, cause: Throwable? = null)
61+
: FeatureDevException(message("amazonqFeatureDev.code_generation.failed_generation"), operation, desc, cause)
62+
63+
class UploadCodeException(operation: String, desc: String?, cause: Throwable? = null)
64+
: FeatureDevException(message("amazonqFeatureDev.exception.upload_code"), operation, desc, cause)
65+
66+
class ConversationIdNotFoundException(operation: String, desc: String?, cause: Throwable? = null)
67+
: FeatureDevException(message("amazonqFeatureDev.exception.conversation_not_found"), operation, desc, cause)
4068

41-
internal fun exportParseError(): Nothing =
42-
throw FeatureDevException(message("amazonqFeatureDev.exception.export_parsing_error"))
4369

4470
val denyListedErrors = arrayOf("Deserialization error", "Inaccessible host", "UnknownHost")
4571
fun createUserFacingErrorMessage(message: String?): String? =

‎plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt‎

Lines changed: 31 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@ import software.aws.toolkits.jetbrains.services.amazonq.RepoSizeError
2929
import software.aws.toolkits.jetbrains.services.amazonq.apps.AmazonQAppInitContext
3030
import software.aws.toolkits.jetbrains.services.amazonq.auth.AuthController
3131
import software.aws.toolkits.jetbrains.services.amazonq.toolwindow.AmazonQToolWindowFactory
32-
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.CodeIterationLimitError
32+
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.CodeIterationLimitException
3333
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.DEFAULT_RETRY_LIMIT
3434
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FEATURE_NAME
3535
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FeatureDevException
3636
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.InboundAppMessagesHandler
3737
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.ModifySourceFolderErrorReason
3838
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.MonthlyConversationLimitError
3939
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.UploadURLExpired
40-
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.ZipFileError
40+
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.ZipFileCorruptedException
4141
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.createUserFacingErrorMessage
4242
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.denyListedErrors
4343
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.FeatureDevMessageType
@@ -433,7 +433,7 @@ class FeatureDevController(
433433
),
434434
)
435435
}
436-
is ZipFileError -> {
436+
is ZipFileCorruptedException -> {
437437
messenger.sendError(
438438
tabId = tabId,
439439
errMessage = err.message,
@@ -451,15 +451,7 @@ class FeatureDevController(
451451
messageType = FeatureDevMessageType.Answer,
452452
canBeVoted = true
453453
)
454-
is FeatureDevException -> {
455-
messenger.sendError(
456-
tabId = tabId,
457-
errMessage = err.message,
458-
retries = retriesRemaining(session),
459-
conversationId = session?.conversationIdUnsafe
460-
)
461-
}
462-
is CodeIterationLimitError -> {
454+
is CodeIterationLimitException -> {
463455
messenger.sendError(
464456
tabId = tabId,
465457
errMessage = err.message,
@@ -479,24 +471,36 @@ class FeatureDevController(
479471
)
480472
}
481473
else -> {
482-
var msg = createUserFacingErrorMessage("$FEATURE_NAME request failed: ${err.message ?: err.cause?.message}")
483-
val isDenyListedError = denyListedErrors.any { msg?.contains(it) ?: false }
484-
val defaultMessage: String = when (session?.sessionState?.phase) {
485-
SessionStatePhase.CODEGEN -> {
486-
if (isDenyListedError || retriesRemaining(session) > 0) {
487-
message("amazonqFeatureDev.code_generation.error_message")
488-
} else {
489-
message("amazonqFeatureDev.code_generation.no_retries.error_message")
474+
when (err) {
475+
is FeatureDevException -> {
476+
messenger.sendError(
477+
tabId = tabId,
478+
errMessage = err.message,
479+
retries = retriesRemaining(session),
480+
conversationId = session?.conversationIdUnsafe
481+
)
482+
}
483+
else -> {
484+
var msg = createUserFacingErrorMessage("$FEATURE_NAME request failed: ${err.message ?: err.cause?.message}")
485+
val isDenyListedError = denyListedErrors.any { msg?.contains(it) ?: false }
486+
val defaultMessage: String = when (session?.sessionState?.phase) {
487+
SessionStatePhase.CODEGEN -> {
488+
if (isDenyListedError || retriesRemaining(session) > 0) {
489+
message("amazonqFeatureDev.code_generation.error_message")
490+
} else {
491+
message("amazonqFeatureDev.code_generation.no_retries.error_message")
492+
}
493+
}
494+
else -> message("amazonqFeatureDev.error_text")
490495
}
496+
messenger.sendError(
497+
tabId = tabId,
498+
errMessage = defaultMessage,
499+
retries = retriesRemaining(session),
500+
conversationId = session?.conversationIdUnsafe
501+
)
491502
}
492-
else -> message("amazonqFeatureDev.error_text")
493503
}
494-
messenger.sendError(
495-
tabId = tabId,
496-
errMessage = defaultMessage,
497-
retries = retriesRemaining(session),
498-
conversationId = session?.conversationIdUnsafe
499-
)
500504
}
501505
}
502506
}

‎plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/CodeGenerationState.kt‎

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,13 @@ import software.amazon.awssdk.services.codewhispererruntime.model.CodeGeneration
88
import software.aws.toolkits.core.utils.getLogger
99
import software.aws.toolkits.core.utils.warn
1010
import software.aws.toolkits.jetbrains.services.amazonq.messages.MessagePublisher
11+
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.CodeGenerationException
1112
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FEATURE_NAME
12-
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.codeGenerationFailedError
13-
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.featureDevServiceError
13+
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FeatureDevException
14+
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FeatureDevOperation
15+
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.GuardrailsException
16+
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.PromptRefusalException
17+
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.ThrottlingException
1418
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendAnswerPart
1519
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendUpdatePlaceholder
1620
import software.aws.toolkits.jetbrains.services.cwc.controller.chat.telemetry.getStartUrl
@@ -37,6 +41,7 @@ class CodeGenerationState(
3741
val startTime = System.currentTimeMillis()
3842
var result: Result = Result.Succeeded
3943
var failureReason: String? = null
44+
var failureReasonDesc: String? = null
4045
var codeGenerationWorkflowStatus: CodeGenerationWorkflowStatus = CodeGenerationWorkflowStatus.COMPLETE
4146
var numberOfReferencesGenerated: Int? = null
4247
var numberOfFilesGenerated: Int? = null
@@ -86,6 +91,10 @@ class CodeGenerationState(
8691
logger.warn(e) { "$FEATURE_NAME: Code generation failed: ${e.message}" }
8792
result = Result.Failed
8893
failureReason = e.javaClass.simpleName
94+
if (e is FeatureDevException) {
95+
failureReason = e.reason()
96+
failureReasonDesc = e.reasonDesc()
97+
}
8998
codeGenerationWorkflowStatus = CodeGenerationWorkflowStatus.FAILED
9099

91100
throw e
@@ -100,6 +109,7 @@ class CodeGenerationState(
100109
amazonqRepositorySize = repositorySize,
101110
result = result,
102111
reason = failureReason,
112+
reasonDesc = failureReasonDesc,
103113
duration = (System.currentTimeMillis() - startTime).toDouble(),
104114
credentialStartUrl = getStartUrl(config.featureDevService.project)
105115
)
@@ -149,20 +159,20 @@ private suspend fun CodeGenerationState.generateCode(codeGenerationId: String, m
149159
codeGenerationResultState.codeGenerationStatusDetail()?.contains(
150160
"Guardrails"
151161
),
152-
-> featureDevServiceError(message("amazonqFeatureDev.exception.guardrails"))
162+
-> throw GuardrailsException(operation = FeatureDevOperation.GenerateCode.toString(), desc = "Failed guardrails")
153163
codeGenerationResultState.codeGenerationStatusDetail()?.contains(
154164
"PromptRefusal"
155165
),
156-
-> featureDevServiceError(message("amazonqFeatureDev.exception.prompt_refusal"))
166+
-> throw PromptRefusalException(operation = FeatureDevOperation.GenerateCode.toString(), desc = "Prompt refusal")
157167
codeGenerationResultState.codeGenerationStatusDetail()?.contains(
158168
"EmptyPatch"
159169
),
160-
-> featureDevServiceError(message("amazonqFeatureDev.exception.guardrails"))
170+
-> throw GuardrailsException(operation = FeatureDevOperation.GenerateCode.toString(), desc = "Empty patch") // FIXME
161171
codeGenerationResultState.codeGenerationStatusDetail()?.contains(
162172
"Throttling"
163173
),
164-
-> featureDevServiceError(message("amazonqFeatureDev.exception.throttling"))
165-
else -> codeGenerationFailedError()
174+
-> throw ThrottlingException(operation = FeatureDevOperation.GenerateCode.toString(), desc = "Request throttled")
175+
else -> throw CodeGenerationException(operation = FeatureDevOperation.GenerateCode.toString(), desc = null)
166176
}
167177
}
168178
else -> error("Unknown status: ${codeGenerationResultState.codeGenerationStatus().status()}")

‎plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/Session.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ import com.intellij.openapi.vfs.VfsUtil
99
import software.aws.toolkits.jetbrains.services.amazonq.FeatureDevSessionContext
1010
import software.aws.toolkits.jetbrains.services.amazonq.messages.MessagePublisher
1111
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.CODE_GENERATION_RETRY_LIMIT
12+
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.ConversationIdNotFoundException
1213
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FEATURE_NAME
1314
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.MAX_PROJECT_SIZE_BYTES
1415
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.clients.FeatureDevClient
15-
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.conversationIdNotFound
1616
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendAsyncEventProgress
1717
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.util.FeatureDevService
1818
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.util.resolveAndCreateOrUpdateFile
@@ -138,7 +138,7 @@ class Session(val tabID: String, val project: Project) {
138138
val conversationId: String
139139
get() {
140140
if (_conversationId == null) {
141-
conversationIdNotFound()
141+
throw ConversationIdNotFoundException(operation = "Session", desc = "Conversation ID not found")
142142
} else {
143143
return _conversationId as String
144144
}

0 commit comments

Comments
 (0)