Skip to content

Commit 554b331

Browse files
authored
Fix failure reporting in SsoAccessTokenProvider#refreshToken
`e.message` should be used for the proper error message
1 parent 85fd157 commit 554b331

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/sso/SsoAccessTokenProvider.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -419,10 +419,11 @@ class SsoAccessTokenProvider(
419419
is AwsServiceException -> e.requestId()
420420
else -> null
421421
}
422-
val message = when (e) {
423-
is AwsServiceException -> e.awsErrorDetails()?.errorMessage()
424-
else -> e.message
425-
} ?: "$stageName: Unknown error"
422+
423+
// AwsServiceException#message will automatically pull in AwsServiceException#awsErrorDetails
424+
// we expect messages for SsoOidcException to be populated in e.message using execution executor added in
425+
// https://github.com/aws/aws-toolkit-jetbrains/commit/cc9ed87fa9391dd39ac05cbf99b4437112fa3d10
426+
val message = e.message ?: "$stageName: ${e::class.java.name}"
426427

427428
sendRefreshCredentialsMetric(
428429
currentToken,

0 commit comments

Comments
 (0)