Skip to content

Commit 584947a

Browse files
authored
Remove the convention from changelog version (#2546)
Remove the convention to force us to remember to set it, since `project.version` defaults to "unspecified" which is surprising and hard to find issues
1 parent 0f7f417 commit 584947a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

build.gradle.kts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ tasks.register<GenerateGithubChangeLog>("generateChangeLog") {
3636
changeLogFile.set(project.file("CHANGELOG.md"))
3737
}
3838

39+
tasks.createRelease.configure {
40+
releaseVersion.set(providers.gradleProperty("toolkitVersion"))
41+
}
42+
3943
dependencies {
4044
aggregateCoverage(project(":intellij"))
4145
}

buildSrc/src/main/kotlin/software/aws/toolkits/gradle/changelog/tasks/CreateRelease.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,7 @@ open class CreateRelease @Inject constructor(projectLayout: ProjectLayout) : Cha
2323
val releaseDate: Property<String> = project.objects.property(String::class.java).convention(DateTimeFormatter.ISO_DATE.format(LocalDate.now()))
2424

2525
@Input
26-
val releaseVersion: Property<String> = project.objects.property(String::class.java).convention(
27-
project.provider {
28-
(project.version as String).substringBeforeLast('-')
29-
}
30-
)
26+
val releaseVersion: Property<String> = project.objects.property(String::class.java)
3127

3228
@Input
3329
@Optional

0 commit comments

Comments
 (0)