fix: address code scanning comments

Author: avi-alpert

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQChatServer.kt

@@ -235,11 +235,6 @@ object AmazonQChatServer : JsonRpcMethodProvider {
         CreatePromptParams::class.java
     )
 
-    val sendPinnedContext = JsonRpcNotification(
-        CHAT_SEND_PINNED_CONTEXT,
-        LSPAny::class.java
-    )
-
     val pinnedContextAdd = JsonRpcNotification(
         CHAT_PINNED_CONTEXT_ADD,
         LSPAny::class.java

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt

@@ -71,6 +71,7 @@ import software.aws.toolkits.jetbrains.isDeveloperMode
 import software.aws.toolkits.jetbrains.services.amazonq.lsp.artifacts.ArtifactManager
 import software.aws.toolkits.jetbrains.services.amazonq.lsp.auth.DefaultAuthCredentialsService
 import software.aws.toolkits.jetbrains.services.amazonq.lsp.dependencies.DefaultModuleDependenciesService
+import software.aws.toolkits.jetbrains.services.amazonq.lsp.editor.ActiveEditorChangeListener
 import software.aws.toolkits.jetbrains.services.amazonq.lsp.encryption.JwtEncryptionManager
 import software.aws.toolkits.jetbrains.services.amazonq.lsp.flareChat.AmazonQLspTypeAdapterFactory
 import software.aws.toolkits.jetbrains.services.amazonq.lsp.flareChat.AwsExtendedInitializeResult
@@ -561,11 +562,12 @@ private class AmazonQServerInstance(private val project: Project, private val cs
                     thread
                 }
 
-                // Register active editor change listener
-                software.aws.toolkits.jetbrains.services.amazonq.lsp.editor.ActiveEditorChangeListener.register(
+                ActiveEditorChangeListener.register(
                     project,
                     executor
-                )
+                ).also {
+                    Disposer.register(this, it)
+                }
                 LOG.info { "Registered active editor change listener" }
             }
         }

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/editor/ActiveEditorChangeListener.kt

@@ -28,7 +28,7 @@ class ActiveEditorChangeListener(
     private val executor: ScheduledExecutorService,
 ) : Disposable {
     private var debounceTask: ScheduledFuture<*>? = null
-    private val DEBOUNCE_DELAY_MS = 100L
+    private val debounceDelayMs = 100L
 
     init {
         val connection = project.messageBus.connect(this)
@@ -63,7 +63,7 @@ class ActiveEditorChangeListener(
             } catch (e: Exception) {
                 LOG.warn(e) { "Failed to send active editor changed notification" }
             }
-        }, DEBOUNCE_DELAY_MS, TimeUnit.MILLISECONDS)
+        }, debounceDelayMs, TimeUnit.MILLISECONDS)
     }
 
     override fun dispose() {
@@ -75,7 +75,6 @@ class ActiveEditorChangeListener(
 
         fun register(project: Project, executor: ScheduledExecutorService): ActiveEditorChangeListener {
             val listener = ActiveEditorChangeListener(project, executor)
-            Disposer.register(project, listener)
             return listener
         }
     }