Skip to content

Commit 5862224

Browse files
chore: Add warning to loginSso method regarding method signature changes. (#4644)
1 parent bc8e338 commit 5862224

File tree

1 file changed

+3
-0
lines changed
  • plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/credentials

1 file changed

+3
-0
lines changed

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,9 @@ interface ToolkitConnectionManager : Disposable {
105105

106106
/**
107107
* Individual service should subscribe [ToolkitConnectionManagerListener.TOPIC] to fire their service activation / UX update
108+
*
109+
* IMPORTANT: Do *not* update this method signature without consultation; an internal partner consumes this method.
110+
* Inter-plugin calls require relinking on each method signature change, even if it looks safe from a Kotlin standpoint.
108111
*/
109112
@Deprecated("Connections created through this function are not written to the user's ~/.aws/config file")
110113
fun loginSso(

0 commit comments

Comments
 (0)