Migrate from UI DSL v1 to v2 -7 (#3838)

* refactor sam init panel

* fixed detekt

Author: manodnyab

jetbrains-core/src/software/aws/toolkits/jetbrains/services/lambda/wizard/SamInitSelectionPanel.kt

@@ -10,7 +10,8 @@ import com.intellij.ui.IdeBorderFactory
 import com.intellij.ui.SimpleListCellRenderer
 import com.intellij.ui.components.JBLabel
 import com.intellij.ui.components.panels.Wrapper
-import com.intellij.ui.layout.panel
+import com.intellij.ui.dsl.builder.AlignX
+import com.intellij.ui.dsl.builder.panel
 import com.intellij.util.text.SemVer
 import software.amazon.awssdk.services.lambda.model.PackageType
 import software.aws.toolkits.core.lambda.LambdaArchitecture
@@ -89,7 +90,7 @@ class SamInitSelectionPanel(
             panel {
                 wizardFragments.values.forEach {
                     row {
-                        it(grow)
+                        cell(it).align(AlignX.FILL)
                     }
                 }
             }

jetbrains-core/src/software/aws/toolkits/jetbrains/services/lambda/wizard/SchemaSelectionPanel.kt

@@ -8,7 +8,7 @@ import com.intellij.openapi.roots.ModifiableRootModel
 import com.intellij.openapi.ui.TextFieldWithBrowseButton
 import com.intellij.openapi.ui.ValidationInfo
 import com.intellij.openapi.vfs.VfsUtil
-import com.intellij.ui.layout.panel
+import com.intellij.ui.dsl.builder.panel
 import software.amazon.awssdk.services.schemas.SchemasClient
 import software.aws.toolkits.core.lambda.LambdaRuntime
 import software.aws.toolkits.jetbrains.services.lambda.BuiltInRuntimeGroups
@@ -41,10 +41,10 @@ class SchemaSelectionPanel : WizardFragment {
     private val component by lazy {
         panel {
             row {
-                awsConnectionSelector.selectorPanel()(grow)
+                cell(awsConnectionSelector.selectorPanel())
             }
             row(message("sam.init.schema.label")) {
-                schemaSelector.component(grow)
+                cell(schemaSelector.component)
             }
         }
     }

jetbrains-core/src/software/aws/toolkits/jetbrains/services/lambda/wizard/SdkSelectionPanel.kt

@@ -13,10 +13,13 @@ import com.intellij.openapi.ui.TextFieldWithBrowseButton
 import com.intellij.openapi.ui.ValidationInfo
 import com.intellij.ui.ErrorLabel
 import com.intellij.ui.components.panels.Wrapper
-import com.intellij.ui.layout.panel
+import com.intellij.ui.dsl.builder.AlignX
+import com.intellij.ui.dsl.builder.BottomGap
+import com.intellij.ui.dsl.builder.panel
 import com.intellij.util.ThrowableRunnable
 import software.aws.toolkits.core.lambda.LambdaRuntime
 import software.aws.toolkits.jetbrains.services.lambda.RuntimeGroup
+import software.aws.toolkits.resources.message
 import javax.swing.JComponent
 import javax.swing.JLabel
 
@@ -67,7 +70,7 @@ class SdkSelectionPanel : WizardFragment {
 
     override fun updateUi(projectLocation: TextFieldWithBrowseButton?, runtimeGroup: RuntimeGroup?, template: SamProjectTemplate?) {
         if (runtimeGroup == null) {
-            component.setContent(ErrorLabel("No runtime selected"))
+            component.setContent(ErrorLabel(message("sam.init.sdk.runtime.not.selected")))
             return
         }
 
@@ -76,8 +79,8 @@ class SdkSelectionPanel : WizardFragment {
                 panel {
                     it?.let {
                         row(it.sdkSelectionLabel()) {
-                            it.sdkSelectionPanel()(grow)
-                        }
+                            cell(it.sdkSelectionPanel()).align(AlignX.FILL)
+                        }.bottomGap(BottomGap.MEDIUM)
                     }
                 }
             )

resources/resources/software/aws/toolkits/resources/MessagesBundle.properties

@@ -1145,6 +1145,7 @@ sam.init.schema.pleaseSelect=Choose the EventBridge serverless event schema
 sam.init.schema.registry.name=Registry: {0}
 sam.init.sdk.error=Check SDK settings
 sam.init.sdk.label=SDK:
+sam.init.sdk.runtime.not.selected=No runtime selected
 sam.init.select_sam_template=SAM Template:
 sam.init.template.dynamodb_cookiecutter.description=Sample SAM Template to interact with DynamoDB Events
 sam.init.template.dynamodb_cookiecutter.name=AWS SAM DynamoDB Event Example