Skip to content

Commit 5cb79c0

Browse files
authored
Add a metric on the continue button on login screen (#4650)
1 parent d1b3cc1 commit 5cb79c0

File tree

5 files changed

+17
-3
lines changed

5 files changed

+17
-3
lines changed

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QLoginWebview.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import software.aws.toolkits.jetbrains.services.amazonq.util.createBrowser
3636
import software.aws.toolkits.jetbrains.utils.isQConnected
3737
import software.aws.toolkits.jetbrains.utils.isQExpired
3838
import software.aws.toolkits.telemetry.FeatureId
39+
import software.aws.toolkits.telemetry.UiTelemetry
3940
import software.aws.toolkits.telemetry.WebviewTelemetry
4041
import java.awt.event.ActionListener
4142
import javax.swing.JButton
@@ -173,6 +174,10 @@ class QWebviewBrowser(val project: Project, private val parentDisposable: Dispos
173174
is BrowserMessage.LoginIAM, is BrowserMessage.ToggleBrowser -> {
174175
error("QBrowser doesn't support the provided command ${message::class.simpleName}")
175176
}
177+
178+
is BrowserMessage.SendTelemetry -> {
179+
UiTelemetry.click(project, "auth_continueButton")
180+
}
176181
}
177182
}
178183

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/webview/BrowserMessage.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ import com.fasterxml.jackson.annotation.JsonTypeInfo
2424
JsonSubTypes.Type(value = BrowserMessage.LoginIAM::class, name = "loginIAM"),
2525
JsonSubTypes.Type(value = BrowserMessage.CancelLogin::class, name = "cancelLogin"),
2626
JsonSubTypes.Type(value = BrowserMessage.Signout::class, name = "signout"),
27-
JsonSubTypes.Type(value = BrowserMessage.Reauth::class, name = "reauth")
27+
JsonSubTypes.Type(value = BrowserMessage.Reauth::class, name = "reauth"),
28+
JsonSubTypes.Type(value = BrowserMessage.SendTelemetry::class, name = "sendTelemetry")
2829
)
2930
sealed interface BrowserMessage {
3031

@@ -55,4 +56,6 @@ sealed interface BrowserMessage {
5556
object Signout : BrowserMessage
5657

5758
object Reauth : BrowserMessage
59+
60+
object SendTelemetry : BrowserMessage
5861
}

plugins/core/webview/src/q-ui/components/login.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ export default defineComponent({
8181
this.mutateStage('START')
8282
},
8383
login(type: LoginOption) {
84+
window.ideApi.postMessage({command: 'sendTelemetry'})
8485
this.selectedLoginOption = type
8586
this.mutateStage('AUTHENTICATING')
8687
if (type instanceof IdC) {
@@ -102,7 +103,7 @@ export default defineComponent({
102103
} else if (type instanceof ExistConnection) {
103104
window.ideApi.postMessage({ command: 'selectConnection', connectionId: type.pluginConnectionId})
104105
}
105-
},
106+
}
106107
},
107108
mounted() {},
108109
beforeUpdate() {}

plugins/core/webview/src/q-ui/components/loginOptions.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export default defineComponent({
3636
},
3737
login(type: LoginOption) {
3838
this.$emit('login', type)
39-
},
39+
}
4040
}
4141
})
4242
</script>

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/webview/ToolkitLoginWebview.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ import software.aws.toolkits.jetbrains.core.webview.WebviewResourceHandlerFactor
5858
import software.aws.toolkits.jetbrains.isDeveloperMode
5959
import software.aws.toolkits.jetbrains.utils.isTookitConnected
6060
import software.aws.toolkits.telemetry.FeatureId
61+
import software.aws.toolkits.telemetry.UiTelemetry
6162
import java.awt.event.ActionListener
6263
import javax.swing.JButton
6364
import javax.swing.JComponent
@@ -235,6 +236,10 @@ class ToolkitWebviewBrowser(val project: Project, private val parentDisposable:
235236
is BrowserMessage.Reauth -> {
236237
reauth(ToolkitConnectionManager.getInstance(project).activeConnectionForFeature(CodeCatalystConnection.getInstance()))
237238
}
239+
240+
is BrowserMessage.SendTelemetry -> {
241+
UiTelemetry.click(project, "auth_continueButton")
242+
}
238243
}
239244
}
240245

0 commit comments

Comments
 (0)