Fixing button name (and moving another to the general one) (#2148)

Author: kiiadi

jetbrains-core/src/software/aws/toolkits/jetbrains/services/iam/CreateIamRoleDialog.kt

@@ -34,7 +34,7 @@ class CreateIamRoleDialog(
 
     init {
         title = message("iam.create.role.title")
-        setOKButtonText(message("iam.create.role.create"))
+        setOKButtonText(message("general.create_button"))
 
         view.policyDocument.formatAndSet(defaultPolicyDocument, JsonLanguage.INSTANCE)
         view.assumeRolePolicyDocument.formatAndSet(defaultAssumeRolePolicyDocument, JsonLanguage.INSTANCE)
@@ -71,7 +71,7 @@ class CreateIamRoleDialog(
                 } catch (e: Exception) {
                     LOG.warn(e) { "Failed to create IAM role '${roleName()}'" }
                     setErrorText(e.message)
-                    setOKButtonText(message("iam.create.role.create"))
+                    setOKButtonText(message("general.create_button"))
                     isOKActionEnabled = true
                 }
             }

jetbrains-ultimate/src-201+/software/aws/toolkits/jetbrains/datagrip/actions/SecretsManagerDialogWrapper.kt

@@ -32,7 +32,7 @@ class SecretsManagerDialogWrapper(private val selected: AwsExplorerNode<*>) : Di
 
     init {
         title = message("datagrip.secretsmanager.action.title")
-        setOKButtonText(message("general.create_button"))
+        setOKButtonText(message("general.select_button"))
         init()
     }
 

resources/resources/software/aws/toolkits/resources/localized_messages.properties

@@ -403,12 +403,12 @@ general.create_button=Create
 general.file_not_found=File not found: "{0}"
 general.message=Message
 general.refresh=Refresh
+general.select_button=Select
 general.time=Time
 general.time.five_minutes=Five Minutes
 general.time.one_minute=One Minute
 general.time.ten_minutes=Ten Minutes
 general.unknown_error=Unknown error
-iam.create.role.create=Create
 iam.create.role.in_progress=Creating...
 iam.create.role.missing.role.name=Role name is required.
 iam.create.role.name.label=Name: