fix(amazonq): didOpen emits for files already open on IDE start (#5494)

* didOpen captures already open files in IDE

* linter

Author: samgst-amazon

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/textdocument/TextDocumentServiceHandler.kt

@@ -52,6 +52,27 @@ class TextDocumentServiceHandler(
             FileDocumentManagerListener.TOPIC,
             this
         )
+
+        // open files on startup
+        val fileEditorManager = FileEditorManager.getInstance(project)
+        fileEditorManager.openFiles.forEach { file ->
+            handleFileOpened(file)
+        }
+    }
+
+    private fun handleFileOpened(file: VirtualFile) {
+        AmazonQLspService.executeIfRunning(project) { languageServer ->
+            toUriString(file)?.let { uri ->
+                languageServer.textDocumentService.didOpen(
+                    DidOpenTextDocumentParams().apply {
+                        textDocument = TextDocumentItem().apply {
+                            this.uri = uri
+                            text = file.inputStream.readAllBytes().decodeToString()
+                        }
+                    }
+                )
+            }
+        }
     }
 
     override fun beforeDocumentSaving(document: Document) {
@@ -99,18 +120,7 @@ class TextDocumentServiceHandler(
         source: FileEditorManager,
         file: VirtualFile,
     ) {
-        AmazonQLspService.executeIfRunning(project) { languageServer ->
-            toUriString(file)?.let { uri ->
-                languageServer.textDocumentService.didOpen(
-                    DidOpenTextDocumentParams().apply {
-                        textDocument = TextDocumentItem().apply {
-                            this.uri = uri
-                            text = file.inputStream.readAllBytes().decodeToString()
-                        }
-                    }
-                )
-            }
-        }
+        handleFileOpened(file)
     }
 
     override fun fileClosed(

plugins/amazonq/shared/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/amazonq/lsp/textdocument/TextDocumentServiceHandlerTest.kt

@@ -9,6 +9,7 @@ import com.intellij.openapi.application.ApplicationManager
 import com.intellij.openapi.components.serviceIfCreated
 import com.intellij.openapi.editor.Document
 import com.intellij.openapi.fileEditor.FileDocumentManager
+import com.intellij.openapi.fileEditor.FileEditorManager
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.vfs.VirtualFile
 import com.intellij.openapi.vfs.newvfs.events.VFileContentChangeEvent
@@ -24,13 +25,13 @@ import io.mockk.runs
 import io.mockk.slot
 import io.mockk.verify
 import kotlinx.coroutines.test.runTest
+import org.assertj.core.api.Assertions.assertThat
 import org.eclipse.lsp4j.DidChangeTextDocumentParams
 import org.eclipse.lsp4j.DidCloseTextDocumentParams
 import org.eclipse.lsp4j.DidOpenTextDocumentParams
 import org.eclipse.lsp4j.DidSaveTextDocumentParams
 import org.eclipse.lsp4j.jsonrpc.messages.ResponseMessage
 import org.eclipse.lsp4j.services.TextDocumentService
-import org.junit.Assert.assertEquals
 import org.junit.Before
 import org.junit.Test
 import software.aws.toolkits.jetbrains.services.amazonq.lsp.AmazonQLanguageServer
@@ -43,6 +44,7 @@ import java.util.concurrent.CompletableFuture
 
 class TextDocumentServiceHandlerTest {
     private lateinit var project: Project
+    private lateinit var mockFileEditorManager: FileEditorManager
     private lateinit var mockLanguageServer: AmazonQLanguageServer
     private lateinit var mockTextDocumentService: TextDocumentService
     private lateinit var sut: TextDocumentServiceHandler
@@ -90,6 +92,11 @@ class TextDocumentServiceHandlerTest {
         every { messageBus.connect(any<Disposable>()) } returns mockConnection
         every { mockConnection.subscribe(any(), any()) } just runs
 
+        // Mock FileEditorManager
+        mockFileEditorManager = mockk<FileEditorManager>()
+        every { mockFileEditorManager.openFiles } returns emptyArray()
+        every { project.getService(FileEditorManager::class.java) } returns mockFileEditorManager
+
         sut = TextDocumentServiceHandler(project, mockk())
     }
 
@@ -120,12 +127,31 @@ class TextDocumentServiceHandlerTest {
             verify { mockTextDocumentService.didSave(capture(paramsSlot)) }
 
             with(paramsSlot.captured) {
-                assertEquals(normalizeFileUri(uri.toString()), textDocument.uri)
-                assertEquals("test content", text)
+                assertThat(textDocument.uri).isEqualTo(normalizeFileUri(uri.toString()))
+                assertThat(text).isEqualTo("test content")
             }
         }
     }
 
+    @Test
+    fun `didOpen runs on service init`() = runTest {
+        val uri = URI.create("file:///test/path/file.txt")
+        val content = "test content"
+        val file = createMockVirtualFile(uri, content)
+
+        every { mockFileEditorManager.openFiles } returns arrayOf(file)
+
+        sut = TextDocumentServiceHandler(project, mockk())
+
+        val paramsSlot = slot<DidOpenTextDocumentParams>()
+        verify { mockTextDocumentService.didOpen(capture(paramsSlot)) }
+
+        with(paramsSlot.captured.textDocument) {
+            assertThat(this.uri).isEqualTo(normalizeFileUri(uri.toString()))
+            assertThat(text).isEqualTo(content)
+        }
+    }
+
     @Test
     fun `didOpen runs on fileOpened`() = runTest {
         // Create test file
@@ -142,8 +168,8 @@ class TextDocumentServiceHandlerTest {
         verify { mockTextDocumentService.didOpen(capture(paramsSlot)) }
 
         with(paramsSlot.captured.textDocument) {
-            assertEquals(normalizeFileUri(uri.toString()), this.uri)
-            assertEquals(content, text)
+            assertThat(this.uri).isEqualTo(normalizeFileUri(uri.toString()))
+            assertThat(text).isEqualTo(content)
         }
     }
 
@@ -157,7 +183,7 @@ class TextDocumentServiceHandlerTest {
         val paramsSlot = slot<DidCloseTextDocumentParams>()
         verify { mockTextDocumentService.didClose(capture(paramsSlot)) }
 
-        assertEquals(normalizeFileUri(uri.toString()), paramsSlot.captured.textDocument.uri)
+        assertThat(paramsSlot.captured.textDocument.uri).isEqualTo(normalizeFileUri(uri.toString()))
     }
 
     @Test
@@ -191,9 +217,9 @@ class TextDocumentServiceHandlerTest {
         verify { mockTextDocumentService.didChange(capture(paramsSlot)) }
 
         with(paramsSlot.captured) {
-            assertEquals(normalizeFileUri(uri.toString()), textDocument.uri)
-            assertEquals(123, textDocument.version)
-            assertEquals("changed content", contentChanges[0].text)
+            assertThat(textDocument.uri).isEqualTo(normalizeFileUri(uri.toString()))
+            assertThat(textDocument.version).isEqualTo(123)
+            assertThat(contentChanges[0].text).isEqualTo("changed content")
         }
     }
 

plugins/amazonq/shared/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/amazonq/lsp/util/WorkspaceFolderUtilTest.kt

@@ -8,7 +8,7 @@ import com.intellij.openapi.roots.ProjectRootManager
 import com.intellij.openapi.vfs.VirtualFile
 import io.mockk.every
 import io.mockk.mockk
-import org.junit.jupiter.api.Assertions.assertEquals
+import org.assertj.core.api.Assertions.assertThat
 import org.junit.jupiter.api.Test
 import java.net.URI
 import java.nio.file.Path
@@ -22,7 +22,7 @@ class WorkspaceFolderUtilTest {
 
         val result = WorkspaceFolderUtil.createWorkspaceFolders(mockProject)
 
-        assertEquals(emptyList<VirtualFile>(), result)
+        assertThat(result).isEqualTo(emptyList<VirtualFile>())
     }
 
     @Test
@@ -44,11 +44,11 @@ class WorkspaceFolderUtilTest {
 
         val result = WorkspaceFolderUtil.createWorkspaceFolders(mockProject)
 
-        assertEquals(2, result.size)
-        assertEquals(normalizeFileUri("file:///path/to/root1"), result[0].uri)
-        assertEquals(normalizeFileUri("file:///path/to/root2"), result[1].uri)
-        assertEquals("root1", result[0].name)
-        assertEquals("root2", result[1].name)
+        assertThat(result).hasSize(2)
+        assertThat(result[0].uri).isEqualTo(normalizeFileUri("file:///path/to/root1"))
+        assertThat(result[1].uri).isEqualTo(normalizeFileUri("file:///path/to/root2"))
+        assertThat(result[0].name).isEqualTo("root1")
+        assertThat(result[1].name).isEqualTo("root2")
     }
 
     @Test
@@ -62,7 +62,7 @@ class WorkspaceFolderUtilTest {
 
         val result = WorkspaceFolderUtil.createWorkspaceFolders(mockProject)
 
-        assertEquals(emptyList<VirtualFile>(), result)
+        assertThat(result).isEqualTo(emptyList<VirtualFile>())
     }
 
     private fun createMockVirtualFile(uri: URI, name: String): VirtualFile {