Skip to content

Commit 606cadf

Browse files
fix: Chosing cancel on confirmation no longer deletes profiles (#5167) (#5176)
If the user selects cancel in the confirmation dialog, the sign out will now be aborted. The method logoutFromSsoConnection also calls deleteSsoConnection() if the connection is of type ProfileSsoManagedBearerSsoConnection, so it is does not have to be called from SsoLogoutAction.
1 parent e6d503d commit 606cadf

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type" : "bugfix",
3+
"description" : " Chosing cancel on sign out confirmation now cancels the sign out and does not delete profiles from ~/.aws/config (#5167)"
4+
}

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/actions/SsoLogoutAction.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import com.intellij.openapi.ui.MessageDialogBuilder
1010
import software.aws.toolkits.jetbrains.core.credentials.AwsBearerTokenConnection
1111
import software.aws.toolkits.jetbrains.core.credentials.ProfileSsoManagedBearerSsoConnection
1212
import software.aws.toolkits.jetbrains.core.credentials.ToolkitConnectionManagerListener
13-
import software.aws.toolkits.jetbrains.core.credentials.deleteSsoConnection
1413
import software.aws.toolkits.jetbrains.core.credentials.logoutFromSsoConnection
1514
import software.aws.toolkits.resources.AwsCoreBundle
1615
import software.aws.toolkits.telemetry.UiTelemetry
@@ -23,8 +22,8 @@ class SsoLogoutAction(private val value: AwsBearerTokenConnection) : DumbAwareAc
2322
AwsCoreBundle.message("gettingstarted.auth.idc.sign.out.confirmation.title"),
2423
AwsCoreBundle.message("gettingstarted.auth.idc.sign.out.confirmation")
2524
).yesText(AwsCoreBundle.message("general.confirm")).ask(e.project)
26-
if (confirmDeletion) {
27-
deleteSsoConnection(value)
25+
if (!confirmDeletion) {
26+
return
2827
}
2928
}
3029
logoutFromSsoConnection(e.project, value)

0 commit comments

Comments
 (0)