Fix IllegalCallableAccessException in UI DSL (#3233)

Author: rli

.changes/next-release/bugfix-21fddfde-8557-4490-94cb-4d9641f84fbb.json

@@ -0,0 +1,4 @@
+{
+  "type" : "bugfix",
+  "description" : "Fix IllegalCallableAccessException thrown in several UI panels (#3228)"
+}

jetbrains-core/src/software/aws/toolkits/jetbrains/services/ecr/actions/PushToRepositoryAction.kt

@@ -125,12 +125,12 @@ internal class PushToEcrDialog(
 ) : DialogWrapper(project, null, false, IdeModalityType.PROJECT) {
     private val coroutineScope = projectCoroutineScope(project)
     private val defaultTag = "latest"
-    private var type = BuildType.LocalImage
-    private var remoteTag = ""
     private val localImageRepoTags = CollectionComboBoxModel<LocalImage>()
 
-    private var localImage: LocalImage? = null
-    private var runConfiguration: DockerRunConfiguration? = null
+    var type = BuildType.LocalImage
+    var remoteTag = ""
+    var localImage: LocalImage? = null
+    var runConfiguration: DockerRunConfiguration? = null
 
     private val remoteRepos = ResourceSelector.builder()
         .resource(EcrResources.LIST_REPOS)
@@ -337,7 +337,7 @@ internal class PushToEcrDialog(
         }
     }
 
-    private enum class BuildType {
+    enum class BuildType {
         LocalImage, Dockerfile
     }
 }

jetbrains-core/src/software/aws/toolkits/jetbrains/services/ecs/exec/EnableDisableExecuteCommandWarning.kt

@@ -17,8 +17,8 @@ import javax.swing.JComponent
 
 class EnableDisableExecuteCommandWarning(private val project: Project, private val enable: Boolean, private val serviceName: String) : DialogWrapper(project) {
     private val warningIcon = JBLabel(Messages.getWarningIcon())
-    private var dontDisplayWarning = false
-    private var confirmNonProduction = false
+    var dontDisplayWarning = false
+    var confirmNonProduction = false
     private val settings = EcsExecCommandSettings.getInstance()
     private val component by lazy {
         panel {

jetbrains-core/src/software/aws/toolkits/jetbrains/services/ecs/exec/OpenShellInContainerDialog.kt

@@ -39,10 +39,11 @@ class OpenShellInContainerDialog(
     private val connectionSettings: ConnectionSettings
 ) : DialogWrapper(project) {
     private val coroutineScope = projectCoroutineScope(project)
-    private var task: String? = null
     private val shellList = listOf("/bin/bash", "/bin/sh", "/bin/zsh")
     private val shellOption = CollectionComboBoxModel(shellList)
-    private var shell: String = ""
+
+    var task: String? = null
+    var shell: String = ""
 
     init {
         super.init()

jetbrains-core/src/software/aws/toolkits/jetbrains/services/ecs/exec/RunCommandDialog.kt

@@ -34,8 +34,9 @@ class RunCommandDialog(private val project: Project, private val container: Cont
     DialogWrapper(project) {
     private val coroutineScope = projectCoroutineScope(project)
     private val commandList = CollectionComboBoxModel(commandsEnteredPreviously.toMutableList())
-    private var command = ""
-    private var task: String? = null
+
+    var command = ""
+    var task: String? = null
 
     init {
         super.init()

jetbrains-core/src/software/aws/toolkits/jetbrains/services/iam/CreateIamRoleDialog.kt

@@ -32,7 +32,6 @@ class CreateIamRoleDialog(
     private val view = CreateRolePanel(project)
 
     var iamRole: Role? = null
-        private set
 
     init {
         title = message("iam.create.role.title")

jetbrains-core/src/software/aws/toolkits/jetbrains/services/lambda/deploy/DeployServerlessApplicationDialog.kt

@@ -70,13 +70,13 @@ class DeployServerlessApplicationDialog(
     private val templateFile: VirtualFile,
     private val loadResourcesOnCreate: Boolean = true
 ) : DialogWrapper(project) {
-    private var useContainer: Boolean = false
-    private var newStackName: String = ""
-    private var requireReview: Boolean = false
-    private var deployType: DeployType = DeployType.CREATE
-    private var templateParameters: Map<String, String> = emptyMap()
-    private var tags: Map<String, String> = emptyMap()
-    private var showImageOptions: Boolean = false
+    var useContainer: Boolean = false
+    var newStackName: String = ""
+    var requireReview: Boolean = false
+    var deployType: DeployType = DeployType.CREATE
+    var templateParameters: Map<String, String> = emptyMap()
+    var tags: Map<String, String> = emptyMap()
+    var showImageOptions: Boolean = false
 
     // non-dsl components
     private val stackSelector = ResourceSelector.builder()
@@ -534,7 +534,7 @@ class DeployServerlessApplicationDialog(
         }
     }
 
-    private enum class DeployType {
+    enum class DeployType {
         CREATE,
         UPDATE
     }