Remove unncessary test compilation when not running test-related tasks (#4054)

rli · web-flow · commit 6dafec460eb2 · 2024-01-08T15:14:16.000-08:00
Implicit task dependency resolution was incorrectly resolved with `dependsOn` rather than `mustRunAfter`, which introduced a task dependency rather than task ordering
diff --git a/buildSrc/src/main/kotlin/toolkit-intellij-subplugin.gradle.kts b/buildSrc/src/main/kotlin/toolkit-intellij-subplugin.gradle.kts
@@ -244,7 +244,7 @@ tasks.withType<RunIdeForUiTestTask>().all {
 // weird implicit dependency issue, maybe with how the task graph works?
 // or because tests are on the ide classpath for some reason?
 tasks.named("classpathIndexCleanup") {
-    dependsOn(tasks.named("compileIntegrationTestKotlin"))
+    mustRunAfter(tasks.named("compileIntegrationTestKotlin"))
 }
 
 configurations.instrumentedJar.configure {

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ tasks.withType<RunIdeForUiTestTask>().all {`
`244`	`244`	`// weird implicit dependency issue, maybe with how the task graph works?`
`245`	`245`	`// or because tests are on the ide classpath for some reason?`
`246`	`246`	`tasks.named("classpathIndexCleanup") {`
`247`		`- dependsOn(tasks.named("compileIntegrationTestKotlin"))`
	`247`	`+ mustRunAfter(tasks.named("compileIntegrationTestKotlin"))`
`248`	`248`	`}`
`249`	`249`
`250`	`250`	`configurations.instrumentedJar.configure {`