Remote lambda run config UI bug fix (#2474)

manodnyab · web-flow · commit 7001d40bb46b · 2021-03-04T19:57:47.000-08:00
* Shows correct function on initialization

* Functions respect connection setting configured in the remoteLambda UI

* Change log entry description modified
diff --git a/.changes/next-release/bugfix-98fc2305-2aec-4bbd-974a-4bcaff6f1622.json b/.changes/next-release/bugfix-98fc2305-2aec-4bbd-974a-4bcaff6f1622.json
@@ -0,0 +1,4 @@
+{
+  "type" : "bugfix",
+  "description" : "Fixed the Remote Lambda Run Configuration failing to load the list of functions if not in active region"
+}
diff --git a/jetbrains-core/src/software/aws/toolkits/jetbrains/ui/connection/AwsConnectionSettingsSelector.kt b/jetbrains-core/src/software/aws/toolkits/jetbrains/ui/connection/AwsConnectionSettingsSelector.kt
@@ -78,7 +78,6 @@ class AwsConnectionSettingsSelector(
         if (regionId != null) {
             view.region.selectedRegion = regionProvider[regionId]
         }
-
         if (credentialProviderId == null) {
             return
         }
@@ -91,6 +90,7 @@ class AwsConnectionSettingsSelector(
         } catch (_: Exception) {
             view.credentialProvider.setSelectedInvalidCredentialsProvider(credentialProviderId)
         }
+        fireChange()
     }
 
     fun selectedCredentialProvider(): String? = view.credentialProvider.getSelectedCredentialsProvider()

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +{
 +  "type" : "bugfix",
 +  "description" : "Fixed the Remote Lambda Run Configuration failing to load the list of functions if not in active region"
 +}
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,6 @@ class AwsConnectionSettingsSelector(`
`78`	`78`	`if (regionId != null) {`
`79`	`79`	`view.region.selectedRegion = regionProvider[regionId]`
`80`	`80`	`}`
`81`		`-`
`82`	`81`	`if (credentialProviderId == null) {`
`83`	`82`	`return`
`84`	`83`	`}`
`@@ -91,6 +90,7 @@ class AwsConnectionSettingsSelector(`
`91`	`90`	`} catch (_: Exception) {`
`92`	`91`	`view.credentialProvider.setSelectedInvalidCredentialsProvider(credentialProviderId)`
`93`	`92`	`}`
	`93`	`+ fireChange()`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`fun selectedCredentialProvider(): String? = view.credentialProvider.getSelectedCredentialsProvider()`