Skip to content

Commit 718153b

Browse files
fix(amazonq): address comments
1 parent 2a007ad commit 718153b

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

plugins/amazonq/chat/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnectorTest.kt

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import com.intellij.openapi.vfs.LocalFileSystem
1010
import com.intellij.openapi.vfs.VirtualFile
1111
import com.intellij.testFramework.fixtures.CodeInsightTestFixture
1212
import com.intellij.testFramework.replaceService
13+
import org.assertj.core.api.Assertions.assertThat
1314
import org.junit.Before
1415
import org.junit.Test
1516
import org.mockito.Mockito.mockStatic
@@ -84,8 +85,8 @@ class BrowserConnectorTest : AmazonQTestBase() {
8485

8586
browserConnector.parseFindingsMessages(messagesMap)
8687

87-
assert(additionalMessages.size == 1)
88-
assert(additionalMessages[0] == otherMessage)
88+
assertThat(additionalMessages.size == 1)
89+
assertThat(additionalMessages[0] == otherMessage)
8990
}
9091

9192
@Test
@@ -99,7 +100,7 @@ class BrowserConnectorTest : AmazonQTestBase() {
99100

100101
browserConnector.parseFindingsMessages(messagesMap)
101102

102-
assert(additionalMessages.isEmpty())
103+
assertThat(additionalMessages).isEmpty()
103104
}
104105

105106
@Test
@@ -150,9 +151,9 @@ class BrowserConnectorTest : AmazonQTestBase() {
150151
eq(CodeWhispererConstants.CodeAnalysisScope.AGENTIC)
151152
)
152153

153-
assert(additionalMessages.isEmpty())
154-
assert(issuesCaptor.firstValue.isNotEmpty())
155-
assert(issuesCaptor.firstValue[0].title == "Test Issue")
154+
assertThat(additionalMessages).isEmpty()
155+
assertThat(issuesCaptor.firstValue.isNotEmpty())
156+
assertThat(issuesCaptor.firstValue[0].title == "Test Issue")
156157
}
157158
}
158159
}
@@ -192,8 +193,8 @@ class BrowserConnectorTest : AmazonQTestBase() {
192193
eq(CodeWhispererConstants.CodeAnalysisScope.AGENTIC)
193194
)
194195

195-
assert(issuesCaptor.firstValue.isEmpty())
196-
assert(additionalMessages.isEmpty())
196+
assertThat(issuesCaptor.firstValue.isEmpty())
197+
assertThat(additionalMessages).isEmpty()
197198
}
198199
}
199200

@@ -208,6 +209,6 @@ class BrowserConnectorTest : AmazonQTestBase() {
208209

209210
browserConnector.parseFindingsMessages(messagesMap)
210211

211-
assert(additionalMessages.isEmpty())
212+
assertThat(additionalMessages).isEmpty()
212213
}
213214
}

plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/codescan/CodeWhispererCodeScanManager.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -538,9 +538,7 @@ class CodeWhispererCodeScanManager(val project: Project) {
538538
}
539539

540540
fun addOnDemandIssues(issues: List<CodeWhispererCodeScanIssue>, scannedFiles: List<VirtualFile>, scope: CodeWhispererConstants.CodeAnalysisScope) =
541-
projectCoroutineScope(
542-
project
543-
).launch {
541+
defaultScope.launch {
544542
ondemandScanIssues = ondemandScanIssues + issues
545543
renderResponseOnUIThread(
546544
getCombinedScanIssues(),

0 commit comments

Comments
 (0)