Skip to content

Commit 7250461

Browse files
committed
fix windows tests
1 parent 90f6678 commit 7250461

File tree

2 files changed

+48
-21
lines changed

2 files changed

+48
-21
lines changed

plugins/amazonq/shared/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/amazonq/lsp/textdocument/TextDocumentServiceHandlerTest.kt

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ class TextDocumentServiceHandlerTest {
120120
verify { mockTextDocumentService.didSave(capture(paramsSlot)) }
121121

122122
with(paramsSlot.captured) {
123-
assertEquals(uri.toString(), textDocument.uri)
123+
assertEquals(normalizeFileUri(uri.toString()), textDocument.uri)
124124
assertEquals("test content", text)
125125
}
126126
}
@@ -142,7 +142,7 @@ class TextDocumentServiceHandlerTest {
142142
verify { mockTextDocumentService.didOpen(capture(paramsSlot)) }
143143

144144
with(paramsSlot.captured.textDocument) {
145-
assertEquals(uri.toString(), this.uri)
145+
assertEquals(normalizeFileUri(uri.toString()), this.uri)
146146
assertEquals(content, text)
147147
}
148148
}
@@ -157,7 +157,7 @@ class TextDocumentServiceHandlerTest {
157157
val paramsSlot = slot<DidCloseTextDocumentParams>()
158158
verify { mockTextDocumentService.didClose(capture(paramsSlot)) }
159159

160-
assertEquals(uri.toString(), paramsSlot.captured.textDocument.uri)
160+
assertEquals(normalizeFileUri(uri.toString()), paramsSlot.captured.textDocument.uri)
161161
}
162162

163163
@Test
@@ -191,7 +191,7 @@ class TextDocumentServiceHandlerTest {
191191
verify { mockTextDocumentService.didChange(capture(paramsSlot)) }
192192

193193
with(paramsSlot.captured) {
194-
assertEquals(uri.toString(), textDocument.uri)
194+
assertEquals(normalizeFileUri(uri.toString()), textDocument.uri)
195195
assertEquals(123, textDocument.version)
196196
assertEquals("changed content", contentChanges[0].text)
197197
}
@@ -286,4 +286,17 @@ class TextDocumentServiceHandlerTest {
286286
every { this@mockk.inputStream } returns inputStream
287287
}
288288
}
289+
290+
private fun normalizeFileUri(uri: String): String {
291+
if (!System.getProperty("os.name").lowercase().contains("windows")) {
292+
return uri
293+
}
294+
295+
if (!uri.startsWith("file:///")) {
296+
return uri
297+
}
298+
299+
val path = uri.substringAfter("file:///")
300+
return "file:///C:/$path"
301+
}
289302
}

plugins/amazonq/shared/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/amazonq/lsp/workspace/WorkspaceServiceHandlerTest.kt

Lines changed: 31 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ class WorkspaceServiceHandlerTest {
106106

107107
val paramsSlot = slot<CreateFilesParams>()
108108
verify { mockWorkspaceService.didCreateFiles(capture(paramsSlot)) }
109-
assertEquals(pyUri.toString(), paramsSlot.captured.files[0].uri)
109+
assertEquals(normalizeFileUri(pyUri.toString()), paramsSlot.captured.files[0].uri)
110110
}
111111

112112
@Test
@@ -118,7 +118,7 @@ class WorkspaceServiceHandlerTest {
118118

119119
val paramsSlot = slot<CreateFilesParams>()
120120
verify { mockWorkspaceService.didCreateFiles(capture(paramsSlot)) }
121-
assertEquals(tsUri.toString(), paramsSlot.captured.files[0].uri)
121+
assertEquals(normalizeFileUri(tsUri.toString()), paramsSlot.captured.files[0].uri)
122122
}
123123

124124
@Test
@@ -130,7 +130,7 @@ class WorkspaceServiceHandlerTest {
130130

131131
val paramsSlot = slot<CreateFilesParams>()
132132
verify { mockWorkspaceService.didCreateFiles(capture(paramsSlot)) }
133-
assertEquals(jsUri.toString(), paramsSlot.captured.files[0].uri)
133+
assertEquals(normalizeFileUri(jsUri.toString()), paramsSlot.captured.files[0].uri)
134134
}
135135

136136
@Test
@@ -142,7 +142,7 @@ class WorkspaceServiceHandlerTest {
142142

143143
val paramsSlot = slot<CreateFilesParams>()
144144
verify { mockWorkspaceService.didCreateFiles(capture(paramsSlot)) }
145-
assertEquals(javaUri.toString(), paramsSlot.captured.files[0].uri)
145+
assertEquals(normalizeFileUri(javaUri.toString()), paramsSlot.captured.files[0].uri)
146146
}
147147

148148
@Test
@@ -154,7 +154,7 @@ class WorkspaceServiceHandlerTest {
154154

155155
val paramsSlot = slot<CreateFilesParams>()
156156
verify { mockWorkspaceService.didCreateFiles(capture(paramsSlot)) }
157-
assertEquals(dirUri.toString(), paramsSlot.captured.files[0].uri)
157+
assertEquals(normalizeFileUri(dirUri.toString()), paramsSlot.captured.files[0].uri)
158158
}
159159

160160
@Test
@@ -176,7 +176,7 @@ class WorkspaceServiceHandlerTest {
176176

177177
val paramsSlot = slot<DeleteFilesParams>()
178178
verify { mockWorkspaceService.didDeleteFiles(capture(paramsSlot)) }
179-
assertEquals(pyUri.toString(), paramsSlot.captured.files[0].uri)
179+
assertEquals(normalizeFileUri(pyUri.toString()), paramsSlot.captured.files[0].uri)
180180
}
181181

182182
@Test
@@ -188,7 +188,7 @@ class WorkspaceServiceHandlerTest {
188188

189189
val paramsSlot = slot<DeleteFilesParams>()
190190
verify { mockWorkspaceService.didDeleteFiles(capture(paramsSlot)) }
191-
assertEquals(tsUri.toString(), paramsSlot.captured.files[0].uri)
191+
assertEquals(normalizeFileUri(tsUri.toString()), paramsSlot.captured.files[0].uri)
192192
}
193193

194194
@Test
@@ -200,7 +200,7 @@ class WorkspaceServiceHandlerTest {
200200

201201
val paramsSlot = slot<DeleteFilesParams>()
202202
verify { mockWorkspaceService.didDeleteFiles(capture(paramsSlot)) }
203-
assertEquals(jsUri.toString(), paramsSlot.captured.files[0].uri)
203+
assertEquals(normalizeFileUri(jsUri.toString()), paramsSlot.captured.files[0].uri)
204204
}
205205

206206
@Test
@@ -212,7 +212,7 @@ class WorkspaceServiceHandlerTest {
212212

213213
val paramsSlot = slot<DeleteFilesParams>()
214214
verify { mockWorkspaceService.didDeleteFiles(capture(paramsSlot)) }
215-
assertEquals(javaUri.toString(), paramsSlot.captured.files[0].uri)
215+
assertEquals(normalizeFileUri(javaUri.toString()), paramsSlot.captured.files[0].uri)
216216
}
217217

218218
@Test
@@ -234,7 +234,7 @@ class WorkspaceServiceHandlerTest {
234234

235235
val paramsSlot = slot<DeleteFilesParams>()
236236
verify { mockWorkspaceService.didDeleteFiles(capture(paramsSlot)) }
237-
assertEquals(dirUri.toString(), paramsSlot.captured.files[0].uri)
237+
assertEquals(normalizeFileUri(dirUri.toString()), paramsSlot.captured.files[0].uri)
238238
}
239239

240240
@Test
@@ -254,11 +254,11 @@ class WorkspaceServiceHandlerTest {
254254
// Assert
255255
val paramsSlot = slot<DidChangeWatchedFilesParams>()
256256
verify { mockWorkspaceService.didChangeWatchedFiles(capture(paramsSlot)) }
257-
assertEquals(createURI.toString(), paramsSlot.captured.changes[0].uri)
257+
assertEquals(normalizeFileUri(createURI.toString()), paramsSlot.captured.changes[0].uri)
258258
assertEquals(FileChangeType.Created, paramsSlot.captured.changes[0].type)
259-
assertEquals(deleteURI.toString(), paramsSlot.captured.changes[1].uri)
259+
assertEquals(normalizeFileUri(deleteURI.toString()), paramsSlot.captured.changes[1].uri)
260260
assertEquals(FileChangeType.Deleted, paramsSlot.captured.changes[1].type)
261-
assertEquals(changeURI.toString(), paramsSlot.captured.changes[2].uri)
261+
assertEquals(normalizeFileUri(changeURI.toString()), paramsSlot.captured.changes[2].uri)
262262
assertEquals(FileChangeType.Changed, paramsSlot.captured.changes[2].type)
263263
}
264264

@@ -291,8 +291,8 @@ class WorkspaceServiceHandlerTest {
291291
val paramsSlot = slot<RenameFilesParams>()
292292
verify { mockWorkspaceService.didRenameFiles(capture(paramsSlot)) }
293293
with(paramsSlot.captured.files[0]) {
294-
assertEquals("file:///test/$oldName", oldUri)
295-
assertEquals("file:///test/$newName", newUri)
294+
assertEquals(normalizeFileUri("file:///test/$oldName"), oldUri)
295+
assertEquals(normalizeFileUri("file:///test/$newName"), newUri)
296296
}
297297
}
298298

@@ -328,8 +328,8 @@ class WorkspaceServiceHandlerTest {
328328
val paramsSlot = slot<RenameFilesParams>()
329329
verify { mockWorkspaceService.didRenameFiles(capture(paramsSlot)) }
330330
with(paramsSlot.captured.files[0]) {
331-
assertEquals("file:///test/oldDir", oldUri)
332-
assertEquals("file:///test/newDir", newUri)
331+
assertEquals(normalizeFileUri("file:///test/oldDir"), oldUri)
332+
assertEquals(normalizeFileUri("file:///test/newDir"), newUri)
333333
}
334334
}
335335

@@ -566,4 +566,18 @@ class WorkspaceServiceHandlerTest {
566566
every { newValue } returns newName
567567
}
568568
}
569+
570+
// need this so Windows Unit tests don't break
571+
private fun normalizeFileUri(uri: String): String {
572+
if (!System.getProperty("os.name").lowercase().contains("windows")) {
573+
return uri
574+
}
575+
576+
if (!uri.startsWith("file:///")) {
577+
return uri
578+
}
579+
580+
val path = uri.substringAfter("file:///")
581+
return "file:///C:/$path"
582+
}
569583
}

0 commit comments

Comments
 (0)