feedback

Author: samgst-amazon

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt

@@ -28,6 +28,7 @@ import kotlinx.coroutines.launch
 import org.cef.browser.CefBrowser
 import org.eclipse.lsp4j.TextDocumentIdentifier
 import org.eclipse.lsp4j.jsonrpc.ResponseErrorException
+import org.eclipse.lsp4j.jsonrpc.messages.ResponseErrorCode
 import software.aws.toolkits.core.utils.error
 import software.aws.toolkits.core.utils.getLogger
 import software.aws.toolkits.core.utils.warn
@@ -384,6 +385,7 @@ class BrowserConnector(
 
             CHAT_TAB_BAR_ACTIONS -> {
                 handleChat(AmazonQChatServer.tabBarActions, node) { params, invoke ->
+                    println("handling TabBarActions")
                     invoke()
                         .whenComplete { actions, error ->
                             try {
@@ -401,13 +403,12 @@ class BrowserConnector(
                                 val cause = if (e is CompletionException) e.cause else e
 
                                 // dont post error to UI if user cancels export
-                                if (cause is ResponseErrorException && cause.responseError.code == "ResponseErrorCode.RequestCancelled) {
+                                if (cause is ResponseErrorException && cause.responseError.code == ResponseErrorCode.RequestCancelled.getValue()) {
                                     return@whenComplete
-}
-                                    LOG.error { "Failed to perform chat tab bar action $e" }
-                                    params.tabId?.let {
-                                        browser.postChat(chatCommunicationManager.getErrorUiMessage(it, e, null))
-                                    }
+                                }
+                                LOG.error { "Failed to perform chat tab bar action $e" }
+                                params.tabId?.let {
+                                    browser.postChat(chatCommunicationManager.getErrorUiMessage(it, e, null))
                                 }
                             }
                         }

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt

@@ -233,7 +233,7 @@ class AmazonQLanguageClientImpl(private val project: Project) : AmazonQLanguageC
 
                 chosenFile?.let {
                     ShowSaveFileDialogResult(chosenFile.file.path)
-                } ?: throw ResponseErrorException(ResponseError(ResponseErrorCode.RequestCancelled, "Export cancelled by user", null))
+                }?: throw ResponseErrorException(ResponseError(ResponseErrorCode.RequestCancelled, "Export cancelled by user", null))
             },
             ApplicationManager.getApplication()::invokeLater
         )