Redo our deprecation notice, notify about upcoming 202 deprecation (#2706)

Author: abrooksv

.changes/next-release/deprecation-8a9cd1d2-9051-4e01-b94d-c0f52687f411.json

@@ -0,0 +1,4 @@
+{
+  "type" : "deprecation",
+  "description" : "An upcoming release will remove support for IDEs based on the 2020.2 platform"
+}

jetbrains-core/resources/META-INF/plugin.xml

@@ -119,7 +119,6 @@ with what features/services are supported.
         <extensionPoint name="executable" interface="software.aws.toolkits.jetbrains.core.executables.ExecutableType" dynamic="true"/>
 
         <extensionPoint name="clouddebug.debuggerSupport" interface="software.aws.toolkits.jetbrains.services.clouddebug.DebuggerSupport" dynamic="true"/>
-        <extensionPoint name="notice" interface="software.aws.toolkits.jetbrains.core.notification.NoticeType" dynamic="true"/>
 
         <extensionPoint name="explorer.serviceNode" interface="software.aws.toolkits.jetbrains.core.explorer.nodes.AwsExplorerServiceNode" dynamic="true"/>
         <extensionPoint name="explorer.nodeProcessor" interface="software.aws.toolkits.jetbrains.core.explorer.AwsExplorerNodeProcessor" dynamic="true"/>
@@ -161,7 +160,6 @@ with what features/services are supported.
         <statusBarWidgetFactory implementation="software.aws.toolkits.jetbrains.core.credentials.AwsSettingsPanelInstaller"/>
 
         <postStartupActivity implementation="software.aws.toolkits.jetbrains.core.AwsTelemetryPrompter"/>
-        <postStartupActivity implementation="software.aws.toolkits.jetbrains.core.notification.NoticeStartupActivity"/>
         <postStartupActivity implementation="software.aws.toolkits.jetbrains.core.executables.ExecutableLoader"/>
 
         <applicationService serviceInterface="software.aws.toolkits.core.clients.SdkClientProvider"
@@ -171,8 +169,6 @@ with what features/services are supported.
                             testServiceImplementation="software.aws.toolkits.jetbrains.services.telemetry.MockTelemetryService" />
         <applicationService serviceInterface="software.aws.toolkits.jetbrains.core.executables.ExecutableManager"
                             serviceImplementation="software.aws.toolkits.jetbrains.core.executables.DefaultExecutableManager"/>
-        <applicationService serviceInterface="software.aws.toolkits.jetbrains.core.notification.NoticeManager"
-                            serviceImplementation="software.aws.toolkits.jetbrains.core.notification.DefaultNoticeManager"/>
         <applicationService serviceInterface="software.aws.toolkits.core.ToolkitClientManager"
                             serviceImplementation="software.aws.toolkits.jetbrains.core.AwsClientManager"
                             testServiceImplementation="software.aws.toolkits.jetbrains.core.MockClientManager"/>
@@ -207,6 +203,10 @@ with what features/services are supported.
         <runConfigurationProducer implementation="software.aws.toolkits.jetbrains.services.lambda.execution.local.LocalLambdaRunConfigurationProducer"/>
         <runConfigurationProducer implementation="software.aws.toolkits.jetbrains.services.lambda.execution.remote.RemoteLambdaRunConfigurationProducer"/>
 
+        <!-- Min Version Notice -->
+        <postStartupActivity implementation="software.aws.toolkits.jetbrains.core.notification.MinimumVersionChange"/>
+        <!-- TODO: Migrate to this FIX_WHEN_MIN_IS_203 <notificationGroup id="aws.toolkit_deprecation" displayType="STICKY_BALLOON" key="aws.toolkit_deprecation.title"/> -->
+
         <!-- ECS -->
         <configurationType implementation="software.aws.toolkits.jetbrains.services.ecs.execution.EcsCloudDebugRunConfigurationType"/>
         <programRunner implementation="software.aws.toolkits.jetbrains.services.clouddebug.execution.CloudDebuggingRunner"/>
@@ -248,8 +248,6 @@ with what features/services are supported.
         <explorer.nodeProcessor implementation="software.aws.toolkits.jetbrains.services.clouddebug.CloudDebuggingExplorerProcessor" />
         <explorer.treeStructure implementation="software.aws.toolkits.jetbrains.services.clouddebug.CloudDebuggingExplorerTreeStructureProvider"/>
 
-        <notice implementation="software.aws.toolkits.jetbrains.core.notification.JetBrainsMinimumVersionChange"/>
-
         <!-- Explorer nodes -->
         <explorer.serviceNode implementation="software.aws.toolkits.jetbrains.core.explorer.nodes.AppRunnerExplorerRootNode"/>
         <explorer.serviceNode implementation="software.aws.toolkits.jetbrains.core.explorer.nodes.CloudFormationExplorerRootNode"/>

jetbrains-core/src/software/aws/toolkits/jetbrains/core/notification/JetBrainsMinimumVersionChange.kt

@@ -0,0 +1,76 @@
+// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+package software.aws.toolkits.jetbrains.core.notification
+
+import com.intellij.ide.util.PropertiesComponent
+import com.intellij.notification.NotificationAction
+import com.intellij.notification.NotificationDisplayType
+import com.intellij.notification.NotificationGroup
+import com.intellij.notification.NotificationType
+import com.intellij.openapi.application.ApplicationInfo
+import com.intellij.openapi.application.ApplicationManager
+import com.intellij.openapi.application.ApplicationNamesInfo
+import com.intellij.openapi.extensions.ExtensionNotApplicableException
+import com.intellij.openapi.project.Project
+import com.intellij.openapi.startup.StartupActivity
+import software.aws.toolkits.resources.message
+
+class MinimumVersionChange @JvmOverloads constructor(isUnderTest: Boolean = false) : StartupActivity.DumbAware {
+    init {
+        if (ApplicationManager.getApplication().isUnitTestMode && !isUnderTest) {
+            throw ExtensionNotApplicableException.INSTANCE
+        }
+    }
+
+    override fun runActivity(project: Project) {
+        if (System.getProperty(SKIP_PROMPT)?.toBoolean() == true) {
+            return
+        }
+
+        // Setting is stored application wide
+        if (PropertiesComponent.getInstance().getBoolean(IGNORE_PROMPT)) {
+            return
+        }
+
+        if (ApplicationInfo.getInstance().build.baselineVersion >= MIN_VERSION) {
+            return
+        }
+
+        val title = message("aws.toolkit_deprecation.title")
+        val message = message(
+            "aws.toolkit_deprecation.message",
+            ApplicationNamesInfo.getInstance().fullProductName,
+            ApplicationInfo.getInstance().fullVersion,
+            MIN_VERSION_HUMAN
+        )
+
+        // TODO: Migrate to this FIX_WHEN_MIN_IS_203
+//        val notificationGroup = NotificationGroupManager.getInstance().getNotificationGroup("aws.toolkit_deprecation")
+        NOTIFICATION_GROUP.createNotification(title, message, NotificationType.WARNING)
+            .addAction(
+                NotificationAction.createSimpleExpiring(message("general.notification.action.hide_forever")) {
+                    PropertiesComponent.getInstance().setValue(IGNORE_PROMPT, true)
+                }
+            )
+            .notify(project)
+    }
+
+    companion object {
+        const val MIN_VERSION = 203
+        const val MIN_VERSION_HUMAN = "2020.3"
+
+        // Used by tests to make sure the prompt never shows up
+        const val SKIP_PROMPT = "aws.suppress_deprecation_prompt"
+        const val IGNORE_PROMPT = "aws.ignore_deprecation_prompt"
+
+        private val NOTIFICATION_GROUP = NotificationGroup(
+            "aws.toolkit_deprecation",
+            NotificationDisplayType.STICKY_BALLOON,
+            true,
+            null,
+            null,
+            message("aws.toolkit_deprecation.title"),
+        )
+    }
+}