Skip to content

Commit 73fe979

Browse files
committed
fetch disposable instance from ToolWindow
1 parent c552983 commit 73fe979

File tree

2 files changed

+9
-15
lines changed

2 files changed

+9
-15
lines changed

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/toolwindow/AmazonQToolWindowFactory.kt

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
package software.aws.toolkits.jetbrains.services.amazonq.toolwindow
55

6-
import com.intellij.openapi.Disposable
76
import com.intellij.openapi.actionSystem.ActionManager
87
import com.intellij.openapi.application.runInEdt
98
import com.intellij.openapi.project.DumbAware
@@ -37,9 +36,7 @@ import software.aws.toolkits.telemetry.FeatureId
3736
import java.awt.event.ComponentAdapter
3837
import java.awt.event.ComponentEvent
3938

40-
class AmazonQToolWindowFactory(
41-
private val disposable: Disposable,
42-
) : ToolWindowFactory, DumbAware {
39+
class AmazonQToolWindowFactory: ToolWindowFactory, DumbAware {
4340

4441
override fun createToolWindowContent(project: Project, toolWindow: ToolWindow) {
4542
val mainPanel = BorderLayoutPanel()
@@ -61,7 +58,7 @@ class AmazonQToolWindowFactory(
6158
}
6259
val contentManager = toolWindow.contentManager
6360

64-
project.messageBus.connect(disposable).subscribe(
61+
project.messageBus.connect(toolWindow.disposable).subscribe(
6562
ToolkitConnectionManagerListener.TOPIC,
6663
object : ToolkitConnectionManagerListener {
6764
override fun activeConnectionChanged(newConnection: ToolkitConnection?) {
@@ -70,7 +67,7 @@ class AmazonQToolWindowFactory(
7067
}
7168
)
7269

73-
project.messageBus.connect(disposable).subscribe(
70+
project.messageBus.connect(toolWindow.disposable).subscribe(
7471
RefreshQChatPanelButtonPressedListener.TOPIC,
7572
object : RefreshQChatPanelButtonPressedListener {
7673
override fun onRefresh() {
@@ -81,7 +78,7 @@ class AmazonQToolWindowFactory(
8178
}
8279
)
8380

84-
project.messageBus.connect(disposable).subscribe(
81+
project.messageBus.connect(toolWindow.disposable).subscribe(
8582
BearerTokenProviderListener.TOPIC,
8683
object : BearerTokenProviderListener {
8784
override fun onChange(providerId: String, newScopes: List<String>?) {

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/AwsToolkitExplorerFactory.kt

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
package software.aws.toolkits.jetbrains.core.explorer
55

66
import com.intellij.icons.AllIcons
7-
import com.intellij.openapi.Disposable
87
import com.intellij.openapi.actionSystem.ActionManager
98
import com.intellij.openapi.actionSystem.DefaultActionGroup
109
import com.intellij.openapi.application.ApplicationManager
@@ -47,9 +46,7 @@ import software.aws.toolkits.telemetry.FeatureId
4746
import java.util.EventListener
4847
import javax.swing.JComponent
4948

50-
class AwsToolkitExplorerFactory(
51-
private val disposable: Disposable,
52-
) : ToolWindowFactory, DumbAware {
49+
class AwsToolkitExplorerFactory: ToolWindowFactory, DumbAware {
5350

5451
override fun createToolWindowContent(project: Project, toolWindow: ToolWindow) {
5552
val notificationPanel = NotificationPanel()
@@ -115,7 +112,7 @@ class AwsToolkitExplorerFactory(
115112
toolWindow.activate(null)
116113
contentManager.setSelectedContent(content)
117114

118-
project.messageBus.connect(disposable).subscribe(
115+
project.messageBus.connect(toolWindow.disposable).subscribe(
119116
ToolkitConnectionManagerListener.TOPIC,
120117
object : ToolkitConnectionManagerListener {
121118
override fun activeConnectionChanged(newConnection: ToolkitConnection?) {
@@ -124,7 +121,7 @@ class AwsToolkitExplorerFactory(
124121
}
125122
)
126123

127-
project.messageBus.connect(disposable).subscribe(
124+
project.messageBus.connect(toolWindow.disposable).subscribe(
128125
AwsConnectionManager.CONNECTION_SETTINGS_STATE_CHANGED,
129126
object : ConnectionSettingsStateChangeNotifier {
130127
override fun settingsStateChanged(newState: ConnectionState) {
@@ -133,7 +130,7 @@ class AwsToolkitExplorerFactory(
133130
}
134131
)
135132

136-
project.messageBus.connect(disposable).subscribe(
133+
project.messageBus.connect(toolWindow.disposable).subscribe(
137134
BearerTokenProviderListener.TOPIC,
138135
object : BearerTokenProviderListener {
139136
override fun onChange(providerId: String, newScopes: List<String>?) {
@@ -146,7 +143,7 @@ class AwsToolkitExplorerFactory(
146143
}
147144
)
148145

149-
project.messageBus.connect(disposable).subscribe(
146+
project.messageBus.connect(toolWindow.disposable).subscribe(
150147
ShowToolkitListener.TOPIC,
151148
object : ShowToolkitListener {
152149
override fun showWebview(project: Project) {

0 commit comments

Comments
 (0)