Skip to content

Commit 7853ede

Browse files
authored
Fix DataGrip UI in 2022.1 (#3127)
1 parent fbeef6a commit 7853ede

File tree

5 files changed

+33
-10
lines changed

5 files changed

+33
-10
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type" : "bugfix",
3+
"description" : "Fix regression in DataGrip 2022.1 caused by new APIs in the platform (#3125)"
4+
}

jetbrains-ultimate/detekt-baseline-main.xml

Lines changed: 0 additions & 7 deletions
This file was deleted.
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
// Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package software.aws.toolkits.jetbrains.ui
5+
6+
abstract class AwsAuthWidget(userFieldEnabled: Boolean = true) : @Suppress("DEPRECATION") AwsAuthWidgetBase(userFieldEnabled)
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
// Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package software.aws.toolkits.jetbrains.ui
5+
6+
import com.intellij.database.dataSource.DatabaseConnectionConfig
7+
import com.intellij.database.dataSource.DatabaseConnectionPoint
8+
9+
abstract class AwsAuthWidget(userFieldEnabled: Boolean = true) : @Suppress("DEPRECATION") AwsAuthWidgetBase(userFieldEnabled) {
10+
override fun save(config: DatabaseConnectionConfig, copyCredentials: Boolean) {
11+
super.save(config, copyCredentials)
12+
save(config.dataSource, copyCredentials)
13+
}
14+
15+
override fun reset(point: DatabaseConnectionPoint, resetCredentials: Boolean) {
16+
super.reset(point, resetCredentials)
17+
reset(point.dataSource, resetCredentials)
18+
}
19+
}

jetbrains-ultimate/src/software/aws/toolkits/jetbrains/ui/AwsAuthWidget.kt renamed to jetbrains-ultimate/src/software/aws/toolkits/jetbrains/ui/AwsAuthWidgetBase.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ import software.aws.toolkits.jetbrains.utils.ui.selected
2121
import software.aws.toolkits.resources.message
2222
import javax.swing.JPanel
2323

24-
abstract class AwsAuthWidget(private val userFieldEnabled: Boolean = true) : JBDBCredsAuthProviderUserWidget() {
24+
@Deprecated("Use AwsAuthWidget shim instead") // FIX_WHEN_MIN_IS_221
25+
abstract class AwsAuthWidgetBase(private val userFieldEnabled: Boolean) : JBDBCredsAuthProviderUserWidget() {
2526
private val credentialSelector = CredentialProviderSelector()
2627
private val regionSelector = RegionSelector()
2728

@@ -75,8 +76,8 @@ abstract class AwsAuthWidget(private val userFieldEnabled: Boolean = true) : JBD
7576
regionSelector.setRegions(allRegions.values.toMutableList())
7677
val regionId = dataSource.additionalProperties[REGION_ID_PROPERTY]?.nullize()
7778
regionId?.let {
78-
allRegions[regionId]?.let {
79-
regionSelector.selectedRegion = it
79+
allRegions[regionId]?.let { region ->
80+
regionSelector.selectedRegion = region
8081
}
8182
}
8283

0 commit comments

Comments
 (0)