Fix lint errors (#4963)

laileni-aws · web-flow · commit 84b50bc36dc8 · 2024-10-11T11:39:25.000-07:00
* Fix lint errors

* Fix lint errors for plugin-amazonq:chat

* Fix lint errors for plugin-toolkit:jetbrains-core
diff --git a/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QLoginWebview.kt b/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QLoginWebview.kt
@@ -202,7 +202,7 @@ class QWebviewBrowser(val project: Project, private val parentDisposable: Dispos
             is BrowserMessage.SendUiClickTelemetry -> {
                 val signInOption = message.signInOptionClicked
                 if (signInOption.isNullOrEmpty()) {
-                    LOG.warn("Unknown sign in option")
+                    LOG.warn { "Unknown sign in option" }
                 } else {
                     UiTelemetry.click(project, signInOption)
                 }
diff --git a/plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererUserModificationTracker.kt b/plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererUserModificationTracker.kt
@@ -243,7 +243,7 @@ class CodeWhispererUserModificationTracker(private val project: Project) : Dispo
                 }
                 val modifiedSuggestion = document?.getText(
                     TextRange(suggestion.range.startOffset, suggestion.range.endOffset)
-                ) ?: ""
+                ).orEmpty()
                 val response = CodeWhispererClientAdaptor.getInstance(project)
                     .sendUserModificationTelemetry(
                         suggestion.sessionId,
diff --git a/plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/webview/ToolkitLoginWebview.kt b/plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/webview/ToolkitLoginWebview.kt
@@ -241,7 +241,7 @@ class ToolkitWebviewBrowser(val project: Project, private val parentDisposable:
             is BrowserMessage.SendUiClickTelemetry -> {
                 val signInOption = message.signInOptionClicked
                 if (signInOption.isNullOrEmpty()) {
-                    LOG.warn("Unknown sign in option")
+                    LOG.warn { "Unknown sign in option" }
                 } else {
                     UiTelemetry.click(project, signInOption)
                 }

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ class QWebviewBrowser(val project: Project, private val parentDisposable: Dispos`
`202`	`202`	`is BrowserMessage.SendUiClickTelemetry -> {`
`203`	`203`	`val signInOption = message.signInOptionClicked`
`204`	`204`	`if (signInOption.isNullOrEmpty()) {`
`205`		`- LOG.warn("Unknown sign in option")`
	`205`	`+ LOG.warn { "Unknown sign in option" }`
`206`	`206`	`} else {`
`207`	`207`	`UiTelemetry.click(project, signInOption)`
`208`	`208`	`}`
Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ class CodeWhispererUserModificationTracker(private val project: Project) : Dispo`
`243`	`243`	`}`
`244`	`244`	`val modifiedSuggestion = document?.getText(`
`245`	`245`	`TextRange(suggestion.range.startOffset, suggestion.range.endOffset)`
`246`		`- ) ?: ""`
	`246`	`+ ).orEmpty()`
`247`	`247`	`val response = CodeWhispererClientAdaptor.getInstance(project)`
`248`	`248`	`.sendUserModificationTelemetry(`
`249`	`249`	`suggestion.sessionId,`
Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ class ToolkitWebviewBrowser(val project: Project, private val parentDisposable:`
`241`	`241`	`is BrowserMessage.SendUiClickTelemetry -> {`
`242`	`242`	`val signInOption = message.signInOptionClicked`
`243`	`243`	`if (signInOption.isNullOrEmpty()) {`
`244`		`- LOG.warn("Unknown sign in option")`
	`244`	`+ LOG.warn { "Unknown sign in option" }`
`245`	`245`	`} else {`
`246`	`246`	`UiTelemetry.click(project, signInOption)`
`247`	`247`	`}`