Skip to content

Commit 874e837

Browse files
authored
Fix for Builder Id users Scan Popup. (#4418)
1 parent a20de84 commit 874e837

File tree

6 files changed

+15
-9
lines changed

6 files changed

+15
-9
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type" : "bugfix",
3+
"description" : "Fix for Code Scan Issue editor popup for Builder Id users."
4+
}

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/codescan/listeners/CodeWhispererCodeScanDocumentListener.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import software.aws.toolkits.core.utils.getLogger
1313
import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.CodeWhispererCodeScanIssue
1414
import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.CodeWhispererCodeScanManager
1515
import software.aws.toolkits.jetbrains.services.codewhisperer.explorer.CodeWhispererExplorerActionManager
16+
import software.aws.toolkits.jetbrains.services.codewhisperer.explorer.isUserBuilderId
1617
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants
1718
import javax.swing.tree.TreePath
1819

@@ -38,7 +39,7 @@ internal class CodeWhispererCodeScanDocumentListener(val project: Project) : Doc
3839
}
3940
scanManager.updateScanNodes(file)
4041

41-
if (editedTextRange.length > 0 && !CodeWhispererExplorerActionManager.getInstance().isMonthlyQuotaForCodeScansExceeded()) {
42+
if (editedTextRange.length > 0 && !CodeWhispererExplorerActionManager.getInstance().isMonthlyQuotaForCodeScansExceeded() && !isUserBuilderId(project)) {
4243
scanManager.debouncedRunCodeScan(CodeWhispererConstants.CodeAnalysisScope.FILE)
4344
}
4445
}

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/codescan/listeners/CodeWhispererCodeScanFileListener.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@ import com.intellij.openapi.editor.event.EditorFactoryListener
88
import com.intellij.openapi.project.Project
99
import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.CodeWhispererCodeScanManager
1010
import software.aws.toolkits.jetbrains.services.codewhisperer.explorer.CodeWhispererExplorerActionManager
11+
import software.aws.toolkits.jetbrains.services.codewhisperer.explorer.isUserBuilderId
1112
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants
1213

1314
internal class CodeWhispererCodeScanFileListener(val project: Project) : EditorFactoryListener {
1415
override fun editorCreated(event: EditorFactoryEvent) {
15-
if (!CodeWhispererExplorerActionManager.getInstance().isMonthlyQuotaForCodeScansExceeded()) {
16+
if (!CodeWhispererExplorerActionManager.getInstance().isMonthlyQuotaForCodeScansExceeded() && !isUserBuilderId(project)) {
1617
CodeWhispererCodeScanManager.getInstance(project).debouncedRunCodeScan(CodeWhispererConstants.CodeAnalysisScope.FILE)
1718
}
1819
}

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/explorer/actions/ResumeCodeScans.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import com.intellij.openapi.actionSystem.AnActionEvent
88
import com.intellij.openapi.project.DumbAwareAction
99
import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.CodeWhispererCodeScanManager
1010
import software.aws.toolkits.jetbrains.services.codewhisperer.explorer.CodeWhispererExplorerActionManager
11+
import software.aws.toolkits.jetbrains.services.codewhisperer.explorer.isUserBuilderId
1112
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants
1213
import software.aws.toolkits.resources.message
1314

@@ -21,7 +22,7 @@ class ResumeCodeScans : DumbAwareAction(
2122
val actionManager = CodeWhispererExplorerActionManager.getInstance()
2223
actionManager.setAutoCodeScan(project, true)
2324
// Run Proactive Code File Scan once toggle is enabled
24-
if (!actionManager.isMonthlyQuotaForCodeScansExceeded()) {
25+
if (!actionManager.isMonthlyQuotaForCodeScansExceeded() && !isUserBuilderId(project)) {
2526
CodeWhispererCodeScanManager.getInstance(project).debouncedRunCodeScan(CodeWhispererConstants.CodeAnalysisScope.FILE)
2627
}
2728
}

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/explorer/nodes/ResumeCodeScanNode.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import com.intellij.icons.AllIcons
77
import com.intellij.openapi.project.Project
88
import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.CodeWhispererCodeScanManager
99
import software.aws.toolkits.jetbrains.services.codewhisperer.explorer.CodeWhispererExplorerActionManager
10+
import software.aws.toolkits.jetbrains.services.codewhisperer.explorer.isUserBuilderId
1011
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants
1112
import software.aws.toolkits.resources.message
1213
import java.awt.event.MouseEvent
@@ -23,7 +24,7 @@ class ResumeCodeScanNode(nodeProject: Project) : CodeWhispererActionNode(
2324
actionManager.setAutoCodeScan(project, true)
2425

2526
// Run Proactive Code File Scan once toggle is enabled
26-
if (!actionManager.isMonthlyQuotaForCodeScansExceeded()) {
27+
if (!actionManager.isMonthlyQuotaForCodeScansExceeded() && !isUserBuilderId(project)) {
2728
CodeWhispererCodeScanManager.getInstance(project).debouncedRunCodeScan(CodeWhispererConstants.CodeAnalysisScope.FILE)
2829
}
2930
}

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/startup/CodeWhispererProjectStartupActivity.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,10 @@ class CodeWhispererProjectStartupActivity : StartupActivity.DumbAware {
4545
val actionManager = CodeWhispererExplorerActionManager.getInstance()
4646
val scanManager = CodeWhispererCodeScanManager.getInstance(project)
4747
actionManager.setMonthlyQuotaForCodeScansExceeded(false)
48+
// Setting up listeners for Auto File Code Scan triggers and Mouse Events.
49+
scanManager.setEditorListeners()
4850
// Run Proactive Code File Scan and disabling Auto File Scan for Builder ID Users.
49-
if (isUserBuilderId(project)) {
50-
actionManager.setAutoCodeScan(project, false)
51-
} else {
52-
// Setting up listeners for Auto File Code Scan triggers.
53-
scanManager.setEditorListeners()
51+
if (!isUserBuilderId(project)) {
5452
scanManager.debouncedRunCodeScan(CodeWhispererConstants.CodeAnalysisScope.FILE)
5553
}
5654

0 commit comments

Comments
 (0)