Fix generated telemetry types file exceeding IDE code insight size limit (#4829)

Author: rli

buildSrc/src/main/kotlin/toolkit-detekt.gradle.kts

@@ -2,12 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 import io.gitlab.arturbosch.detekt.Detekt
 import io.gitlab.arturbosch.detekt.DetektCreateBaselineTask
-import kotlin.reflect.KVisibility
-import kotlin.reflect.full.companionObject
-import kotlin.reflect.full.companionObjectInstance
-import kotlin.reflect.full.functions
-import kotlin.reflect.full.memberFunctions
-import kotlin.reflect.full.memberProperties
+import software.aws.toolkits.gradle.jvmTarget
 
 plugins {
     id("io.gitlab.arturbosch.detekt")
@@ -21,9 +16,9 @@ dependencies {
     detektPlugins(project(":detekt-rules"))
 }
 
-private val detektFiles = fileTree(projectDir).asFileTree.matching {
+private val detektFiles = fileTree(projectDir).matching {
     include("**/*.kt", "**/*.kts")
-    exclude("**/build/**")
+    exclude("**/build")
 }
 
 detekt {
@@ -36,14 +31,22 @@ detekt {
     autoCorrect = true
 }
 
+val javaVersion = project.jvmTarget().get()
+
 tasks.withType<Detekt>().configureEach {
+    jvmTarget = javaVersion.majorVersion
+    dependsOn(":detekt-rules:assemble")
+
     reports {
         html.required.set(true) // Human readable report
         xml.required.set(true) // Checkstyle like format for CI tool integrations
     }
 }
 
 tasks.withType<DetektCreateBaselineTask>().configureEach {
+    jvmTarget = javaVersion.majorVersion
+    dependsOn(":detekt-rules:assemble")
+
     // weird issue where the baseline tasks can't find the source code
     source.plus(detektFiles)
 }

buildSrc/src/main/kotlin/toolkit-kotlin-conventions.gradle.kts

@@ -1,9 +1,10 @@
-// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
-// SPDX-License-Identifier: Apache-2.0
-
 import io.gitlab.arturbosch.detekt.Detekt
 import io.gitlab.arturbosch.detekt.DetektCreateBaselineTask
-import software.aws.toolkits.gradle.jvmTarget
+import io.gitlab.arturbosch.detekt.DetektPlugin
+import org.jetbrains.kotlin.gradle.dsl.KotlinJvmProjectExtension
+
+// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
 
 plugins {
     id("java-library")
@@ -49,26 +50,6 @@ sourceSets {
     }
 }
 
-val javaVersion = project.jvmTarget().get()
-
-tasks.withType<Detekt>().configureEach {
-    jvmTarget = javaVersion.majorVersion
-    dependsOn(":detekt-rules:assemble")
-    include("**/*.kt")
-    exclude("build/**")
-    exclude("**/*.Generated.kt")
-    exclude("**/TelemetryDefinitions.kt")
-}
-
-tasks.withType<DetektCreateBaselineTask>().configureEach {
-    jvmTarget = javaVersion.majorVersion
-    dependsOn(":detekt-rules:assemble")
-    include("**/*.kt")
-    exclude("build/**")
-    exclude("**/*.Generated.kt")
-    exclude("**/TelemetryDefinitions.kt")
-}
-
 project.afterEvaluate {
     tasks.check {
         dependsOn(tasks.detekt, tasks.detektMain, tasks.detektTest)
@@ -78,3 +59,18 @@ project.afterEvaluate {
         }
     }
 }
+
+// can't figure out why exclude() doesn't work on the generated source tree, so copy logic from detekt
+project.extensions.getByType(KotlinJvmProjectExtension::class.java).target.compilations.configureEach {
+    val inputSource = kotlinSourceSets
+        .map { it.kotlin.sourceDirectories.filter { !it.path.contains("build") } }
+        .fold(project.files() as FileCollection) { collection, next -> collection.plus(next) }
+
+    tasks.named<Detekt>(DetektPlugin.DETEKT_TASK_NAME + name.capitalize()).configure {
+        setSource(inputSource)
+    }
+
+    tasks.named<DetektCreateBaselineTask>(DetektPlugin.BASELINE_TASK_NAME + name.capitalize()).configure {
+        setSource(inputSource)
+    }
+}

gradle/libs.versions.toml

@@ -25,7 +25,7 @@ mockitoKotlin = "5.4.0"
 mockk = "1.13.10"
 nimbus-jose-jwt = "9.40"
 node-gradle = "7.0.2"
-telemetryGenerator = "1.0.243"
+telemetryGenerator = "1.0.247"
 testLogger = "4.0.0"
 testRetry = "1.5.10"
 # test-only; platform provides slf4j transitively at runtime

plugins/core/jetbrains-community/build.gradle.kts

@@ -28,6 +28,10 @@ sourceSets {
 val generateTelemetry = tasks.register<GenerateTelemetry>("generateTelemetry") {
     inputFiles = listOf(file("${project.projectDir}/resources/telemetryOverride.json"))
     outputDirectory = project.layout.buildDirectory.dir("generated-src").get().asFile
+
+    doFirst {
+        outputDirectory.deleteRecursively()
+    }
 }
 
 tasks.compileKotlin {