Skip to content

Commit 8f8a36f

Browse files
authored
Check build against 2022.1 Beta (#3106)
1 parent 55c2adf commit 8f8a36f

File tree

9 files changed

+45
-32
lines changed

9 files changed

+45
-32
lines changed

buildSrc/src/main/kotlin/software/aws/toolkits/gradle/intellij/IdeVersions.kt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -131,37 +131,37 @@ object IdeVersions {
131131
name = "2022.1",
132132
community = ProductProfile(
133133
sdkFlavor = IdeFlavor.IC,
134-
sdkVersion = "221.4501-EAP-CANDIDATE-SNAPSHOT",
134+
sdkVersion = "221.5080-EAP-CANDIDATE-SNAPSHOT",
135135
plugins = commonPlugins + listOf(
136136
"java",
137137
"com.intellij.gradle",
138138
"org.jetbrains.idea.maven",
139-
"PythonCore:221.4501.155",
140-
"Docker:221.4501.155"
139+
"PythonCore:221.5080.106",
140+
"Docker:221.5080.106"
141141
)
142142
),
143143
ultimate = ProductProfile(
144144
sdkFlavor = IdeFlavor.IU,
145-
sdkVersion = "221.4501-EAP-CANDIDATE-SNAPSHOT",
145+
sdkVersion = "221.5080-EAP-CANDIDATE-SNAPSHOT",
146146
plugins = commonPlugins + listOf(
147147
"JavaScript",
148148
// Transitive dependency needed for javascript
149149
// Can remove when https://github.com/JetBrains/gradle-intellij-plugin/issues/608 is fixed
150150
"com.intellij.css",
151151
"JavaScriptDebugger",
152152
"com.intellij.database",
153-
"Pythonid:221.4501.155",
154-
"org.jetbrains.plugins.go:221.4501.155"
153+
"Pythonid:221.5080.93",
154+
"org.jetbrains.plugins.go:221.5080.93"
155155
)
156156
),
157157
rider = RiderProfile(
158-
sdkVersion = "2022.1-EAP3-SNAPSHOT",
158+
sdkVersion = "2022.1-EAP9-SNAPSHOT",
159159
plugins = commonPlugins + listOf(
160160
"rider-plugins-appender" // Workaround for https://youtrack.jetbrains.com/issue/IDEA-179607
161161
),
162162
netFrameworkTarget = "net472",
163163
rdGenVersion = "2022.1.3",
164-
nugetVersion = "2022.1.0-eap03"
164+
nugetVersion = "2022.1.0-eap09"
165165
)
166166
)
167167
).associateBy { it.name }

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ assertJ = "3.20.2" # Upgrading leads to SAM errors: https://youtrack.jetbrains.c
44
awsSdk = "2.17.138"
55
commonmark = "0.17.1"
66
detekt = "1.18.1"
7-
intellijGradle = "1.4.0"
7+
intellijGradle = "1.5.2"
88
intellijRemoteRobot = "0.11.11"
99
jackson = "2.11.1"
1010
jacoco = "0.8.7"

jetbrains-core/tst-221+/software/aws/toolkits/jetbrains/core/EditorUtils.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@ fun <T : EditorNotificationProvider, U : EditorNotificationPanel> getEditorNotif
1717
NonBlockingReadActionImpl.waitForAsyncTaskCompletion()
1818

1919
@Suppress("UNCHECKED_CAST")
20-
return EditorNotificationsImpl.getNotificationPanels(editor)?.get(provider) as? U
20+
return EditorNotificationsImpl.getNotificationPanels(editor)[provider] as? U
2121
}

jetbrains-core/tst/software/aws/toolkits/jetbrains/ui/ValidatingPanelTest.kt

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
package software.aws.toolkits.jetbrains.ui
55

6-
import com.intellij.openapi.application.ApplicationInfo
76
import com.intellij.openapi.ui.ComponentValidator
87
import com.intellij.openapi.ui.ValidationInfo
98
import com.intellij.testFramework.ApplicationRule
@@ -137,25 +136,6 @@ class ValidatingPanelTest {
137136
textFieldComponent = this
138137
}
139138
}
140-
}.apply {
141-
// HACK: 221.4501 broke validation on input. delete this entire `apply` block when on a later snapshot
142-
// trick the registration logic
143-
val info = ApplicationInfo.getInstance()
144-
if (info.majorVersion == "2022" && info.minorVersionMainPart == "1") {
145-
if (info.build.asStringWithoutProductCodeAndSnapshot() > "221.4501.171") {
146-
throw RuntimeException("Delete validating panel test hack")
147-
}
148-
149-
// reflection so it's easier to delete the hack later
150-
val clazz = contentPanel::class.java
151-
val componentValidations = clazz.getMethod("getComponentValidations")
152-
val setComponentValidationsOnApply = clazz.getMethod("setComponentValidationsOnApply", Map::class.java)
153-
setComponentValidationsOnApply.invoke(contentPanel, componentValidations.invoke(contentPanel))
154-
// and reregister the validator
155-
contentPanel.registerValidators(disposableRule.disposable) { map ->
156-
updateActionButtons(map.isEmpty())
157-
}
158-
}
159139
}
160140

161141
private fun JBTextField.validateText() = if (this.text.length < 5) ValidationInfo("Test Error, '${this.text}'.length() < 5", this) else null

jetbrains-rider/build.gradle.kts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ intellijToolkit {
3939
ideFlavor.set(IdeFlavor.RD)
4040
}
4141

42+
intellij {
43+
type.set("RD")
44+
}
45+
4246
sourceSets {
4347
main {
4448
java.srcDirs("$buildDir/generated-src")

jetbrains-rider/tst/software/aws/toolkits/jetbrains/services/lambda/completion/DotNetHandlerCompletionTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,6 @@ class DotNetHandlerCompletionTest : BaseTestWithSolution() {
5858
assertThat(iconModel).isNotNull
5959
val ideaIconSecond = iconModel?.let { completionItemToIcon(project, iconModel) as? IconLoader.CachedImageIcon }
6060
assertThat(ideaIconSecond).isNotNull
61-
assertThat(ideaIconSecond?.originalPath).isEqualTo(expectedPath.trimStart('/'))
61+
assertThat(ideaIconSecond?.url?.path).endsWith(expectedPath.trimStart('/'))
6262
}
6363
}

jetbrains-ultimate/tst-213+/com/goide/vgo/VgoTestUtil.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import java.util.Objects;
3737
import org.jetbrains.annotations.NotNull;
3838
import org.jetbrains.annotations.Nullable;
39+
import software.aws.toolkits.jetbrains.go.VgoCompatShims;
3940

4041
public class VgoTestUtil {
4142
private static final String GOPATH = getGoTestDataPath("vgo/src/test/testData/mockGoPath").getAbsolutePath();
@@ -103,7 +104,7 @@ public static VgoModule createVgoModule(@NotNull CodeInsightTestFixture fixture,
103104
@NotNull Map<String, VgoDependency> dependencies) {
104105
String goModPath = modulePath != null ? FileUtil.join(modulePath, VgoUtil.GO_MOD) : VgoUtil.GO_MOD;
105106
PsiFile file = fixture.addFileToProject(goModPath, "module \"" + importPath + "\"");
106-
return new VgoModule(file.getVirtualFile().getParent(), importPath, dependencies);
107+
return VgoCompatShims.newVgoModule(file.getVirtualFile().getParent(), importPath, null, dependencies);
107108
}
108109

109110
public static void setupVgoIntegration(@NotNull CodeInsightTestFixture fixture, @NotNull List<VgoModule> modules) {
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
// Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package software.aws.toolkits.jetbrains.go
5+
6+
import com.goide.vgo.project.VgoDependency
7+
import com.goide.vgo.project.VgoModule
8+
import com.intellij.openapi.vfs.VirtualFile
9+
10+
object VgoCompatShims {
11+
@JvmStatic
12+
fun newVgoModule(root: VirtualFile, importPath: String, goVersion: String?, dependencies: Map<String, VgoDependency>) =
13+
VgoModule(root, importPath, dependencies)
14+
}
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
// Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package software.aws.toolkits.jetbrains.go
5+
6+
import com.goide.vgo.project.VgoDependency
7+
import com.goide.vgo.project.VgoStandaloneModule
8+
import com.intellij.openapi.vfs.VirtualFile
9+
10+
object VgoCompatShims {
11+
@JvmStatic
12+
fun newVgoModule(root: VirtualFile, importPath: String, goVersion: String?, dependencies: Map<String, VgoDependency>) =
13+
VgoStandaloneModule(root, importPath, goVersion, dependencies.values)
14+
}

0 commit comments

Comments
 (0)